From patchwork Sun May 21 07:15:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 9739093 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7DEE560326 for ; Sun, 21 May 2017 14:43:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7191C286B7 for ; Sun, 21 May 2017 14:43:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6505B286D7; Sun, 21 May 2017 14:43:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 26540286B7 for ; Sun, 21 May 2017 14:43:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F02EA6E184; Sun, 21 May 2017 14:43:08 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 819986E040; Sun, 21 May 2017 07:16:05 +0000 (UTC) Received: by mail-pf0-x242.google.com with SMTP id w69so13968661pfk.1; Sun, 21 May 2017 00:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=2oZ2AeJ+sjT7Bahup0sToLXUy1xZ2DWf7suEJ/9u4nU=; b=HJo/Wjy6lOAnc9vaAHq87fU5LHqlK0pfQBHPojnt1K0GS9x0mA0z2XCmAb5L34tBs1 HrOqulb6xJInohj8Nb/Ijf1SKxVywI6RoE2fCB0W6175FGC3dJykT0GV8K7exvlcdyoR zjsQJtUfZQ5Zc7k/RWl8itunTa0f2gUUwrme6Hxcy6KUBXFYBc0urM8YnQ8mFKrJGjuE XO720WpFZ+RSBEo+OF2wXpue81gPzfHROvPw71stUhPK6Ug2qCX9fdWyHWMcivkSzsTi J4FYEP9w+ow2oFw+ZfQfoNEvw9HzjBgq9+pY7FOrc1SWrqFdJcW4jZ7bmZ1mLh3okgS6 DiPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2oZ2AeJ+sjT7Bahup0sToLXUy1xZ2DWf7suEJ/9u4nU=; b=cQUXoc+uCsg6RbCpkhlxn7Q838VuXSyd4rveHTuDi41hmGoGCWXppLvDqiawZ9cqj2 JW57/fCVOnPazoIFrNewZOuaImb3CLo9dOcO6tpttihgbADgiihQrXNwmgto4qHwuaDn wAxjF+itOspMhzHDzNbgxpBWT2SeU7OGYRIrrLa+5FaHwbbXomxzdFEK5hOoUGRz7Szo QM2/PjF6xRpDQ3UXpo/XO8Q2GC4Us2gpa6Jf/Gjrob77J25nTwcoP4G7gdtMv+ezu7Un 0weoyvKrSkODBPw5wS/vF/XqP7rXcqGPkfv7jXSu27RBDv0PU8agAWhqdmcDxkMddiX+ OAFg== X-Gm-Message-State: AODbwcD5uAh36RlL05ZLThpbG6ZP76UqvQUugGVJShsVhgM3bD4mxioo ddY0RNlBZM1id3iqhtw= X-Received: by 10.99.53.12 with SMTP id c12mr18984389pga.38.1495350965161; Sun, 21 May 2017 00:16:05 -0700 (PDT) Received: from localhost.localdomain ([2601:647:4701:31a:320e:d5ff:febd:81c]) by smtp.googlemail.com with ESMTPSA id c19sm21498328pgk.32.2017.05.21.00.16.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 May 2017 00:16:03 -0700 (PDT) From: Nick Desaulniers To: Subject: [PATCH] drm/i915/gvt: remove redundant -Wall Date: Sun, 21 May 2017 00:15:27 -0700 Message-Id: <20170521071527.17799-1-nick.desaulniers@gmail.com> X-Mailer: git-send-email 2.11.0 X-Mailman-Approved-At: Sun, 21 May 2017 14:43:01 +0000 Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Daniel Vetter , intel-gvt-dev@lists.freedesktop.org, Zhi Wang X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP This flag is already set in the top level Makefile of the kernel. Also, by having set CONFIG_DRM_I915_GVT, thereby appending -Wall to ccflags, you undo all the -Wno-* cflags previously set in the Make variable KBUILD_CFLAGS. For example: cc foo.c -Wall -Wno-format -Wall resets -Wformat. Signed-off-by: Nick Desaulniers --- I verified that -Wall was redundant by compiling with V=1: make V=1 -j4 drivers/gpu/drm/i915/i915_gem_request.o drivers/gpu/drm/i915/gvt/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile index b123c20e2097..f5486cb94818 100644 --- a/drivers/gpu/drm/i915/gvt/Makefile +++ b/drivers/gpu/drm/i915/gvt/Makefile @@ -3,6 +3,6 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ interrupt.o gtt.o cfg_space.o opregion.o mmio.o display.o edid.o \ execlist.o scheduler.o sched_policy.o render.o cmd_parser.o -ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall +ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o