| Message ID | 20170524145212.27837-18-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 24 May 2017 16:51:52 +0200 Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > Again almost correct, but since interrupts are shut down after vblank > still a race. Proper cleanup would call drm_atomic_helper_shutdown to > make sure this really is safe. > > v2: Remove misplace malidp hunk (Liviu). > > Cc: Boris Brezillon <boris.brezillon@free-electrons.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > index f4a3065f7f51..288dd4b70126 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > @@ -678,7 +678,6 @@ static void atmel_hlcdc_dc_unload(struct drm_device *dev) > flush_workqueue(dc->wq); > drm_kms_helper_poll_fini(dev); > drm_mode_config_cleanup(dev); > - drm_vblank_cleanup(dev); > > pm_runtime_get_sync(dev->dev); > drm_irq_uninstall(dev);
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c index f4a3065f7f51..288dd4b70126 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c @@ -678,7 +678,6 @@ static void atmel_hlcdc_dc_unload(struct drm_device *dev) flush_workqueue(dc->wq); drm_kms_helper_poll_fini(dev); drm_mode_config_cleanup(dev); - drm_vblank_cleanup(dev); pm_runtime_get_sync(dev->dev); drm_irq_uninstall(dev);
Again almost correct, but since interrupts are shut down after vblank still a race. Proper cleanup would call drm_atomic_helper_shutdown to make sure this really is safe. v2: Remove misplace malidp hunk (Liviu). Cc: Boris Brezillon <boris.brezillon@free-electrons.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 1 - 1 file changed, 1 deletion(-)