From patchwork Wed May 24 14:52:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9746203 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9DE9160209 for ; Wed, 24 May 2017 14:55:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9373728991 for ; Wed, 24 May 2017 14:55:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 886B82899C; Wed, 24 May 2017 14:55:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4E96628991 for ; Wed, 24 May 2017 14:55:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC47B6E7C6; Wed, 24 May 2017 14:53:17 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id C730E6E77C for ; Wed, 24 May 2017 14:52:56 +0000 (UTC) Received: by mail-wr0-x242.google.com with SMTP id v42so10023399wrc.3 for ; Wed, 24 May 2017 07:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iRiMulz+k/Ye3yZ0FJ74QScK+Gno9Okq1qZ8tqpa6o0=; b=Y5owbQolGppgG9MRpjW9rpIopI149Y0ed4c96CZMyTYi5Z5u9okMqkoWD/7O2RE5Q8 WdnM7rgY2DukFQjOkmWW58H351eXFc/SV/D19zNJtTCYuwONnXjjlg3hVZR+7DWwPPbJ 99toWVxzIxQMwNerlE5kmCpS+oZB5k9wstS0Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iRiMulz+k/Ye3yZ0FJ74QScK+Gno9Okq1qZ8tqpa6o0=; b=Y8B3b/ZwT2VDR8dFehRwk7Ttop5tNcvaB4I6t6PeWGR7IJQygQRKTQhZLdft/uys5z uuvy4Qmal6KyXm6M1x5qDA8tOOaUkCvafEW49CzPEjtIvX9kUCPCZ8tl333/XzvzFq0r zLgIoed2+jt6tWdsvo6V2S5qE8W3LgI0jXDjD6jPmhCPDxG4tn98n0EvQQr1KrFE+4iQ lr/uHWbAR/IzVnAL7OQjbhbgwMA3Y+3ORYPmuYjUfB2H5bLAofRTja6MUqxrjbBX8rvu GWijbLZZYg6211Jk+cBakmKuL+sVpCGDlvdfGpzMmUNzvDVC5H8QGqwnm6ADVPBH8xG+ LL/Q== X-Gm-Message-State: AODbwcDgHS4TTn3T8HydH0ZdHMLOI47pO3MF9J8iT1IkJG2jLPipErZd LOzoV8gVpVoKAudJ X-Received: by 10.80.160.231 with SMTP id 94mr7677316edo.173.1495637575278; Wed, 24 May 2017 07:52:55 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5640:0:960b:2678:e223:c1c6]) by smtp.gmail.com with ESMTPSA id m9sm1778858edm.62.2017.05.24.07.52.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 May 2017 07:52:54 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 27/37] drm/nouveau: Drop drm_vblank_cleanup Date: Wed, 24 May 2017 16:52:02 +0200 Message-Id: <20170524145212.27837-28-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170524145212.27837-1-daniel.vetter@ffwll.ch> References: <20170524145212.27837-1-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Daniel Vetter , Intel Graphics Development , Ben Skeggs , nouveau@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP nouveau_display_vblank_fini is called in the load error path (where it doesn't matter) and module unload (where vblanks have been shut down correctly already through drm_vblank_off), we can drop it. Cc: Ben Skeggs Cc: nouveau@lists.freedesktop.org Signed-off-by: Daniel Vetter --- drivers/gpu/drm/nouveau/nouveau_display.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c index 8d1df5678eaa..b9a109be989c 100644 --- a/drivers/gpu/drm/nouveau/nouveau_display.c +++ b/drivers/gpu/drm/nouveau/nouveau_display.c @@ -159,8 +159,6 @@ nouveau_display_vblank_fini(struct drm_device *dev) { struct drm_crtc *crtc; - drm_vblank_cleanup(dev); - list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) { struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc); nvif_notify_fini(&nv_crtc->vblank);