From patchwork Fri Jun 9 12:25:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikko Perttunen X-Patchwork-Id: 9778361 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F0B646034B for ; Fri, 9 Jun 2017 12:26:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E1D9328421 for ; Fri, 9 Jun 2017 12:26:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D640C2860C; Fri, 9 Jun 2017 12:26:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7E12528421 for ; Fri, 9 Jun 2017 12:26:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF5DE6E5DE; Fri, 9 Jun 2017 12:26:05 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail.kapsi.fi (mail.kapsi.fi [IPv6:2001:1bc8:1004::1:25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 901996E5D9 for ; Fri, 9 Jun 2017 12:26:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=3qIPsSaYcunCmIsQ0cW0ncAnRX6a2j4E+h5bfpxUYSM=; b=dNWFJIqigsuHxKQh7L6b8MS/+kkp9f2ESctDb3i7Ga1tTXUqi+9FmIxKdr0TtNh/GwwnafJwy+HVRkxnnRsJwSalwFKn5L9NzkBFftLkcgbhBA9Cgj+EfaS5x5qQB4eFSVn5455vGhEAoHL4MuJw9fJP/DYdho+54AU/v+nEBZnXvAQSFZ3C6eP8zuH6qWE3ABiwZtqztNmayGhHqsj1Uw3OngfEow05yAISantmJ+BoJ0BPeWQJiuB8H2X955UZwtiUQeY2L+smKKELCAwtGxQ5VtCyWLExr3xkoLByne8ePs3SHZAxyLmUEduIfeLNa+E3W3OXcVnrCS51AG+9oA==; Received: from dsl-espbrasgw1-54f9c1-183.dhcp.inet.fi ([84.249.193.183] helo=toshino.dhcp.inet.fi) by mail.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1dJIzJ-0002Vp-1t; Fri, 09 Jun 2017 15:26:01 +0300 From: Mikko Perttunen To: bskeggs@redhat.com, nouveau@lists.freedesktop.org Subject: [PATCH 2/3] drm/nouveau/tegra: Don't leave GPU in reset Date: Fri, 9 Jun 2017 15:25:40 +0300 Message-Id: <20170609122541.31118-2-mperttunen@nvidia.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170609122541.31118-1-mperttunen@nvidia.com> References: <20170609122541.31118-1-mperttunen@nvidia.com> X-SA-Exim-Connect-IP: 84.249.193.183 X-SA-Exim-Mail-From: mperttunen@nvidia.COM X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Cc: dri-devel@lists.freedesktop.org, Mikko Perttunen , kholtta@nvidia.com, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, jonathanh@nvidia.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Tegra186 systems with certain firmware revisions, leaving the GPU in reset can cause a hang. To prevent this, don't leave the GPU in reset. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c index 3d42cdbbe9c0..189ed80e21ff 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c @@ -82,9 +82,6 @@ nvkm_device_tegra_power_down(struct nvkm_device_tegra *tdev) { int ret; - reset_control_assert(tdev->rst); - udelay(10); - clk_disable_unprepare(tdev->clk_pwr); if (tdev->clk_ref) clk_disable_unprepare(tdev->clk_ref);