From patchwork Tue Jun 20 09:42:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9799093 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E9B6C60329 for ; Tue, 20 Jun 2017 09:42:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DD78526B41 for ; Tue, 20 Jun 2017 09:42:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C9CB1283AF; Tue, 20 Jun 2017 09:42:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 53E4726B41 for ; Tue, 20 Jun 2017 09:42:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 78D136E2EE; Tue, 20 Jun 2017 09:42:37 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43B6E6E2EE for ; Tue, 20 Jun 2017 09:42:36 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id d17so21900445wme.3 for ; Tue, 20 Jun 2017 02:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=whC6kTcGYDesv1AdMd5ebHuWDDDYp9mq66R1n9Ws/Gs=; b=JZQlnEyldfsmF6lPNRR5HWkZreQP7QiWkKzYRhsU7KXy0uiYaVctLM6B3lCeOTCmm1 pMUPEcwEwEwqYLny7Rjq3i1g4lBTJq4MkiUifDnrqQ1Pf5TEgRxAhtuhEQIFxSCuHX1M r9KLu2TMNUSJuk/LMdy+C+3sSr5rp7Wz45Low= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=whC6kTcGYDesv1AdMd5ebHuWDDDYp9mq66R1n9Ws/Gs=; b=dKE1TBQjv1S7NBw73dkr+DofqAzKGiLnRBIu91aiSI879yq1g+4FVkysmx/fKbW5aG xqV7BYjtvvFvbstBZzsv0zslZt5YlsjfYh7s01kdfdUTk846P4fEhbLVEkWoIovs4nRH tZ1ETO0FPC9rZpfMrqyCQh5OzmgeFZsL3R6Y+u4l0Ae/HFU8pY40IWJgtFbNN0UJUhZG 3UcSdo5HlHHgJKztvx70zZS2/nsI4xoyvAHpk6kerNH3fRJfUfZx6CII07iJlwj6bxSG mg3kpvODSv8e/xWAxUDsUzn4ajH+nXE3hY3TDdQVpmlzU6TOWUYxiyf+MuaEqT6fDTEB F5VA== X-Gm-Message-State: AKS2vOwjT8dHDJJ5HYXpeX9ubpbhCTYwTb5CLDAq/uJU4CpG4/00fSGK xmVVHr2BuYSVRaXo7pM= X-Received: by 10.80.204.218 with SMTP id b26mr20221381edj.122.1497951754735; Tue, 20 Jun 2017 02:42:34 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5640:0:960b:2678:e223:c1c6]) by smtp.gmail.com with ESMTPSA id b36sm6530031edb.41.2017.06.20.02.42.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jun 2017 02:42:34 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH] drm: More links for gamma support helpers Date: Tue, 20 Jun 2017 11:42:28 +0200 Message-Id: <20170620094228.4757-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.11.0 Cc: Daniel Vetter , Daniel Vetter , Peter Rosin X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP It's not obvious that when using the new color manager stuff you still need to wire up the legacy helper to get legacy LUT support. Improve this with more links. drm_crtc_funcs->gamma_set already explains this properly. Cc: Peter Rosin Cc: Boris Brezillon Signed-off-by: Daniel Vetter Reviewed-by: Boris Brezillon --- drivers/gpu/drm/drm_color_mgmt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c index 3eda500fc005..fe0982708e95 100644 --- a/drivers/gpu/drm/drm_color_mgmt.c +++ b/drivers/gpu/drm/drm_color_mgmt.c @@ -128,6 +128,9 @@ EXPORT_SYMBOL(drm_color_lut_extract); * optional. The gamma and degamma properties are only attached if * their size is not 0 and ctm_property is only attached if has_ctm is * true. + * + * Drivers should use drm_atomic_helper_legacy_gamma_set() to implement the + * legacy &drm_crtc_funcs.gamma_set callback. */ void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc, uint degamma_lut_size,