| Message ID | 20170623074244.6901-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jun 23, 2017 at 09:42:44AM +0200, Hans de Goede wrote: > On Bay Trail devices either the Crystal Cove PMIC's pwm or the LPSS' > pwm is used to control the backlight. Other drivers take core of > providing a backlight_pwm alias through pwm_add_table, but it is > still useful to know which pwm device actually ends up being used > for debugging backlight issues, so add a DRM_INFO logging the > pwm device-name. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/gpu/drm/i915/intel_panel.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c > index cb50c527401f..7936a64af393 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -1670,6 +1670,9 @@ static int pwm_setup_backlight(struct intel_connector *connector, > CRC_PMIC_PWM_PERIOD_NS); > panel->backlight.enabled = panel->backlight.level != 0; > > + DRM_INFO("Using %s pwm-device for backlight control\n", > + dev_name(panel->backlight.pwm->chip->dev)); Is DRM_DEBUG_KMS() not enough? > + > return 0; > } > > -- > 2.13.0
Hi, On 06/27/2017 11:52 AM, Ville Syrjälä wrote: > On Fri, Jun 23, 2017 at 09:42:44AM +0200, Hans de Goede wrote: >> On Bay Trail devices either the Crystal Cove PMIC's pwm or the LPSS' >> pwm is used to control the backlight. Other drivers take core of >> providing a backlight_pwm alias through pwm_add_table, but it is >> still useful to know which pwm device actually ends up being used >> for debugging backlight issues, so add a DRM_INFO logging the >> pwm device-name. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> drivers/gpu/drm/i915/intel_panel.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c >> index cb50c527401f..7936a64af393 100644 >> --- a/drivers/gpu/drm/i915/intel_panel.c >> +++ b/drivers/gpu/drm/i915/intel_panel.c >> @@ -1670,6 +1670,9 @@ static int pwm_setup_backlight(struct intel_connector *connector, >> CRC_PMIC_PWM_PERIOD_NS); >> panel->backlight.enabled = panel->backlight.level != 0; >> >> + DRM_INFO("Using %s pwm-device for backlight control\n", >> + dev_name(panel->backlight.pwm->chip->dev)); > > Is DRM_DEBUG_KMS() not enough? I prefer DRM_INFO so that I can just ask users with backlight issues to do a dmesg and then see which pwm controller is being used. Regards, Hans
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index cb50c527401f..7936a64af393 100644 --- a/drivers/gpu/drm/i915/intel_panel.c +++ b/drivers/gpu/drm/i915/intel_panel.c @@ -1670,6 +1670,9 @@ static int pwm_setup_backlight(struct intel_connector *connector, CRC_PMIC_PWM_PERIOD_NS); panel->backlight.enabled = panel->backlight.level != 0; + DRM_INFO("Using %s pwm-device for backlight control\n", + dev_name(panel->backlight.pwm->chip->dev)); + return 0; }
On Bay Trail devices either the Crystal Cove PMIC's pwm or the LPSS' pwm is used to control the backlight. Other drivers take core of providing a backlight_pwm alias through pwm_add_table, but it is still useful to know which pwm device actually ends up being used for debugging backlight issues, so add a DRM_INFO logging the pwm device-name. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/gpu/drm/i915/intel_panel.c | 3 +++ 1 file changed, 3 insertions(+)