| Message ID | 20170712081344.25495-12-maarten.lankhorst@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jul 12, 2017 at 10:13:39AM +0200, Maarten Lankhorst wrote: > for_each_obj_in_state is about to be removed, so use the new iterator > macros. > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Brian Starkey <brian.starkey@arm.com> > Cc: Mali DP Maintainers <malidp@foss.arm.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/arm/malidp_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > index 01b13d219917..a6a05a768dd1 100644 > --- a/drivers/gpu/drm/arm/malidp_drv.c > +++ b/drivers/gpu/drm/arm/malidp_drv.c > @@ -225,7 +225,7 @@ static void malidp_atomic_commit_tail(struct drm_atomic_state *state) > > drm_atomic_helper_commit_modeset_disables(drm, state); > > - for_each_crtc_in_state(state, crtc, old_crtc_state, i) { > + for_each_old_crtc_in_state(state, crtc, old_crtc_state, i) { > malidp_atomic_commit_update_gamma(crtc, old_crtc_state); > malidp_atomic_commit_update_coloradj(crtc, old_crtc_state); > malidp_atomic_commit_se_config(crtc, old_crtc_state); > -- > 2.11.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Wed, Jul 12, 2017 at 10:13:39AM +0200, Maarten Lankhorst wrote: > for_each_obj_in_state is about to be removed, so use the new iterator > macros. > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Brian Starkey <brian.starkey@arm.com> > Cc: Mali DP Maintainers <malidp@foss.arm.com> Hi Maarten, Acked-by: Liviu Dudau <liviu.dudau@arm.com> Are you going to take the whole series through drm-misc or you want me to pull this patch into mali-dp tree? Best regards, Liviu > --- > drivers/gpu/drm/arm/malidp_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > index 01b13d219917..a6a05a768dd1 100644 > --- a/drivers/gpu/drm/arm/malidp_drv.c > +++ b/drivers/gpu/drm/arm/malidp_drv.c > @@ -225,7 +225,7 @@ static void malidp_atomic_commit_tail(struct drm_atomic_state *state) > > drm_atomic_helper_commit_modeset_disables(drm, state); > > - for_each_crtc_in_state(state, crtc, old_crtc_state, i) { > + for_each_old_crtc_in_state(state, crtc, old_crtc_state, i) { > malidp_atomic_commit_update_gamma(crtc, old_crtc_state); > malidp_atomic_commit_update_coloradj(crtc, old_crtc_state); > malidp_atomic_commit_se_config(crtc, old_crtc_state); > -- > 2.11.0 >
Op 12-07-17 om 11:44 schreef Liviu Dudau: > On Wed, Jul 12, 2017 at 10:13:39AM +0200, Maarten Lankhorst wrote: >> for_each_obj_in_state is about to be removed, so use the new iterator >> macros. >> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> Cc: Liviu Dudau <liviu.dudau@arm.com> >> Cc: Brian Starkey <brian.starkey@arm.com> >> Cc: Mali DP Maintainers <malidp@foss.arm.com> > Hi Maarten, > > Acked-by: Liviu Dudau <liviu.dudau@arm.com> > > Are you going to take the whole series through drm-misc or you want me > to pull this patch into mali-dp tree? I'm planning to put it all through drm-misc if possible, so I can immediately remove the old macros so they will never be used again. :)
On Wed, Jul 12, 2017 at 12:00:40PM +0200, Maarten Lankhorst wrote: > Op 12-07-17 om 11:44 schreef Liviu Dudau: > > On Wed, Jul 12, 2017 at 10:13:39AM +0200, Maarten Lankhorst wrote: > >> for_each_obj_in_state is about to be removed, so use the new iterator > >> macros. > >> > >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > >> Cc: Liviu Dudau <liviu.dudau@arm.com> > >> Cc: Brian Starkey <brian.starkey@arm.com> > >> Cc: Mali DP Maintainers <malidp@foss.arm.com> > > Hi Maarten, > > > > Acked-by: Liviu Dudau <liviu.dudau@arm.com> > > > > Are you going to take the whole series through drm-misc or you want me > > to pull this patch into mali-dp tree? > > I'm planning to put it all through drm-misc if possible, so I can immediately > remove the old macros so they will never be used again. :) Fine by me. Thanks for the patch! Best regards, Liviu > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index 01b13d219917..a6a05a768dd1 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -225,7 +225,7 @@ static void malidp_atomic_commit_tail(struct drm_atomic_state *state) drm_atomic_helper_commit_modeset_disables(drm, state); - for_each_crtc_in_state(state, crtc, old_crtc_state, i) { + for_each_old_crtc_in_state(state, crtc, old_crtc_state, i) { malidp_atomic_commit_update_gamma(crtc, old_crtc_state); malidp_atomic_commit_update_coloradj(crtc, old_crtc_state); malidp_atomic_commit_se_config(crtc, old_crtc_state);
for_each_obj_in_state is about to be removed, so use the new iterator macros. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Brian Starkey <brian.starkey@arm.com> Cc: Mali DP Maintainers <malidp@foss.arm.com> --- drivers/gpu/drm/arm/malidp_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)