From patchwork Mon Jul 17 15:10:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9845445 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 885E560386 for ; Mon, 17 Jul 2017 15:10:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7BCFB28429 for ; Mon, 17 Jul 2017 15:10:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 708EA284E3; Mon, 17 Jul 2017 15:10:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C749228429 for ; Mon, 17 Jul 2017 15:10:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A1016E22B; Mon, 17 Jul 2017 15:10:57 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF0F889E3B for ; Mon, 17 Jul 2017 15:10:55 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id u23so23662091wma.2 for ; Mon, 17 Jul 2017 08:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=XVaYSK2mR9ayBGNfqsZqsU4jZssDncVCMgkMu10nUsI=; b=Eh+VjgBFyYJMl9H88+tNPXNG2M2uDCjkkUBwluJrOBufaYMcLe32490gZqju9pQ2KK WCbXwIfKNIeLlZ/ZUpAbzKq1fSO/d+arW2ihMLHkDdPTJc8pHBNYazA2wK13qPY4+1nn Xz1hDvwoaWtYICHKkO6OPZHuOwDed1oBHqR28= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XVaYSK2mR9ayBGNfqsZqsU4jZssDncVCMgkMu10nUsI=; b=Hepo8vO4w4cx41EeRHnhjz+J7SnjhM5MaJW4wd4Jkj8Q10goX7IjYr4k0DMMU5Y/S0 k9cTJXnzKMkuBqb8KEJDcHGTcH5OtLbYD6D8G4mJdDB3LeGL+UsVu/oIhoGf/M6PJ/xQ ppD/gDHBzukCJxNXM4z1+Ur585WvXygC91FEXf6BVdw2NHxIOf9xXdmFPzm1roLk38vM ZO6bch6eTfj/x7AzOlqwGBlS5YnwX/kMrL0y8H7zZ+/svJEK5dRUuUscVUEpOUpFc6DZ GMmL7W8XBP+ZoxvuHQ9Zsv9DlXTLWLR9FL4pd073LAYlDLNQm29WXNhcBCCJCluT2MOI GEVg== X-Gm-Message-State: AIVw112Fri7eVixo+RZOQwX/3ZCxGkRcaX8J6/HSB29mnhtBwVOnH+3m F8VceuvKPui0/a6auuY= X-Received: by 10.80.175.198 with SMTP id h64mr17974363edd.131.1500304254235; Mon, 17 Jul 2017 08:10:54 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5640:0:960b:2678:e223:c1c6]) by smtp.gmail.com with ESMTPSA id b22sm9065938edb.9.2017.07.17.08.10.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jul 2017 08:10:53 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 1/3] drm/mxsfb: Use gem_free_object_unlocked Date: Mon, 17 Jul 2017 17:10:43 +0200 Message-Id: <20170717151045.4188-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.13.2 Cc: Marek Vasut , Daniel Vetter , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP CMA helpers are struct_mutex free, and so is the mxsfb itself. And that's the only valid reason for using gem_free_object. Please read the kerneldoc for this stuff :-) Signed-off-by: Daniel Vetter Cc: Marek Vasut Reviewed-by: Eric Anholt --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index 1853557fef46..a34f41ce3599 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -334,7 +334,7 @@ static struct drm_driver mxsfb_driver = { .irq_uninstall = mxsfb_irq_preinstall, .enable_vblank = mxsfb_enable_vblank, .disable_vblank = mxsfb_disable_vblank, - .gem_free_object = drm_gem_cma_free_object, + .gem_free_object_unlocked = drm_gem_cma_free_object, .gem_vm_ops = &drm_gem_cma_vm_ops, .dumb_create = drm_gem_cma_dumb_create, .dumb_map_offset = drm_gem_cma_dumb_map_offset,