From patchwork Thu Jul 27 12:47:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Gusakov X-Patchwork-Id: 9866737 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 10C55603F9 for ; Thu, 27 Jul 2017 12:46:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 03C8228815 for ; Thu, 27 Jul 2017 12:46:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ECE0D2881A; Thu, 27 Jul 2017 12:46:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A853228815 for ; Thu, 27 Jul 2017 12:46:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9BA5A6ECE1; Thu, 27 Jul 2017 12:46:27 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf0-x232.google.com (mail-lf0-x232.google.com [IPv6:2a00:1450:4010:c07::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD05E6ECDB for ; Thu, 27 Jul 2017 12:46:17 +0000 (UTC) Received: by mail-lf0-x232.google.com with SMTP id g25so75909573lfh.1 for ; Thu, 27 Jul 2017 05:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yP92PDMHgFgvhpuHMA6eap0CobidIt4T1jeAQ2FbyAg=; b=qGSw76FWnlRxo/rQnitpVbF3CpLe7XrZKwPWEsAeTbnlrbDnl1kwP1Jc+s/19hOmwi ZAjLm/uFYqZI1lfjE42bZ9FChcNDNTCqQQWmkcTG7oBWuq+Ypdp7Xi8IS+fUea5MMzN5 bUjl2x4YNWz8PQFqS2bcSu05CImgbJS4ZNzAlKzSHYNf7mQ/w1GPC/BwzgA3Im8pmTDh HGFiUpCcJCtT+piRCQreKpdz91GbMbyUCv+baYch8DjAyvIl+3WCdoZsasg2l/hSgZSr X8U/1nSVqHEQTdX0NYq2UI5i52sC0Iga7pN0A7p2dp7NY5N2cqd+rMXANVEiK2Te16XZ IGEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yP92PDMHgFgvhpuHMA6eap0CobidIt4T1jeAQ2FbyAg=; b=cw22q6DvnC4ly+dcAjt0kifnHkTINN+h0dYdNAfR5pM488EeLp24K+LHmHM5j4P9dO 43djro9kpPKCPpUEsrGlhO+3ljZ/DEKbSEKb42xOBFpKb6pfoxtAgWEmDurSJLIrGgM3 r+bbtzG6b0dHfzUswzFPZaTyn5bwko4J/kYqeEoHjE+tSXj8e0uqm4lQ3MTXkL8fLbOz 9N22bdFU28ddJrpfkD+JggAw87gqawiIlAgSW6OGR2pp30fXh2Adl2euJFsckxwr8Np3 GNPrSuSWzI3M0E7pTxhzvmOA9+xWMRggpLS31H7pdaNpiy0BULxQOUgdLZp0zh17miDA YO5Q== X-Gm-Message-State: AIVw112el/iaWholYeGPGmxskpG83sCRAiIOdXf42SQdz3uVIdd29zGP kVp655P73jCUQjk4r4ye3Q== X-Received: by 10.46.78.2 with SMTP id c2mr789007ljb.149.1501159576070; Thu, 27 Jul 2017 05:46:16 -0700 (PDT) Received: from localhost.localdomain (178-16-155-142.obit.ru. [178.16.155.142]) by smtp.gmail.com with ESMTPSA id y10sm3889518lja.49.2017.07.27.05.46.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jul 2017 05:46:15 -0700 (PDT) From: Andrey Gusakov To: dri-devel@lists.freedesktop.org Subject: [PATCH 5/6] drm/bridge: tc358767: fix AUXDATAn registers access Date: Thu, 27 Jul 2017 15:47:35 +0300 Message-Id: <20170727124736.3854-6-andrey.gusakov@cogentembedded.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170727124736.3854-1-andrey.gusakov@cogentembedded.com> References: <20170727124736.3854-1-andrey.gusakov@cogentembedded.com> Cc: Andrey Gusakov , cphealy@gmail.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP First four bytes should go to DP0_AUXWDATA0. Due to bug if len > 4 first four bytes was writen to DP0_AUXWDATA1 and all data get shifted by 4 bytes. Fix it. Signed-off-by: Andrey Gusakov Acked-by: Philipp Zabel --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index c657a00af508..84b0b0fff854 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -318,7 +318,7 @@ static ssize_t tc_aux_transfer(struct drm_dp_aux *aux, tmp = (tmp << 8) | buf[i]; i++; if (((i % 4) == 0) || (i == size)) { - tc_write(DP0_AUXWDATA(i >> 2), tmp); + tc_write(DP0_AUXWDATA((i - 1) >> 2), tmp); tmp = 0; } }