From patchwork Fri Aug 4 10:45:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Rosin X-Patchwork-Id: 9882875 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2C1296031B for ; Sat, 5 Aug 2017 02:22:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 159C9286D9 for ; Sat, 5 Aug 2017 02:22:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0A2FE286F6; Sat, 5 Aug 2017 02:22:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8E527286D9 for ; Sat, 5 Aug 2017 02:22:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23C786E437; Sat, 5 Aug 2017 02:21:22 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0090.outbound.protection.outlook.com [104.47.1.90]) by gabe.freedesktop.org (Postfix) with ESMTPS id 697556E3E6 for ; Fri, 4 Aug 2017 12:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axentiatech.onmicrosoft.com; s=selector1-axentia-se; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Wgjac+2gt1P18pEJiM7G0tStpzvNL8zxQYzkttiq1Ag=; b=CSNzXHylkBBI70E7os5Zn6F7HjBZg9Wtr1nE61cke4H6YzUcfILdW3B/ftOrHxGrfRh5so+8A/rvL8IqWISakdV6Hx2XmO9aWE8LrhAbtsrHhfyVC2Bjp6xG3szdsn18E8vyZusUtewo42Oopvy/eSKG61jDZ4/wOuRzAL1eWQg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Received: from orc.pedanet (81.224.168.30) by VI1PR0202MB2560.eurprd02.prod.outlook.com (2603:10a6:801:6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1304.22; Fri, 4 Aug 2017 10:45:19 +0000 From: Peter Rosin To: Daniel Vetter Subject: [RESEND PATCH] staging: vboxvideo: remove dead gamma lut code Date: Fri, 4 Aug 2017 12:45:06 +0200 Message-Id: <20170804104506.2414-1-peda@axentia.se> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170804103034.2342-1-peda@axentia.se> References: <20170804103034.2342-1-peda@axentia.se> MIME-Version: 1.0 X-Originating-IP: [81.224.168.30] X-ClientProxiedBy: AM3PR03CA0068.eurprd03.prod.outlook.com (2603:10a6:207:5::26) To VI1PR0202MB2560.eurprd02.prod.outlook.com (2603:10a6:801:6::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2444112e-73bb-43a1-41b1-08d4db25e77d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(2017082002075)(300000503095)(300135400095)(201703131423075)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR0202MB2560; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0202MB2560; 3:mKaiv3obPGkrZOjy8PQasQeMXNuODjplwM+/xNEFlkV2oUoDwtbjUra9PAhqtB6w8ahniIyD3NU9S4xvO8O3VQArN6fbHb6pakk5mYLjSnSqebUc9nH1QlVFG5H6ZLgvJ+h5mh3oZ6WTLulyAbc1ITqfaaLWRTjPpRXRaRajEmrmQwl0oOUc2KcuHCJ8E+9JlH1m+R241RikwVHpiDSKQGS0lUd+Rlt8gO3ObIR5k38Yjfw/JBuLUhPH3y8p2rJd; 25:g193pi4EB+lSWFg2+wL9ZUQ2zbDby+WgKWiod8Kwp0I66xtAV5SRtDjrjd5rm+P7JNxSArfUdjDSovVSIlzbPyCtuXI4mjRUEcO1H/eFIJgdSKr9jtHPYs+qEIkNgxU8rmakyF7kUa5kIly58lJExfvgctfMRLQ/wMLfN6FETFLnTqlVog5nV0Xy32KYq/L4TAqWEhcSwfBrZzEolQET+AayD6WZm67bXk2XN4OhniypOdxnrc1b+BFZuNHpjcmOcw8hogftmLyTlvENHzXjDzQaFABTVh5dFnNQAG34l/tBCZA5nAXgjqFfHxbpkfPltMUEKGdQsVTaWxaG+HMz5w==; 31:BnOQTnA58LiKJCODK10y10qMKCNs6k3Qm0HCcLyWcOu8XbN1eEDvLzwXSexCEkpt2BueWdSpepKHUPQmG3A+GqX+u/kpo5yQS3Vi+nvq/I4kHDNEAfPc49uDhZ1LZrhS/uhCxhnxvg6IUKxBq9zoAS6lscqgzilM5vw60vfdKXGSR9WxtoQMZjCQ8BBEv4ay0FuFCBb90WFv9zCiKwMzQ0JKtJJzdAjdks+9G0nrmUU= X-MS-TrafficTypeDiagnostic: VI1PR0202MB2560: X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123564025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(2016111802025)(20161123562025)(6072148)(6043046)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR0202MB2560; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR0202MB2560; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0202MB2560; 4:l8Sin1MNaM4E9HPPEwqxstgdCi4f6sW8IUGWpmcxSTincRhsq6huc33WZJFGzvRuJJUih6y8eDKWYE8bINwMf0NLS9+tKEsk0QfM5+/QrSjqD1gs1DOlZ5kZc0SctImkFuZzVh6qdGKAYwMcjyyxUHD7M47ubaMigtE2ORcDu+aNBk+FyaApxcJUNgvM7DaWxal+StSG0proj6BmTcPI4Fj8egKABg3MbjEQ3QP7zKYmNfgY9TAFnhpLwiyotb3A X-Forefront-PRVS: 0389EDA07F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(7370300001)(6009001)(39400400002)(39410400002)(39450400003)(39830400002)(189002)(199003)(6306002)(25786009)(36756003)(110136004)(38730400002)(86362001)(478600001)(68736007)(33646002)(97736004)(101416001)(81156014)(81166006)(8676002)(966005)(2906002)(66066001)(105586002)(50226002)(47776003)(189998001)(42186005)(106356001)(50466002)(305945005)(7350300001)(7736002)(2950100002)(74482002)(6512007)(6916009)(54906002)(50986999)(6116002)(6486002)(6666003)(48376002)(53936002)(6506006)(76176999)(3846002)(5003940100001)(5660300001)(4326008)(1076002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR0202MB2560; H:orc.pedanet; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: axentia.se does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0202MB2560; 23:5GYnSABISXyix403+LIXBCog0vccGmQ4tRIifyM?= =?us-ascii?Q?WkpkXl8QG8t3bSGMio9ofnNQaEIWIQebzW2nNAh5qmbS5goYIP7PilCcmumV?= =?us-ascii?Q?MafDKvJtVsBtdcvRKLUufXrHkKb7OrUYoNY6KMfq//YNViKxcjt0DC6AGR+0?= =?us-ascii?Q?y9qtEoaz22REWZj/wGoTOBbxsCsCyiqnunvfk9imkr2r84A3ifr60gbAmL8u?= =?us-ascii?Q?D0bNl0swU5fkp4IWlZ2Fq25gN4wiabt4roOpqPYtJT5wvLtXKGNi4rsr35Bo?= =?us-ascii?Q?sTIVcPpwZtJhGrihhjBjROBrma5KDLddpluxc2qhbSfJ3d9r3abMTuQLUwWl?= =?us-ascii?Q?yLnpQXCQlZpavXy2L7EEzG0C9TDeWor4JrizGJPMY9poznqZ2ZQgrWD8LO77?= =?us-ascii?Q?6ya/JIbucbzK/6I5Q/IMw0fu3XaIOLZtOz9nKaTISt8DICl29GOHRMFnh60H?= =?us-ascii?Q?aTBNBmlph/xMhRFP9MbGpy3zJ+l2G3mhELAbcW+xwOIjkGQitiHHwm3APIk/?= =?us-ascii?Q?AK5YIRbvNiI2RKI7ge14kNitiF8UvqdV0PNHP6ZO2Pm6Wo3v27udNlnUr54U?= =?us-ascii?Q?HD5ccME1OK2xYwjbBME+shXa0mYkg8NgdD0YZK1BzF2JfylVnWQaVaB8u+N+?= =?us-ascii?Q?czal0lFTjhES1WT1JJNw150Cc6IJoO64UhVbdnluXlGTCMxLJ+/NlbklG/fG?= =?us-ascii?Q?xZYjyBxyE1DMJuxJ2Wm4VPesSWPnfq3iaF0QK94VxkfKZR9CmS+FVYkQokmz?= =?us-ascii?Q?37WDEQ+jMWFo+nkVA+WIoO4EWGVStrQpxSx1ivprID79ksSpY7Q8r6IakYdk?= =?us-ascii?Q?HDiVE79DOKD1UcFY1LO0oDq24aheDzaE+fXOVQwK3hCocF5KLvVNr6S+9/cF?= =?us-ascii?Q?B9v3L+bN3A5xzX6Vkb6yr26xlJCEaX+jv28nyOkY4Ymmzq2Ag2iYptuewDBw?= =?us-ascii?Q?Bzyi3PVJPsOH+vF6hE7Ngph7hs7MzEkxgiclRnv7S5AWmRNuvApgsUNbYTuM?= =?us-ascii?Q?rhS1Bc6EWT8A4SMlhCLeLdTYwpHg8vUhhkqxZrA71kOeWqccf62BNNXogh0P?= =?us-ascii?Q?am5Qm3jeHpkNneco1rcoMwG+52IXJhCYpV7BncuwISmzFTqoAtMVYMUvgXKp?= =?us-ascii?Q?M+IstUZCNmj1vFo996PReDEvzwzth6b6vJ70Eq6tgkDytQsr0s+g3eZfbQX2?= =?us-ascii?Q?pP09dNw/gPATC3vLii+863eX7ieEUd0lcQSpSHkYb4T17QdoXngdzjrwmt1T?= =?us-ascii?Q?aIvL+zzEwoVGOKGJow7gjDJvOTx8X3ex7X286epRD5ufJwovW018y2LRGvcx?= =?us-ascii?Q?bDgd4KXNKIzuDNDpUQCy4sGh3GmqF/iYXX1cKaVAIDWeH?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0202MB2560; 6:nvij0O1XX0SYxCN0wl07eNva3EDVxgs99ma9Gg/vseQL/CPgBRBbPnUCDJPnCwFXBpI1tTBkOdg6YKwAvRvB1V9biUp+cmMEp0kcg2ObzLF2sgtSzyE7HP0P70QG6n3RYpLnD+W1usBEsqMaaZUSX4T21QqD3kPfDT4EXEeJ0VfEm+J/7I5PXavhrVUsWPdbYdpcoxQqugC/4gRnq641dYFZKqx6vB3IYWJ9BR88jk5eFQwTn6O5ThfBxxRQlrdTPoYcX/iKO6vpZeLS5rWGwIcmUT3116Q4tCaGVaFyWeN5Y2KoVK8MkPXRyXvdCZ+EuCpPt9wwvTAHVvw4P594iA==; 5:NcmSTkUIRMz8fY/3XSYgAiXbxMCXxvAzVqySF7/HO5ZZcWX1/4xbfaA5/oMIvzJ+UB8TpJbXUKdq31vDpAEbv10mh83FF0Zvr+oICusEATmMKZwtaUZgFlNYpG9uRi/HsgguIk88a6EtImgkgfqQVQ==; 24:3k9KDL8fdSmzfqGUODuKyJbAzerxG99FJEbHGfNTzu3ONLW5DQ1BXDGBqOQrhLCVe800/BUWGlT/GnihcXHhpQ1mERS1l3cl9MB8HyhPdsw=; 7:2aznvYCiEJRqzRug74RWWmMAT/5yaizIMX0hv7jtXxTIKezjklgjoEDRpXJYJ3YZeOfzg5GnssZdLgKyheO7ARSO+U2Zm+RY8tNDMmyF2UsM1xHgLEx83557/XOiejr5Mnd1RKZNvHgQuYe11H9HF9lhEm4ET6+oyZGA2PzDuSL7f9xELwdPs/9baIRddDiMz7pqGw6eNj5hZluPyhc2ptXtUKDIa1vIYvaUF3y159o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2017 10:45:19.9476 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2560 X-Mailman-Approved-At: Sat, 05 Aug 2017 02:21:09 +0000 Cc: devel@driverdev.osuosl.org, Boris Brezillon , vbox-dev@virtualbox.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hans de Goede , Michael Thayer , Peter Rosin X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code that was not doing anything sensible anyway. Signed-off-by: Peter Rosin Acked-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_fb.c | 15 --------------- drivers/staging/vboxvideo/vbox_mode.c | 5 ----- 2 files changed, 20 deletions(-) [This time with an improved Cc list, sorry for the noise. For new people, please refer to https://lkml.org/lkml/2017/7/13/593 for context] Hi Daniel, Here it goes, but do you really need me to resend v5 14/14? Cheers, peda diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c index 35f6d9f8c203..bf6635826159 100644 --- a/drivers/staging/vboxvideo/vbox_fb.c +++ b/drivers/staging/vboxvideo/vbox_fb.c @@ -317,22 +317,7 @@ static int vboxfb_create(struct drm_fb_helper *helper, return 0; } -static void vbox_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green, - u16 blue, int regno) -{ -} - -static void vbox_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green, - u16 *blue, int regno) -{ - *red = regno; - *green = regno; - *blue = regno; -} - static struct drm_fb_helper_funcs vbox_fb_helper_funcs = { - .gamma_set = vbox_fb_gamma_set, - .gamma_get = vbox_fb_gamma_get, .fb_probe = vboxfb_create, }; diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c index f2b85f3256fa..996da1c79158 100644 --- a/drivers/staging/vboxvideo/vbox_mode.c +++ b/drivers/staging/vboxvideo/vbox_mode.c @@ -134,10 +134,6 @@ static int vbox_set_view(struct drm_crtc *crtc) return 0; } -static void vbox_crtc_load_lut(struct drm_crtc *crtc) -{ -} - static void vbox_crtc_dpms(struct drm_crtc *crtc, int mode) { struct vbox_crtc *vbox_crtc = to_vbox_crtc(crtc); @@ -330,7 +326,6 @@ static const struct drm_crtc_helper_funcs vbox_crtc_helper_funcs = { .mode_set = vbox_crtc_mode_set, /* .mode_set_base = vbox_crtc_mode_set_base, */ .disable = vbox_crtc_disable, - .load_lut = vbox_crtc_load_lut, .prepare = vbox_crtc_prepare, .commit = vbox_crtc_commit, };