| Message ID | 20170829073218.11097-4-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Peter, Thank you for the patch. On Tuesday, 29 August 2017 10:32:14 EEST Peter Ujfalusi wrote: > Instead of reaching back to DSS to iterate through the dss_devices every > time, use an internal array where we store the available and usable > dss_devices. > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 95 +++++++++++++++++++++-------------- > drivers/gpu/drm/omapdrm/omap_drv.h | 3 ++ > 2 files changed, 62 insertions(+), 36 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c > b/drivers/gpu/drm/omapdrm/omap_drv.c index bd7fe317a365..b089604e871c > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.c > +++ b/drivers/gpu/drm/omapdrm/omap_drv.c > @@ -146,18 +146,27 @@ static int get_connector_type(struct omap_dss_device > *dssdev) } > } > > -static void omap_disconnect_dssdevs(void) > +static void omap_disconnect_dssdevs(struct drm_device *ddev) > { > - struct omap_dss_device *dssdev = NULL; > + struct omap_drm_private *priv = ddev->dev_private; > + int i; > + > + for (i = 0; i < priv->num_dssdevs; i++) { is is never negative, you can make it an unsigned int. This comment applies through the whole patch. > + struct omap_dss_device *dssdev = priv->dssdevs[i]; > > - for_each_dss_dev(dssdev) > dssdev->driver->disconnect(dssdev); > + priv->dssdevs[i] = NULL; > + omap_dss_put_device(dssdev); > + } > + > + priv->num_dssdevs = 0; > } > > -static int omap_connect_dssdevs(void) > +static int omap_connect_dssdevs(struct drm_device *ddev) > { > - int r; > + struct omap_drm_private *priv = ddev->dev_private; > struct omap_dss_device *dssdev = NULL; > + int r; > > if (!omapdss_stack_is_ready()) > return -EPROBE_DEFER; > @@ -170,6 +179,14 @@ static int omap_connect_dssdevs(void) > } else if (r) { > dev_warn(dssdev->dev, "could not connect display: %s\n", > dssdev->name); > + } else { > + omap_dss_get_device(dssdev); > + priv->dssdevs[priv->num_dssdevs++] = dssdev; > + if (priv->num_dssdevs == ARRAY_SIZE(priv->dssdevs)) { > + /* To balance the 'for_each_dss_dev' loop */ > + omap_dss_put_device(dssdev); > + break; > + } > } > } > > @@ -180,7 +197,7 @@ static int omap_connect_dssdevs(void) > * if we are deferring probe, we disconnect the devices we previously > * connected > */ > - omap_disconnect_dssdevs(); > + omap_disconnect_dssdevs(ddev); > > return r; > } > @@ -205,7 +222,7 @@ static int omap_modeset_init(struct drm_device *dev) > int num_ovls = priv->dispc_ops->get_num_ovls(); > int num_mgrs = priv->dispc_ops->get_num_mgrs(); > int num_crtcs, crtc_idx, plane_idx; > - int ret; > + int ret, i; > u32 plane_crtc_mask; > > drm_mode_config_init(dev); > @@ -222,11 +239,7 @@ static int omap_modeset_init(struct drm_device *dev) > * configuration does not match the expectations or exceeds > * the available resources, the configuration is rejected. > */ > - num_crtcs = 0; > - for_each_dss_dev(dssdev) > - if (omapdss_device_is_connected(dssdev)) > - num_crtcs++; > - > + num_crtcs = priv->num_dssdevs; > if (num_crtcs > num_mgrs || num_crtcs > num_ovls || > num_crtcs > ARRAY_SIZE(priv->crtcs) || > num_crtcs > ARRAY_SIZE(priv->planes) || > @@ -244,15 +257,13 @@ static int omap_modeset_init(struct drm_device *dev) > > crtc_idx = 0; > plane_idx = 0; > - for_each_dss_dev(dssdev) { > + for (i = 0; i < priv->num_dssdevs; i++) { > + struct omap_dss_device *dssdev = priv->dssdevs[i]; > struct drm_connector *connector; > struct drm_encoder *encoder; > struct drm_plane *plane; > struct drm_crtc *crtc; > > - if (!omapdss_device_is_connected(dssdev)) > - continue; > - I believe this hunk is correct as dss devices are only disconnected by calls to the oma_dss_driver .disconnect() operation, which is only called from omap_disconnect_dssdevs(), but you should at the very least explain why in the commit message. > encoder = omap_encoder_init(dev, dssdev); > if (!encoder) > return -ENOMEM; > @@ -326,11 +337,14 @@ static int omap_modeset_init(struct drm_device *dev) > /* > * Enable the HPD in external components if supported > */ > -static void omap_modeset_enable_external_hpd(void) > +static void omap_modeset_enable_external_hpd(struct drm_device *ddev) > { > - struct omap_dss_device *dssdev = NULL; > + struct omap_drm_private *priv = ddev->dev_private; > + int i; > + > + for (i = 0; i < priv->num_dssdevs; i++) { > + struct omap_dss_device *dssdev = priv->dssdevs[i]; > > - for_each_dss_dev(dssdev) { > if (dssdev->driver->enable_hpd) > dssdev->driver->enable_hpd(dssdev); > } > @@ -339,11 +353,14 @@ static void omap_modeset_enable_external_hpd(void) > /* > * Disable the HPD in external components if supported > */ > -static void omap_modeset_disable_external_hpd(void) > +static void omap_modeset_disable_external_hpd(struct drm_device *ddev) > { > - struct omap_dss_device *dssdev = NULL; > + struct omap_drm_private *priv = ddev->dev_private; > + int i; > + > + for (i = 0; i < priv->num_dssdevs; i++) { > + struct omap_dss_device *dssdev = priv->dssdevs[i]; > > - for_each_dss_dev(dssdev) { > if (dssdev->driver->disable_hpd) > dssdev->driver->disable_hpd(dssdev); > } > @@ -562,7 +579,7 @@ static int pdev_probe(struct platform_device *pdev) > > omap_crtc_pre_init(); > > - ret = omap_connect_dssdevs(); > + ret = omap_connect_dssdevs(ddev); > if (ret) > goto err_crtc_uninit; > > @@ -597,7 +614,7 @@ static int pdev_probe(struct platform_device *pdev) > priv->fbdev = omap_fbdev_init(ddev); > > drm_kms_helper_poll_init(ddev); > - omap_modeset_enable_external_hpd(); > + omap_modeset_enable_external_hpd(ddev); > > /* > * Register the DRM device with the core and the connectors with > @@ -610,7 +627,7 @@ static int pdev_probe(struct platform_device *pdev) > return 0; > > err_cleanup_helpers: > - omap_modeset_disable_external_hpd(); > + omap_modeset_disable_external_hpd(ddev); > drm_kms_helper_poll_fini(ddev); > if (priv->fbdev) > omap_fbdev_free(ddev); > @@ -620,7 +637,7 @@ static int pdev_probe(struct platform_device *pdev) > err_gem_deinit: > omap_gem_deinit(ddev); > destroy_workqueue(priv->wq); > - omap_disconnect_dssdevs(); > + omap_disconnect_dssdevs(ddev); > err_crtc_uninit: > omap_crtc_pre_uninit(); > drm_dev_unref(ddev); > @@ -636,7 +653,7 @@ static int pdev_remove(struct platform_device *pdev) > > drm_dev_unregister(ddev); > > - omap_modeset_disable_external_hpd(); > + omap_modeset_disable_external_hpd(ddev); > drm_kms_helper_poll_fini(ddev); > > if (priv->fbdev) > @@ -651,7 +668,7 @@ static int pdev_remove(struct platform_device *pdev) > > destroy_workqueue(priv->wq); > > - omap_disconnect_dssdevs(); > + omap_disconnect_dssdevs(ddev); > omap_crtc_pre_uninit(); > > drm_dev_unref(ddev); > @@ -660,11 +677,14 @@ static int pdev_remove(struct platform_device *pdev) > } > > #ifdef CONFIG_PM_SLEEP > -static int omap_drm_suspend_all_displays(void) > +static int omap_drm_suspend_all_displays(struct drm_device *ddev) > { > - struct omap_dss_device *dssdev = NULL; > + struct omap_drm_private *priv = ddev->dev_private; > + int i; > + > + for (i = 0; i < priv->num_dssdevs; i++) { > + struct omap_dss_device *dssdev = priv->dssdevs[i]; > > - for_each_dss_dev(dssdev) { > if (!dssdev->driver) > continue; > > @@ -679,11 +699,14 @@ static int omap_drm_suspend_all_displays(void) > return 0; > } > > -static int omap_drm_resume_all_displays(void) > +static int omap_drm_resume_all_displays(struct drm_device *ddev) > { > - struct omap_dss_device *dssdev = NULL; > + struct omap_drm_private *priv = ddev->dev_private; > + int i; > + > + for (i = 0; i < priv->num_dssdevs; i++) { > + struct omap_dss_device *dssdev = priv->dssdevs[i]; > > - for_each_dss_dev(dssdev) { > if (!dssdev->driver) > continue; > > @@ -703,7 +726,7 @@ static int omap_drm_suspend(struct device *dev) > drm_kms_helper_poll_disable(drm_dev); > > drm_modeset_lock_all(drm_dev); > - omap_drm_suspend_all_displays(); > + omap_drm_suspend_all_displays(drm_dev); > drm_modeset_unlock_all(drm_dev); > > return 0; > @@ -714,7 +737,7 @@ static int omap_drm_resume(struct device *dev) > struct drm_device *drm_dev = dev_get_drvdata(dev); > > drm_modeset_lock_all(drm_dev); > - omap_drm_resume_all_displays(); > + omap_drm_resume_all_displays(drm_dev); > drm_modeset_unlock_all(drm_dev); > > drm_kms_helper_poll_enable(drm_dev); > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h > b/drivers/gpu/drm/omapdrm/omap_drv.h index 4bd1e9070b31..cccaae787a7c > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.h > +++ b/drivers/gpu/drm/omapdrm/omap_drv.h > @@ -51,6 +51,9 @@ struct omap_drm_private { > > const struct dispc_ops *dispc_ops; > > + unsigned int num_dssdevs; > + struct omap_dss_device *dssdevs[8]; > + > unsigned int num_crtcs; > struct drm_crtc *crtcs[8];
Hi Laurent, Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 2017-09-01 14:27, Laurent Pinchart wrote: >> -static void omap_disconnect_dssdevs(void) >> +static void omap_disconnect_dssdevs(struct drm_device *ddev) >> { >> - struct omap_dss_device *dssdev = NULL; >> + struct omap_drm_private *priv = ddev->dev_private; >> + int i; >> + >> + for (i = 0; i < priv->num_dssdevs; i++) { > > is is never negative, you can make it an unsigned int. This comment applies > through the whole patch. True, are there any benefits to have unsigned int compared to int? I don't think we are going to hit size limitation with the int, but if you prefer to have unsigned int, then sure, I can change the num_displays and 'i's to unsigned. >> crtc_idx = 0; >> plane_idx = 0; >> - for_each_dss_dev(dssdev) { >> + for (i = 0; i < priv->num_dssdevs; i++) { >> + struct omap_dss_device *dssdev = priv->dssdevs[i]; >> struct drm_connector *connector; >> struct drm_encoder *encoder; >> struct drm_plane *plane; >> struct drm_crtc *crtc; >> >> - if (!omapdss_device_is_connected(dssdev)) >> - continue; >> - > > I believe this hunk is correct as dss devices are only disconnected by calls > to the oma_dss_driver .disconnect() operation, which is only called from > omap_disconnect_dssdevs(), but you should at the very least explain why in the > commit message. The check became irrelevant as we did not add dssdevs to the array if their connect failed and as you have said we only disconnect ddsdevs in omap_disconnect_dssdevs() - in cleanup paths. I will update the commit message with this information. - Péter
Hi Peter, On Monday, 4 September 2017 12:19:19 EEST Peter Ujfalusi wrote: > On 2017-09-01 14:27, Laurent Pinchart wrote: > >> -static void omap_disconnect_dssdevs(void) > >> +static void omap_disconnect_dssdevs(struct drm_device *ddev) > >> { > >> - struct omap_dss_device *dssdev = NULL; > >> + struct omap_drm_private *priv = ddev->dev_private; > >> + int i; > >> + > >> + for (i = 0; i < priv->num_dssdevs; i++) { > > > > is is never negative, you can make it an unsigned int. This comment > > applies through the whole patch. > > True, are there any benefits to have unsigned int compared to int? I > don't think we are going to hit size limitation with the int, but if you > prefer to have unsigned int, then sure, I can change the num_displays > and 'i's to unsigned. Making it explicit that the variable can't be negative allows the compiler to warn when encoutering a < 0 test. It also makes the code self-documented, showing the reader that the variable isn't expected to become negative. > >> crtc_idx = 0; > >> plane_idx = 0; > >> > >> - for_each_dss_dev(dssdev) { > >> + for (i = 0; i < priv->num_dssdevs; i++) { > >> + struct omap_dss_device *dssdev = priv->dssdevs[i]; > >> > >> struct drm_connector *connector; > >> struct drm_encoder *encoder; > >> struct drm_plane *plane; > >> struct drm_crtc *crtc; > >> > >> - if (!omapdss_device_is_connected(dssdev)) > >> - continue; > >> - > > > > I believe this hunk is correct as dss devices are only disconnected by > > calls to the oma_dss_driver .disconnect() operation, which is only called > > from omap_disconnect_dssdevs(), but you should at the very least explain > > why in the commit message. > > The check became irrelevant as we did not add dssdevs to the array if > their connect failed and as you have said we only disconnect ddsdevs in > omap_disconnect_dssdevs() - in cleanup paths. > > I will update the commit message with this information.
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index bd7fe317a365..b089604e871c 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.c +++ b/drivers/gpu/drm/omapdrm/omap_drv.c @@ -146,18 +146,27 @@ static int get_connector_type(struct omap_dss_device *dssdev) } } -static void omap_disconnect_dssdevs(void) +static void omap_disconnect_dssdevs(struct drm_device *ddev) { - struct omap_dss_device *dssdev = NULL; + struct omap_drm_private *priv = ddev->dev_private; + int i; + + for (i = 0; i < priv->num_dssdevs; i++) { + struct omap_dss_device *dssdev = priv->dssdevs[i]; - for_each_dss_dev(dssdev) dssdev->driver->disconnect(dssdev); + priv->dssdevs[i] = NULL; + omap_dss_put_device(dssdev); + } + + priv->num_dssdevs = 0; } -static int omap_connect_dssdevs(void) +static int omap_connect_dssdevs(struct drm_device *ddev) { - int r; + struct omap_drm_private *priv = ddev->dev_private; struct omap_dss_device *dssdev = NULL; + int r; if (!omapdss_stack_is_ready()) return -EPROBE_DEFER; @@ -170,6 +179,14 @@ static int omap_connect_dssdevs(void) } else if (r) { dev_warn(dssdev->dev, "could not connect display: %s\n", dssdev->name); + } else { + omap_dss_get_device(dssdev); + priv->dssdevs[priv->num_dssdevs++] = dssdev; + if (priv->num_dssdevs == ARRAY_SIZE(priv->dssdevs)) { + /* To balance the 'for_each_dss_dev' loop */ + omap_dss_put_device(dssdev); + break; + } } } @@ -180,7 +197,7 @@ static int omap_connect_dssdevs(void) * if we are deferring probe, we disconnect the devices we previously * connected */ - omap_disconnect_dssdevs(); + omap_disconnect_dssdevs(ddev); return r; } @@ -205,7 +222,7 @@ static int omap_modeset_init(struct drm_device *dev) int num_ovls = priv->dispc_ops->get_num_ovls(); int num_mgrs = priv->dispc_ops->get_num_mgrs(); int num_crtcs, crtc_idx, plane_idx; - int ret; + int ret, i; u32 plane_crtc_mask; drm_mode_config_init(dev); @@ -222,11 +239,7 @@ static int omap_modeset_init(struct drm_device *dev) * configuration does not match the expectations or exceeds * the available resources, the configuration is rejected. */ - num_crtcs = 0; - for_each_dss_dev(dssdev) - if (omapdss_device_is_connected(dssdev)) - num_crtcs++; - + num_crtcs = priv->num_dssdevs; if (num_crtcs > num_mgrs || num_crtcs > num_ovls || num_crtcs > ARRAY_SIZE(priv->crtcs) || num_crtcs > ARRAY_SIZE(priv->planes) || @@ -244,15 +257,13 @@ static int omap_modeset_init(struct drm_device *dev) crtc_idx = 0; plane_idx = 0; - for_each_dss_dev(dssdev) { + for (i = 0; i < priv->num_dssdevs; i++) { + struct omap_dss_device *dssdev = priv->dssdevs[i]; struct drm_connector *connector; struct drm_encoder *encoder; struct drm_plane *plane; struct drm_crtc *crtc; - if (!omapdss_device_is_connected(dssdev)) - continue; - encoder = omap_encoder_init(dev, dssdev); if (!encoder) return -ENOMEM; @@ -326,11 +337,14 @@ static int omap_modeset_init(struct drm_device *dev) /* * Enable the HPD in external components if supported */ -static void omap_modeset_enable_external_hpd(void) +static void omap_modeset_enable_external_hpd(struct drm_device *ddev) { - struct omap_dss_device *dssdev = NULL; + struct omap_drm_private *priv = ddev->dev_private; + int i; + + for (i = 0; i < priv->num_dssdevs; i++) { + struct omap_dss_device *dssdev = priv->dssdevs[i]; - for_each_dss_dev(dssdev) { if (dssdev->driver->enable_hpd) dssdev->driver->enable_hpd(dssdev); } @@ -339,11 +353,14 @@ static void omap_modeset_enable_external_hpd(void) /* * Disable the HPD in external components if supported */ -static void omap_modeset_disable_external_hpd(void) +static void omap_modeset_disable_external_hpd(struct drm_device *ddev) { - struct omap_dss_device *dssdev = NULL; + struct omap_drm_private *priv = ddev->dev_private; + int i; + + for (i = 0; i < priv->num_dssdevs; i++) { + struct omap_dss_device *dssdev = priv->dssdevs[i]; - for_each_dss_dev(dssdev) { if (dssdev->driver->disable_hpd) dssdev->driver->disable_hpd(dssdev); } @@ -562,7 +579,7 @@ static int pdev_probe(struct platform_device *pdev) omap_crtc_pre_init(); - ret = omap_connect_dssdevs(); + ret = omap_connect_dssdevs(ddev); if (ret) goto err_crtc_uninit; @@ -597,7 +614,7 @@ static int pdev_probe(struct platform_device *pdev) priv->fbdev = omap_fbdev_init(ddev); drm_kms_helper_poll_init(ddev); - omap_modeset_enable_external_hpd(); + omap_modeset_enable_external_hpd(ddev); /* * Register the DRM device with the core and the connectors with @@ -610,7 +627,7 @@ static int pdev_probe(struct platform_device *pdev) return 0; err_cleanup_helpers: - omap_modeset_disable_external_hpd(); + omap_modeset_disable_external_hpd(ddev); drm_kms_helper_poll_fini(ddev); if (priv->fbdev) omap_fbdev_free(ddev); @@ -620,7 +637,7 @@ static int pdev_probe(struct platform_device *pdev) err_gem_deinit: omap_gem_deinit(ddev); destroy_workqueue(priv->wq); - omap_disconnect_dssdevs(); + omap_disconnect_dssdevs(ddev); err_crtc_uninit: omap_crtc_pre_uninit(); drm_dev_unref(ddev); @@ -636,7 +653,7 @@ static int pdev_remove(struct platform_device *pdev) drm_dev_unregister(ddev); - omap_modeset_disable_external_hpd(); + omap_modeset_disable_external_hpd(ddev); drm_kms_helper_poll_fini(ddev); if (priv->fbdev) @@ -651,7 +668,7 @@ static int pdev_remove(struct platform_device *pdev) destroy_workqueue(priv->wq); - omap_disconnect_dssdevs(); + omap_disconnect_dssdevs(ddev); omap_crtc_pre_uninit(); drm_dev_unref(ddev); @@ -660,11 +677,14 @@ static int pdev_remove(struct platform_device *pdev) } #ifdef CONFIG_PM_SLEEP -static int omap_drm_suspend_all_displays(void) +static int omap_drm_suspend_all_displays(struct drm_device *ddev) { - struct omap_dss_device *dssdev = NULL; + struct omap_drm_private *priv = ddev->dev_private; + int i; + + for (i = 0; i < priv->num_dssdevs; i++) { + struct omap_dss_device *dssdev = priv->dssdevs[i]; - for_each_dss_dev(dssdev) { if (!dssdev->driver) continue; @@ -679,11 +699,14 @@ static int omap_drm_suspend_all_displays(void) return 0; } -static int omap_drm_resume_all_displays(void) +static int omap_drm_resume_all_displays(struct drm_device *ddev) { - struct omap_dss_device *dssdev = NULL; + struct omap_drm_private *priv = ddev->dev_private; + int i; + + for (i = 0; i < priv->num_dssdevs; i++) { + struct omap_dss_device *dssdev = priv->dssdevs[i]; - for_each_dss_dev(dssdev) { if (!dssdev->driver) continue; @@ -703,7 +726,7 @@ static int omap_drm_suspend(struct device *dev) drm_kms_helper_poll_disable(drm_dev); drm_modeset_lock_all(drm_dev); - omap_drm_suspend_all_displays(); + omap_drm_suspend_all_displays(drm_dev); drm_modeset_unlock_all(drm_dev); return 0; @@ -714,7 +737,7 @@ static int omap_drm_resume(struct device *dev) struct drm_device *drm_dev = dev_get_drvdata(dev); drm_modeset_lock_all(drm_dev); - omap_drm_resume_all_displays(); + omap_drm_resume_all_displays(drm_dev); drm_modeset_unlock_all(drm_dev); drm_kms_helper_poll_enable(drm_dev); diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h b/drivers/gpu/drm/omapdrm/omap_drv.h index 4bd1e9070b31..cccaae787a7c 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.h +++ b/drivers/gpu/drm/omapdrm/omap_drv.h @@ -51,6 +51,9 @@ struct omap_drm_private { const struct dispc_ops *dispc_ops; + unsigned int num_dssdevs; + struct omap_dss_device *dssdevs[8]; + unsigned int num_crtcs; struct drm_crtc *crtcs[8];
Instead of reaching back to DSS to iterate through the dss_devices every time, use an internal array where we store the available and usable dss_devices. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- drivers/gpu/drm/omapdrm/omap_drv.c | 95 +++++++++++++++++++++++--------------- drivers/gpu/drm/omapdrm/omap_drv.h | 3 ++ 2 files changed, 62 insertions(+), 36 deletions(-)