| Message ID | 20170901144430.19164-1-thierry.reding@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 01, 2017 at 04:44:28PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > It's unusual to separate kerneldoc comments from the functions that they > describe by a blank line. Remove them. > > Signed-off-by: Thierry Reding <treding@nvidia.com> Series lgtm Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/drm_scdc_helper.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c > index 935653eb3616..d66c436a829e 100644 > --- a/drivers/gpu/drm/drm_scdc_helper.c > +++ b/drivers/gpu/drm/drm_scdc_helper.c > @@ -134,7 +134,6 @@ EXPORT_SYMBOL(drm_scdc_write); > * Returns: > * True if the scrambling is enabled, false otherwise. > */ > - > bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) > { > u8 status; > @@ -162,7 +161,6 @@ EXPORT_SYMBOL(drm_scdc_get_scrambling_status); > * Returns: > * True if scrambling is set/reset successfully, false otherwise. > */ > - > bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) > { > u8 config; > -- > 2.13.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, Sep 01, 2017 at 07:00:52PM +0300, Ville Syrjälä wrote: > On Fri, Sep 01, 2017 at 04:44:28PM +0200, Thierry Reding wrote: > > From: Thierry Reding <treding@nvidia.com> > > > > It's unusual to separate kerneldoc comments from the functions that they > > describe by a blank line. Remove them. > > > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > Series lgtm > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Applied to drm-misc-next, thanks. Thierry
Regards Shashank On 9/1/2017 8:14 PM, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > It's unusual to separate kerneldoc comments from the functions that they > describe by a blank line. Remove them. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/gpu/drm/drm_scdc_helper.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c > index 935653eb3616..d66c436a829e 100644 > --- a/drivers/gpu/drm/drm_scdc_helper.c > +++ b/drivers/gpu/drm/drm_scdc_helper.c > @@ -134,7 +134,6 @@ EXPORT_SYMBOL(drm_scdc_write); > * Returns: > * True if the scrambling is enabled, false otherwise. > */ > - > bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) > { > u8 status; > @@ -162,7 +161,6 @@ EXPORT_SYMBOL(drm_scdc_get_scrambling_status); > * Returns: > * True if scrambling is set/reset successfully, false otherwise. > */ > - > bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) > { > u8 config; Thanks for the fix Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c index 935653eb3616..d66c436a829e 100644 --- a/drivers/gpu/drm/drm_scdc_helper.c +++ b/drivers/gpu/drm/drm_scdc_helper.c @@ -134,7 +134,6 @@ EXPORT_SYMBOL(drm_scdc_write); * Returns: * True if the scrambling is enabled, false otherwise. */ - bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) { u8 status; @@ -162,7 +161,6 @@ EXPORT_SYMBOL(drm_scdc_get_scrambling_status); * Returns: * True if scrambling is set/reset successfully, false otherwise. */ - bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) { u8 config;