From patchwork Tue Oct 17 21:13:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10012877 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8404E600CC for ; Tue, 17 Oct 2017 21:14:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 767C028560 for ; Tue, 17 Oct 2017 21:14:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B0F528620; Tue, 17 Oct 2017 21:14:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5FFC228560 for ; Tue, 17 Oct 2017 21:14:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4CA156E789; Tue, 17 Oct 2017 21:14:12 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD3096E789 for ; Tue, 17 Oct 2017 21:14:10 +0000 (UTC) Received: by mail-io0-x22c.google.com with SMTP id 134so3821307ioo.0 for ; Tue, 17 Oct 2017 14:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iek/4GjYwkptEeyTnppOjNhNEK/RsuGgJ2mqLWEehFM=; b=R0o9Psa9ybNJZjSLeKjYmWbhp9MUMeJN3JyZoZIugiNmdz1PQpPTIourKg7qbwr1BJ /5n8mFDcoBO1i+xnts4uDHFTvloE8FNnEwo6WfgA5cL9++BVRicUo1ZpopQeo0hIDAg3 xL2ck711P16bNeu7Sv6nGygyaiGaP0Yb8VP6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iek/4GjYwkptEeyTnppOjNhNEK/RsuGgJ2mqLWEehFM=; b=fU/kyF3kio6vSPBwCwvzNYd5Oc3otjVCsa1CfuwaP+X6krQ84KgQVFmgSomWbldHUj PgNt9F2WMtdLs+IhzeV70qlMQg2Tqe4iw6/4pEYpSlWb8fg2we7G5uQQNkiH5Sw58tfB SdGe9jqT8tK0FkVvNEjVpD3AaXdI2kgsGtd1oXrtzREZP3gMIYNA3b6b05qLBmNsNGbh YmdML3C7JZziJ0IoxAhMaxSxIs/jUYNcHa+V9/tB35BOAub4VrdAU3/trpddz/loz9l6 aBO70cmp0029ZpNO986C3Qa5AsYP4HAVV8VrPEhvKvg7ie8IeJSaIctvtAhJf7B1GWMt 1p9w== X-Gm-Message-State: AMCzsaVt0PPPHkRalSi9TWARpp4wtyif0TOvbYlnHArIedWlMB8881KY zDUXBZyqzTJyCF6UmN9ZKp7XYhiyM7M= X-Google-Smtp-Source: ABhQp+QyFGzxg2jSPO6VSqs8gNoKJOeUZv0yzJfd4C+r4w5h9TvZddLzPKeSgidbiLPHNjP99UQhUw== X-Received: by 10.107.173.142 with SMTP id m14mr19522700ioo.28.1508274849834; Tue, 17 Oct 2017 14:14:09 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:0:f685:3152:9ba1:429a]) by smtp.gmail.com with ESMTPSA id f2sm5220677ioj.73.2017.10.17.14.14.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Oct 2017 14:14:09 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org Subject: [PATCH v3 07/12] drm/panel: otm8009a: Remove enabled state Date: Tue, 17 Oct 2017 17:13:10 -0400 Message-Id: <20171017211321.7992-8-seanpaul@chromium.org> X-Mailer: git-send-email 2.15.0.rc1.287.g2b38de12cc-goog In-Reply-To: <20171017211321.7992-1-seanpaul@chromium.org> References: <20171017211321.7992-1-seanpaul@chromium.org> Cc: thierry.reding@gmail.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP It's not necessary for atomic drivers, and drm_panel will WARN if the calls are unbalanced. Signed-off-by: Sean Paul --- No changes since v1 drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c index c189cd6329c8..0a5898fd4502 100644 --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c @@ -63,7 +63,6 @@ struct otm8009a { struct backlight_device *bl_dev; struct gpio_desc *reset_gpio; bool prepared; - bool enabled; }; static const struct drm_display_mode default_mode = { @@ -243,9 +242,6 @@ static int otm8009a_disable(struct drm_panel *panel) struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); int ret; - if (!ctx->enabled) - return 0; /* This is not an issue so we return 0 here */ - /* Power off the backlight. Note: end-user still controls brightness */ ctx->bl_dev->props.power = FB_BLANK_POWERDOWN; ret = backlight_update_status(ctx->bl_dev); @@ -262,8 +258,6 @@ static int otm8009a_disable(struct drm_panel *panel) msleep(120); - ctx->enabled = false; - return 0; } @@ -316,15 +310,6 @@ static int otm8009a_prepare(struct drm_panel *panel) return 0; } -static int otm8009a_enable(struct drm_panel *panel) -{ - struct otm8009a *ctx = panel_to_otm8009a(panel); - - ctx->enabled = true; - - return 0; -} - static int otm8009a_get_modes(struct drm_panel *panel) { struct drm_display_mode *mode; @@ -352,7 +337,6 @@ static const struct drm_panel_funcs otm8009a_drm_funcs = { .disable = otm8009a_disable, .unprepare = otm8009a_unprepare, .prepare = otm8009a_prepare, - .enable = otm8009a_enable, .get_modes = otm8009a_get_modes, };