| Message ID | 20171214203054.20141-3-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Dec 14, 2017 at 3:30 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > It thinks we want to document the __printf(2,0) annotion. Not sure we > want to teach it about all possible gcc-only flags, hence why I opted > for the cheap trick of just moving it ahead of the kerneldoc. > > This is only a problem for static inline functions, since for > non-inline function the kerneldoc is in the .c file, but the special > annotations are all in the header. > > Cc'ing kernel-doc maintainers as fyi. > > Cc: linux-doc@vger.kernel.org > Cc: Jonathan Corbet <corbet@lwn.net> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> > --- > include/drm/drm_print.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h > index 5f9932e2246e..2a4a42e59a47 100644 > --- a/include/drm/drm_print.h > +++ b/include/drm/drm_print.h > @@ -80,13 +80,13 @@ void __drm_printfn_debug(struct drm_printer *p, struct va_format *vaf); > __printf(2, 3) > void drm_printf(struct drm_printer *p, const char *f, ...); > > +__printf(2, 0) > /** > * drm_vprintf - print to a &drm_printer stream > * @p: the &drm_printer > * @fmt: format string > * @va: the va_list > */ > -__printf(2, 0) > static inline void > drm_vprintf(struct drm_printer *p, const char *fmt, va_list *va) > { > -- > 2.15.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index 5f9932e2246e..2a4a42e59a47 100644 --- a/include/drm/drm_print.h +++ b/include/drm/drm_print.h @@ -80,13 +80,13 @@ void __drm_printfn_debug(struct drm_printer *p, struct va_format *vaf); __printf(2, 3) void drm_printf(struct drm_printer *p, const char *f, ...); +__printf(2, 0) /** * drm_vprintf - print to a &drm_printer stream * @p: the &drm_printer * @fmt: format string * @va: the va_list */ -__printf(2, 0) static inline void drm_vprintf(struct drm_printer *p, const char *fmt, va_list *va) {
It thinks we want to document the __printf(2,0) annotion. Not sure we want to teach it about all possible gcc-only flags, hence why I opted for the cheap trick of just moving it ahead of the kerneldoc. This is only a problem for static inline functions, since for non-inline function the kerneldoc is in the .c file, but the special annotations are all in the header. Cc'ing kernel-doc maintainers as fyi. Cc: linux-doc@vger.kernel.org Cc: Jonathan Corbet <corbet@lwn.net> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- include/drm/drm_print.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)