From patchwork Tue Dec 26 11:12:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Liu X-Patchwork-Id: 10133461 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 57D2F60388 for ; Wed, 27 Dec 2017 08:09:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E6ED2DB66 for ; Wed, 27 Dec 2017 08:09:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 333972DB84; Wed, 27 Dec 2017 08:09:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BC2032DB66 for ; Wed, 27 Dec 2017 08:09:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B47089483; Wed, 27 Dec 2017 08:09:11 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pl0-x241.google.com (mail-pl0-x241.google.com [IPv6:2607:f8b0:400e:c01::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D3E489904 for ; Tue, 26 Dec 2017 11:10:09 +0000 (UTC) Received: by mail-pl0-x241.google.com with SMTP id 62so16269225pld.7 for ; Tue, 26 Dec 2017 03:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TNPhVuMX2TE519NvPosz1h760/UvuYs9VAa9QM8h5sk=; b=f7rTBYct1JYPH/5hc35UdXQzFKK5VfKUVCzJcN22wRdKdd1CcqfKcqWcZsLnZiSvUd jwMyXoVXxfkU0Ks1ZE0kRYKQm1EPD2ie3x07UBXKxdnKTCUGY4QC6TzLVRkjga/6d4C+ mBjrGVEsRJCXYzoQjutRydnK5brUHjPbI2NxM6pGRwQM8VKU5a8Ov8w3y9oK7TvNYQ9g OF3Vc86dKpdyfJQKgo+8u2BvR3NY7as31g8PWYipDSZhId1ytSYHjtPnONZ06TAY7640 6y6TiGV55QLnCEPSrel6o8yVlNzj8M0YGHq1Rsii9Niq0dY6pRWIrS4/0JKB+7oZbvWa sR2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TNPhVuMX2TE519NvPosz1h760/UvuYs9VAa9QM8h5sk=; b=JM+uOUiYepZ6QiMF0XSA3H1ng9lmHa9yzjs4zVDIlVdD2sK49591EqADvVX983RROT Sau2gsbeRr2eZlyg96HlLa2uI9iUnICCfe2jJMF2oE2iJzHrAdhKFO5qhhKu7ZOJ2vP+ Oo+he0zKWAYkKpsEA3arqf4bPd58hoV/LAqSv0MQikuiz9iqGXSzOuLsvRM8v+ZBXSDf JjW2nLDvn3y5VA04SeywX98ZsT4ms7XEw6Hee+Ta//Csv7k9Cne02myDSB5bEg42921z 8bCghdp1sZgsUjyc2Pv9SAJ61nJ6kZWEgCywlomwoyKP5U6cQbrspjKLqqjxqtEP32H4 MJ9A== X-Gm-Message-State: AKGB3mIkMoi5qnpLYRoAiZ2GtoOIR4yVoBsAqb3h5x6m8BKGrHBcmtbP D9+imLXRgLIPgWmJ/uo0KgI= X-Google-Smtp-Source: ACJfBov/uolUIcvlvc9QVKBosq8zVehVPeOZrGRmLIh4eJZiYF2jWL8jOVkBFe9y/6UohI6ugdZUiA== X-Received: by 10.84.130.109 with SMTP id 100mr25603214plc.329.1514286608990; Tue, 26 Dec 2017 03:10:08 -0800 (PST) Received: from 60-242-179-244.static.tpgi.com.au (60-242-179-244.static.tpgi.com.au. [60.242.179.244]) by smtp.gmail.com with ESMTPSA id u68sm58217028pfu.17.2017.12.26.03.10.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Dec 2017 03:10:07 -0800 (PST) From: Jonathan Liu To: Maxime Ripard , David Airlie , Chen-Yu Tsai Subject: [PATCH v2 1/3] drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate Date: Tue, 26 Dec 2017 22:12:25 +1100 Message-Id: <20171226111227.4526-2-net147@gmail.com> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171226111227.4526-1-net147@gmail.com> References: <20171226111227.4526-1-net147@gmail.com> X-Mailman-Approved-At: Wed, 27 Dec 2017 08:09:10 +0000 Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Jonathan Liu , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP We should check if the best match has been set before comparing it. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c index dc332ea56f6c..4d235e5ea31c 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c @@ -102,7 +102,7 @@ static int sun4i_tmds_determine_rate(struct clk_hw *hw, goto out; } - if (abs(rate - rounded / i) < + if (!best_parent || abs(rate - rounded / i) < abs(rate - best_parent / best_div)) { best_parent = rounded; best_div = i;