From patchwork Wed Jan 17 08:10:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 10168789 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9A75960386 for ; Wed, 17 Jan 2018 08:52:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 88D1F27CF9 for ; Wed, 17 Jan 2018 08:52:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7DCA227FB0; Wed, 17 Jan 2018 08:52:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4D09527CF9 for ; Wed, 17 Jan 2018 08:52:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C83426E3A7; Wed, 17 Jan 2018 08:52:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68AC66E387; Wed, 17 Jan 2018 08:10:38 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id t74so13363041wme.3; Wed, 17 Jan 2018 00:10:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=QDdDxRFzAK3Sg39MZYC5BzFI8rB3lH61tICZD+gqNuw=; b=krYpoSPDlyMKrlbS9/uDpYs93RDxPxrc1zxgVIMvBj2HbuFPsOT+1Q36TzxGWObxFp wSNxlvnXusYZdA5T8d1NrpsB7NBGGaQ9GiB5AN7cVrIZ42p67f8cPAJveUjftMRbjtz5 qBH4B2ycmRmdxNfFXjB9mN9ogrLcD1HDiCpXkdBs0aITKOKaUGHYs7/94jZaI4E356mt rk8/Hbxh89cWt7/zzeOvz14HZ9q+gAg6F1xL2BdVb3hdwDdT60qdLyFkNYxM4QvYFfmN b+IjK4LBjfkFWSjgdUqaYWTA4y0IJbU5z1ITvH4nToz94GH+CacPnPh+9ZqsxwTSdLq7 HrCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QDdDxRFzAK3Sg39MZYC5BzFI8rB3lH61tICZD+gqNuw=; b=f9TzwMsF+g8nbhzoPBfDisR5i5vg/QA8n0EUarj/DRnyXTfreUPH5DbjOKclxm/6XV iBCfxK6UIpccCw1hOUclVIrXBsr2sinhb8LdukZQuqCi5CkqHuHxcdxe/7oFlsnzTgBG qp7rFHVDwLnFutBV/jE0LIiNB3y7XhcJ+dsuEoEFhzweFj94sYC1doQcFA7NGfoZaJTk 3yapjuvLPH/AIZm+eEduUydkr/RD6LqJX/JcmSdZ8tPf2acQSqx/PGoACqmljxS3UD4+ EGR3jZx3mciVWP2XIhqAC0s0lcuas6N2Pcz8WUcpTWk6m2OrCXdNOq1O11mrCXbYBNzJ 180w== X-Gm-Message-State: AKwxytcQoFrgOxeIIyC08fr3qe9FoO01mOwIP+9l1D4ZHdUCOGHYimi4 Par/5/VU4acBAk4QGkgstZk= X-Google-Smtp-Source: ACJfBosK569mc8Il8rrFOH5Ew/hsRRxtilimGvZGYRbQ/jPeNKeM0CGkD+K+vzJGrL63G+IPkJyRqA== X-Received: by 10.80.170.157 with SMTP id q29mr1762251edc.43.1516176637034; Wed, 17 Jan 2018 00:10:37 -0800 (PST) Received: from shalem.localdomain (546A5441.cm-12-3b.dynamic.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id l50sm2477794eda.72.2018.01.17.00.10.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Jan 2018 00:10:35 -0800 (PST) From: Hans de Goede X-Google-Original-From: Hans de Goede To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Mika Kuoppala Subject: [PATCH] drm: Fix PANEL_ORIENTATION_QUIRKS breaking the Kconfig DRM menuconfig Date: Wed, 17 Jan 2018 09:10:32 +0100 Message-Id: <20180117081032.6411-1-hdegoede@redhat.com> X-Mailer: git-send-email 2.14.3 X-Mailman-Approved-At: Wed, 17 Jan 2018 08:52:37 +0000 Cc: Hans de Goede , intel-gfx , dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP All Kconfig menu menu entries should have a depends on MENU_OPTION, the menu stops after the first Kconfig entry without this depends on. Since the PANEL_ORIENTATION_QUIRKS option is also used outside of DRM, it deliberately does not have a depends on DRM, but this causes all items after it to show as separate items rather then under the DRM menuconfig. This commit moves PANEL_ORIENTATION_QUIRKS to the end of the drm Kconfig file, grouping it with DRM_LIB_RANDOM which also does not depend on DRM, fixing the DRM menuconfig. Fixes: 404d1a3edc38 ("drm: Add panel orientation quirks, v6.") Cc: Chris Wilson Reported-by: Chris Wilson Signed-off-by: Hans de Goede --- drivers/gpu/drm/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 0bc374459440..deeefa7a1773 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -27,10 +27,6 @@ config DRM_MIPI_DSI bool depends on DRM -# Separate option because drm_panel_orientation_quirks.c is shared with fbdev -config DRM_PANEL_ORIENTATION_QUIRKS - tristate - config DRM_DP_AUX_CHARDEV bool "DRM DP AUX Interface" depends on DRM @@ -372,6 +368,10 @@ config DRM_SAVAGE endif # DRM_LEGACY +# Separate option because drm_panel_orientation_quirks.c is shared with fbdev +config DRM_PANEL_ORIENTATION_QUIRKS + tristate + config DRM_LIB_RANDOM bool default n