From patchwork Wed Jan 17 21:37:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10172633 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3E1EB60230 for ; Thu, 18 Jan 2018 09:45:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 30F3925D99 for ; Thu, 18 Jan 2018 09:45:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 243F62623D; Thu, 18 Jan 2018 09:45:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9F4FF25D99 for ; Thu, 18 Jan 2018 09:45:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 61A556E599; Thu, 18 Jan 2018 09:40:22 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yw0-x241.google.com (mail-yw0-x241.google.com [IPv6:2607:f8b0:4002:c05::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0734B6E1C4 for ; Wed, 17 Jan 2018 21:37:53 +0000 (UTC) Received: by mail-yw0-x241.google.com with SMTP id c78so9512820ywb.13 for ; Wed, 17 Jan 2018 13:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=4rEh8xgZqub3OO6yZOOyd4kpMLSZUTE0aQYu/MqGKgM=; b=BtsE8Grbms4yydemtMuTjzLCh6dw2Fu5SU1sicPkTBsIlDu+l/9fKh5ghcJOrJYvcN Mj9jKOOT56lYFNjX4gIyUrksJFLyFt8qu/xiQzU6zOgoRTDX7L+7/B4Tg2dV6V0k5FDW 2Xn20Qm5nbolWP15+y8tpgwjPF5tlO/TMZ2X0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4rEh8xgZqub3OO6yZOOyd4kpMLSZUTE0aQYu/MqGKgM=; b=SFVpz+YUgYL2CdH6vrNLgVFzElTomfyRmXVNaixjxRf1EVdbePR8X6eJmAHkJXy2lE yMZsLOuOEC/Yre6SECtDa7gFkH/cwtd+3gC+rKZZEG4IzOfXpF3x/BJ1dTaMpIToCS2d /htQ688UWVgdTc1IWc8ch7DFD9GIQRaDcbGdt5UTOCoTMab4x+BEeMpfZiraDOpSkMKc MMvi7RK9Atwys4/KXPceXlmp8uXUIw7NNM3u+OVY1YEy9n/vLDEB/8dumK8bhHAhgLjg uE+vTCFP5DmPd4CzLla6NGX2VcZYjuU3VOEuvCS0iN3SQgpdJez7RyyTvmK21zsOfA0G 811Q== X-Gm-Message-State: AKwxytdMxrqHbbCpJ6aPjC/5jhrC0WMrqvSQp6AFz7F3lpkjg1mNuoaJ LmI9xH7Knp6URteYg3JDsTr9Uwtt9lY= X-Google-Smtp-Source: ACJfBoumkjjhs1K90C3jwoZnDMsuYG5xiQqQKU7+ZbdA6o5dK/7c3/kGv+iHRZBo48XDauAw4EODQg== X-Received: by 10.129.133.70 with SMTP id v67mr3844550ywf.355.1516225072906; Wed, 17 Jan 2018 13:37:52 -0800 (PST) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:d3af:69ac:1964:28e8]) by smtp.gmail.com with ESMTPSA id c80sm2172436ywb.52.2018.01.17.13.37.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jan 2018 13:37:52 -0800 (PST) From: Sean Paul To: dri-devel@lists.freedesktop.org, philippe.cornu@st.com Subject: [PATCH] drm/panel: panasonic-vvx10f034n00: More return value fixes Date: Wed, 17 Jan 2018 16:37:43 -0500 Message-Id: <20180117213751.54668-1-seanpaul@chromium.org> X-Mailer: git-send-email 2.16.0.rc1.238.g530d649a79-goog Cc: Thierry Reding X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP A couple more return value fixes which Philippe brought up during our previous review. Suggested-by: Philippe CORNU Signed-off-by: Sean Paul Reviewed-by: Philippe Cornu --- drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c index 91dc5a6b14f9..74a806121f80 100644 --- a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c +++ b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c @@ -59,35 +59,28 @@ static inline struct wuxga_nt_panel *to_wuxga_nt_panel(struct drm_panel *panel) static int wuxga_nt_panel_on(struct wuxga_nt_panel *wuxga_nt) { - struct mipi_dsi_device *dsi = wuxga_nt->dsi; - int ret; - - ret = mipi_dsi_turn_on_peripheral(dsi); - if (ret < 0) - return ret; - - return 0; + return mipi_dsi_turn_on_peripheral(wuxga_nt->dsi); } static int wuxga_nt_panel_disable(struct drm_panel *panel) { struct wuxga_nt_panel *wuxga_nt = to_wuxga_nt_panel(panel); - int ret; + int mipi_ret, bl_ret = 0; if (!wuxga_nt->enabled) return 0; - ret = mipi_dsi_shutdown_peripheral(wuxga_nt->dsi); + mipi_ret = mipi_dsi_shutdown_peripheral(wuxga_nt->dsi); if (wuxga_nt->backlight) { wuxga_nt->backlight->props.power = FB_BLANK_POWERDOWN; wuxga_nt->backlight->props.state |= BL_CORE_FBBLANK; - backlight_update_status(wuxga_nt->backlight); + bl_ret = backlight_update_status(wuxga_nt->backlight); } wuxga_nt->enabled = false; - return ret; + return mipi_ret ? mipi_ret : bl_ret; } static int wuxga_nt_panel_unprepare(struct drm_panel *panel)