From patchwork Wed Jan 24 16:18:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tvrtko Ursulin X-Patchwork-Id: 10183249 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6A60660353 for ; Wed, 24 Jan 2018 23:08:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5366528928 for ; Wed, 24 Jan 2018 23:08:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 451AE28942; Wed, 24 Jan 2018 23:08:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E1C1428928 for ; Wed, 24 Jan 2018 23:08:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5BEBD6E6DA; Wed, 24 Jan 2018 23:08:05 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8AD56E60A for ; Wed, 24 Jan 2018 16:18:53 +0000 (UTC) Received: by mail-wr0-x242.google.com with SMTP id g38so4640395wrd.2 for ; Wed, 24 Jan 2018 08:18:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ursulin-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zN06uweeJuSNaDmixvtVex/wDBsP6qVvCkevgaws47w=; b=d8hXD2HEisU/z4bwMMD/ew/zU5Ygo+127mRcBIIIh89iwVoVjwa0hoejHOT9T8xhAs u7LiwtaHguBk9jQfGG0tlDuO4pKv8kcKGR3PxSDbZhy/BePzLL6nhqLQKEll4IZSVmw2 PZEyGhwQpznUqi2092DCTH8a0BneG+sZypLqmGI5bhjptCyIB5c9OisFtn0KNZKUZp/D c1E0I5tOzRkWUvYLGHvIeHWiAIiduGognOFTxSGc3wUxloMyPUsqINPImc0nq0PZNgQT PzFahrO1/o5JCD2Y5UdvT61l5kdLbXCoakQW6axGpVhWVY2HstsFL+ck0dOxD+5y+8UC 2qWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zN06uweeJuSNaDmixvtVex/wDBsP6qVvCkevgaws47w=; b=H5Q9LVjHT2zQoGjfR6fCEaNqmqiNnVTM4RQiXYe7HjBDr4erCAsWrqssw8XfoUS37J D/248YHh4xUxgGBk4Hdi+qsEU+rggvKl24GmOxvHN9A3+/de8ODSwJcB4lUHMPmonpBI 5ogxLBr7anjtnqnJrGsr59PpbkhdqmiSrkEbIvRF7AEQ91TxHuTFJ+gOJL9sv7+06O49 gOzonry2JpSr2vIJkKEHvntmP1oDYWHtXlnJ1vgL9+bsouCxVV60y6j61ZJMxqDh7JO8 3G4lD/6RcdsXFcBLcD1yRjV7L6d8DDd//4wRpsCMvcOZ7w3rxADdL5F7/GdYUfskKGkG KFEg== X-Gm-Message-State: AKwxytdY7nzRhnsVK8QQkvP4y2p+EXrKQTlFtTWysLdsP39cFMdy2/tS VYvhrUNkfOy3S020gs3plweeIsHq X-Google-Smtp-Source: AH8x227+tbAsC8NLVCjx1pzCDhFOHFU6Eh34Z1FMKVBRYhl1/1gkRm5BKhM3owyNGMlN4tni3d22OA== X-Received: by 10.223.134.104 with SMTP id 37mr5980334wrw.103.1516810732290; Wed, 24 Jan 2018 08:18:52 -0800 (PST) Received: from localhost.localdomain ([95.146.148.3]) by smtp.gmail.com with ESMTPSA id y62sm5702609wrb.48.2018.01.24.08.18.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jan 2018 08:18:51 -0800 (PST) From: Tvrtko Ursulin X-Google-Original-From: Tvrtko Ursulin To: Intel-gfx@lists.freedesktop.org Subject: [RFC 1/6] drm/armada: Simplify drm_dev_init error log Date: Wed, 24 Jan 2018 16:18:16 +0000 Message-Id: <20180124161821.28780-2-tvrtko.ursulin@linux.intel.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180124161821.28780-1-tvrtko.ursulin@linux.intel.com> References: <20180124161821.28780-1-tvrtko.ursulin@linux.intel.com> X-Mailman-Approved-At: Wed, 24 Jan 2018 23:07:46 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Tvrtko Ursulin , Russell King , dri-devel@lists.freedesktop.org, tursulin@ursulin.net MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Tvrtko Ursulin dev_err will log the device in question and since there is a single caller to drm_dev_init inside this driver, the drm prefix and the function name can both also be safely dropped. Signed-off-by: Tvrtko Ursulin Cc: Russell King Cc: David Airlie Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/armada/armada_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c index 4b11b6b52f1d..76a06bf6ebcd 100644 --- a/drivers/gpu/drm/armada/armada_drv.c +++ b/drivers/gpu/drm/armada/armada_drv.c @@ -115,8 +115,7 @@ static int armada_drm_bind(struct device *dev) ret = drm_dev_init(&priv->drm, &armada_drm_driver, dev); if (ret) { - dev_err(dev, "[" DRM_NAME ":%s] drm_dev_init failed: %d\n", - __func__, ret); + dev_err(dev, "drm_dev_init failed: %d\n", ret); kfree(priv); return ret; }