From patchwork Fri Feb 9 23:12:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 10210087 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2159D60245 for ; Fri, 9 Feb 2018 23:12:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 16D7B290F4 for ; Fri, 9 Feb 2018 23:12:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 07DB8299BE; Fri, 9 Feb 2018 23:12:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8D7AA290F4 for ; Fri, 9 Feb 2018 23:12:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E9C6C6E261; Fri, 9 Feb 2018 23:12:42 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pl0-f67.google.com (mail-pl0-f67.google.com [209.85.160.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88D6E6E261 for ; Fri, 9 Feb 2018 23:12:41 +0000 (UTC) Received: by mail-pl0-f67.google.com with SMTP id 11so2134473plc.9 for ; Fri, 09 Feb 2018 15:12:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=lj7vJekNMsI0Vw13rz2VdeXltSGLk5+AzoK6CQVCvzg=; b=JkKDhOtULqHHSQtm9XK/1GTrNh6vKbHRObzjfWNbMTpheKoM52MOpv8fRQUr372Je7 touR8XVYduR0iOO854nDT+q40ZJRAK1WpItGNvy7adO/0RJBNhcG9o5/C5Cz/gGaVtgy BSqCnpKvQ6541GRue6Vv1ExcTgVnEQSBO1ZxxlRywWyFRtjR6bovrNOGOTTv72Es0CqB gyH0bWtj6mIQIFicyrKORjr/BqESbWNbr64qvtSZj6w7upuxFSL9eDmPYeovVjce9dfr K/SAxhj5CzfJ3iNQgEyEsQpD/KXhuCLVRTbbAI9GvI09FBUrzYrmFyinrb0MWfePqBZk P+vA== X-Gm-Message-State: APf1xPDSLDZqw1+JnzCl5GhcQ4AQ6ecKGuGBFzCcr8WV8Jcyob9TEVvR xU2WsdlDYj+pQQhbPns3661NBw== X-Google-Smtp-Source: AH8x227tQx2gU1KQbzCPAHBXN5M2I7jvgUVIdMkF8EkL1O0TOeBVRfKPvijjnfzSrT9tGnCkEcE6Hg== X-Received: by 2002:a17:902:b605:: with SMTP id b5-v6mr4068389pls.318.1518217960697; Fri, 09 Feb 2018 15:12:40 -0800 (PST) Received: from mka.mtv.corp.google.com ([2620:0:1000:1600:5ff4:666d:2881:a60]) by smtp.gmail.com with ESMTPSA id 27sm15833199pfj.173.2018.02.09.15.12.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Feb 2018 15:12:39 -0800 (PST) From: Matthias Kaehlcke To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Zhou , David Airlie , Harry Wentland , Tony Cheng , Wenjing Liu Subject: [PATCH] amdgpu/dc: Remove unnecessary initialization in dc_link_handle_hpd_rx_irq() Date: Fri, 9 Feb 2018 15:12:33 -0800 Message-Id: <20180209231233.107711-1-mka@chromium.org> X-Mailer: git-send-email 2.16.0.rc1.238.g530d649a79-goog X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Craig Bergstrom , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Justin TerAvest , Matthias Kaehlcke , amd-gfx@lists.freedesktop.org, Guenter Roeck MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The initialization of 'result' is unnecessary, the variable is assigned unconditionally a few lines below. Removing the initialization also fixes the following warning when building with clang: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1931:26: error: implicit conversion from enumeration type 'enum ddc_result' to different enumeration type 'enum dc_status' [-Werror,-Wenum-conversion] enum dc_status result = DDC_RESULT_UNKNOWN; Signed-off-by: Matthias Kaehlcke Reviewed-by: Guenter Roeck --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c index 4ee4c03a6724..8e3a8c1395a3 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c @@ -1926,7 +1926,7 @@ bool dc_link_handle_hpd_rx_irq(struct dc_link *link, union hpd_irq_data *out_hpd { union hpd_irq_data hpd_irq_dpcd_data = {{{{0}}}}; union device_service_irq device_service_clear = { { 0 } }; - enum dc_status result = DDC_RESULT_UNKNOWN; + enum dc_status result; bool status = false; /* For use cases related to down stream connection status change, * PSR and device auto test, refer to function handle_sst_hpd_irq