From patchwork Tue Feb 20 10:21:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Engestrom X-Patchwork-Id: 10229715 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 34374602B1 for ; Tue, 20 Feb 2018 10:21:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23C19285CA for ; Tue, 20 Feb 2018 10:21:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1897A285D2; Tue, 20 Feb 2018 10:21:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7D1B7285CA for ; Tue, 20 Feb 2018 10:21:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FDF46E384; Tue, 20 Feb 2018 10:21:42 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by gabe.freedesktop.org (Postfix) with ESMTP id AC60E6E384 for ; Tue, 20 Feb 2018 10:21:40 +0000 (UTC) Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Forcepoint Email with ESMTPS id 0591C41A1EAED; Tue, 20 Feb 2018 10:21:36 +0000 (GMT) Received: from imgtec.com (10.60.4.28) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server (TLS) id 14.3.361.1; Tue, 20 Feb 2018 10:21:39 +0000 Date: Tue, 20 Feb 2018 10:21:38 +0000 From: Eric Engestrom To: Jonathan Gray Subject: Re: [PATCH libdrm] configure.ac: pthread-stubs not present on OpenBSD Message-ID: <20180220102138.26ldb5agy6zpbcj3@imgtec.com> References: <20180220060914.90400-1-jsg@jsg.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180220060914.90400-1-jsg@jsg.id.au> User-Agent: NeoMutt/20171215 X-Originating-IP: [10.60.4.28] X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Tuesday, 2018-02-20 17:09:14 +1100, Jonathan Gray wrote: > pthread-stubs is no longer required on OpenBSD and has been removed. > libpthread parts involved moved to libc. Great news! Reviewed-by: Eric Engestrom Note that meson needs the same change: ----8<---- ---->8---- Do you have commit access, or do you want me to push this for you? No need to send a v2, I'll add the meson bit when I push it, or you can add it if you push it yourself. > > Signed-off-by: Jonathan Gray > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 35378b33..d024fcd8 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -65,10 +65,10 @@ AC_CHECK_HEADERS([sys/sysctl.h sys/select.h]) > LT_PREREQ([2.2]) > LT_INIT([disable-static]) > > -dnl pthread-stubs is mandatory on BSD platforms, due to the nature of the > +dnl pthread-stubs is mandatory on some BSD platforms, due to the nature of the > dnl project. Even then there's a notable issue as described in the project README > case "$host_os" in > -linux* | cygwin* | darwin* | solaris* | *-gnu* | gnu*) > +linux* | cygwin* | darwin* | solaris* | *-gnu* | gnu* | openbsd*) > pthread_stubs_possible="no" > ;; > * ) > -- > 2.16.0 > Reviewed-by: Emil Velikov diff --git a/meson.build b/meson.build index d600a906948c0e680885..bd00cdc2cae9f0749180 100644 --- a/meson.build +++ b/meson.build @@ -35,8 +35,7 @@ with_install_tests = get_option('install-test-programs') config = configuration_data() -# TODO: openbsd is guess, the others are correct -if ['freebsd', 'dragonfly', 'netbsd', 'openbsd'].contains(host_machine.system()) +if ['freebsd', 'dragonfly', 'netbsd'].contains(host_machine.system()) dep_pthread_stubs = dependency('pthread-stubs', version : '>= 0.4') else dep_pthread_stubs = []