From patchwork Tue Feb 20 10:29:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 10229747 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CE13B602B1 for ; Tue, 20 Feb 2018 10:29:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE4B327FA3 for ; Tue, 20 Feb 2018 10:29:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B2745285DB; Tue, 20 Feb 2018 10:29:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 98DC7285DA for ; Tue, 20 Feb 2018 10:29:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CF95B89FCC; Tue, 20 Feb 2018 10:29:08 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qk0-x244.google.com (mail-qk0-x244.google.com [IPv6:2607:f8b0:400d:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96B7F89FCC for ; Tue, 20 Feb 2018 10:29:07 +0000 (UTC) Received: by mail-qk0-x244.google.com with SMTP id v124so4361693qkh.11 for ; Tue, 20 Feb 2018 02:29:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cOe7fdvcpCGijEzK1XhcEUhHqLCo26fFaGnKIJPl8mk=; b=he3nTiCnl4JSTyS6fKHVl4mYc1+p6Rlx50MOF7lT6SLcwmzN311AyFCWH2b+iC6Xzh QmAwNVjwmXMX0VXsvSDQj/TUag8kVroQn7ba3Sxp1qTXPG2c4Ij/9r2zFQVsgW4EPaTK e6QzUKTblyoAZ4gYsHqK/ZgMpseyXRNos7rSe+CsjhVYvt6y9ik34/jlwT+2jM56Dz3O 7nC0gLZf9vMShnb0NFJSzrzeViXoTn+kj3Mvl2mcfRILyVc/ZYT5u5IYPYdUiwAnFUCo O35gOQnH1OSoVSaCxjwF8IfAUh47Ha6mu5qHt/l40T1EyMKLk7ldhXCvDjHZQ0IT2fvS M2fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cOe7fdvcpCGijEzK1XhcEUhHqLCo26fFaGnKIJPl8mk=; b=lr4h2nRK4xuDQgb/dAswi9KwoF6IscPUAKorDSuVqLMSfFnikVSp56Edu88FrBiSJt pvnYzIt1sAtqCHnXD7nsIJwA440PzoB9E/cHItpwUHzN0qx5dxlbkMjDc8LWFUJ5BlK2 tolEdXnJij0zEgBuo4sv20dg33gRGau2Or+LkZJYift/MO6ZbHdupgXqMm95v603v7Ql Ej72cH4QaFkmdnwuSuJCw6wJsSXtyL2WJETax976tyeLwoNqMdQOMYr5X66awDpB2IhE frojv6nVqkmgnSGJjtVHmbmbgtXmdUYVBGgHS+7DJSI0Zt4CVSsZjjW6f53+87mrLMSH KNAQ== X-Gm-Message-State: APf1xPDekrZQ4HcF14uvMUYqr+BTdgMa2r3gnSws96q2dSk3wHR5lxLj fXL/vzolz0qJxIBu5alGzTO3bA== X-Google-Smtp-Source: AH8x224Hg8azcoH/1qZPLMO9LdPJzWQa1FrsujmSfvk07e8Bc8AtNv/EGlZgmfuaGm2PW9TRdPWNyA== X-Received: by 10.55.217.143 with SMTP id q15mr22142871qkl.38.1519122546292; Tue, 20 Feb 2018 02:29:06 -0800 (PST) Received: from localhost (p200300E41F106E0039EA77311119C466.dip0.t-ipconnect.de. [2003:e4:1f10:6e00:39ea:7731:1119:c466]) by smtp.gmail.com with ESMTPSA id y58sm8837805qtb.92.2018.02.20.02.29.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Feb 2018 02:29:05 -0800 (PST) From: Thierry Reding To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/pl111: Remove reverse dependency on DRM_DUMB_VGA_DAC Date: Tue, 20 Feb 2018 11:29:03 +0100 Message-Id: <20180220102903.27787-1-thierry.reding@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: References: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Randy Dunlap , linux-next@vger.kernel.org, Laurent Pinchart MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Thierry Reding DRM_DUMB_VGA_DAC is a user-visible symbol. Selecting it can cause unmet direct dependencies such as this (on i386, randconfig): warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) This is because DRM_DUMB_VGA_DAC depends on OF while DRM_PL111 does not. It does indirectly depend on OF via the ARM and ARM64 dependencies, but since it can also be enabled under COMPILE_TEST, randconfig can find a case where DRM_PL111 is selected without pulling in OF and not meeting the dependency for DRM_DUMB_VGA_DAC. Since select is "heavy handed", DRM_DUMB_VGA_DAC is going to be enabled regardless of the above warning and causes the following build error: ../drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': ../drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has no member named 'of_node' vga->bridge.of_node = pdev->dev.of_node; See Documentation/kbuild/kconfig-language.txt, "reverse dependencies". Fixes: 49f81d80ab84 ("drm/pl111: Support handling bridge timings") Reported-by: Randy Dunlap Cc: Laurent Pinchart Cc: Archit Taneja Cc: Eric Anholt Signed-off-by: Thierry Reding Reviewed-by: Linus Walleij Reviewed-by: Eric Anholt --- drivers/gpu/drm/pl111/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig index 82cb3e60ddc8..e5e2abd66491 100644 --- a/drivers/gpu/drm/pl111/Kconfig +++ b/drivers/gpu/drm/pl111/Kconfig @@ -8,7 +8,6 @@ config DRM_PL111 select DRM_GEM_CMA_HELPER select DRM_BRIDGE select DRM_PANEL_BRIDGE - select DRM_DUMB_VGA_DAC select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE help Choose this option for DRM support for the PL111 CLCD controller.