From patchwork Tue Feb 20 10:44:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 10229771 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 13ED0602A7 for ; Tue, 20 Feb 2018 10:44:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 00931285E1 for ; Tue, 20 Feb 2018 10:44:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E929A285E3; Tue, 20 Feb 2018 10:44:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 59454285E1 for ; Tue, 20 Feb 2018 10:44:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2FB6D6E38B; Tue, 20 Feb 2018 10:44:55 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qt0-x243.google.com (mail-qt0-x243.google.com [IPv6:2607:f8b0:400d:c0d::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id C69D36E389; Tue, 20 Feb 2018 10:44:53 +0000 (UTC) Received: by mail-qt0-x243.google.com with SMTP id a9so15722986qtj.8; Tue, 20 Feb 2018 02:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=a2DY5OAV2PiWjicsQr6i/+dVOA4UtMptVvLwqZoB/Iw=; b=HDZYu5emK+mrbaY3W/heLW/xx/ea6U7RxQFIg7mJdS15m6a/BRQ/3ae921mHR833E7 7HKqcFVQcZIQkZ3+6WR8sUbz3js+G28VQN/PaIpygWsJOXckTgR11cfBOIB+gXV/WmHc K0DaFrcVFI0KccYeNkBcYW2rVK5jV9p4LBN9hvgaLlwtWz3ERH394M0hQME+vLRSNnmM YnSFY8NtlRx0uCbavW645UdS3TX85ce9n+K3s6RStnxYfabkwGgyino9SFod/gkhSFoF PHDMxXx/rIslMEC9nel9AkISjUtPB+ZAEio8kY0o7W91BK+G7k7vyWkQ9NT+Zta9+i+b +G4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=a2DY5OAV2PiWjicsQr6i/+dVOA4UtMptVvLwqZoB/Iw=; b=chKrqwktviz47hM60mnxOaAi3j4MxVAFE5y/ycVvu2xRkDuLVidDxce9JHU4V6DXQk 1RXI9PZym1YksGORYj+WG3r/o64ONYaQSmpquvdTnW6wykniKEevxYVoSUNXa2A8ulmK TNlej10OcxtsVFw5gLpT2FJ91OiaBOLdUNMydrRoQol46OzprGcNKpfY3hbhDdQ7jJGh ed182wfuNbgJNvs7ZGqhrHPJVotGERaZkAsw54Wn38uY8X2MznPOTdhUO6zPivTI64uY OChdJH1m0tHAeL06cDVzH71C2Q9dGWbkSGNYrSpaPM9cfEbbcpkHJRmu3I21Y909lnEV YiWg== X-Gm-Message-State: APf1xPBRP2mmsbimYpRlAIxtqU7XrfG0EEUhyNOEJuYLqYcbQWCOO+9b +UFOadJILnzdqctbXLZqTm0bgw== X-Google-Smtp-Source: AH8x224n3iKlh3PKNykJVOnYZtz7wFfzVoH+xDPNzPG3xXdmRY2h3RPzQqt7sBI8sJyhGX7Os5L+aA== X-Received: by 10.200.51.124 with SMTP id u57mr30441493qta.127.1519123492954; Tue, 20 Feb 2018 02:44:52 -0800 (PST) Received: from localhost (p200300E41F106E0039EA77311119C466.dip0.t-ipconnect.de. [2003:e4:1f10:6e00:39ea:7731:1119:c466]) by smtp.gmail.com with ESMTPSA id l47sm5198273qtk.54.2018.02.20.02.44.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Feb 2018 02:44:52 -0800 (PST) From: Thierry Reding To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Zhou Subject: [PATCH] drm/amdgpu: Remove duplicate setting of ->need_swiotlb Date: Tue, 20 Feb 2018 11:44:50 +0100 Message-Id: <20180220104450.28652-1-thierry.reding@gmail.com> X-Mailer: git-send-email 2.15.1 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Thierry Reding There's no need to set this before the number of DMA bits has been properly determined. Signed-off-by: Thierry Reding --- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c index 9a170e37fbe7..9cc849f829d0 100644 --- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c @@ -1086,7 +1086,6 @@ static int gmc_v8_0_sw_init(void *handle) */ adev->need_dma32 = false; dma_bits = adev->need_dma32 ? 32 : 40; - adev->need_swiotlb = drm_get_max_iomem() > ((u64)1 << dma_bits); r = pci_set_dma_mask(adev->pdev, DMA_BIT_MASK(dma_bits)); if (r) { adev->need_dma32 = true;