| Message ID | 20180308001333.rI2vrNRTY%akpm@linux-foundation.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 07 Mar 2018, akpm@linux-foundation.org wrote: > From: Andrew Morton <akpm@linux-foundation.org> > Subject: drivers/gpu/drm/i915/intel_guc_log.c: work around gcc-4.4.4 union initializer issue > > gcc-4.4.4 has problems with initalizers of anon unions. > > drivers/gpu/drm/i915/intel_guc_log.c: In function 'guc_log_control': > drivers/gpu/drm/i915/intel_guc_log.c:64: error: unknown field 'logging_enabled' specified in initializer > > Work around this. Thanks for the patch, pushed to drm-intel-next-queued. That said, how long do we have to care about old compilers? I thought we were converging on at the very least GCC 4.5 being required. BR, Jani. > > Fixes: 35fe703c3161 ("drm/i915/guc: Change values for i915_guc_log_control") > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> > Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > --- > > drivers/gpu/drm/i915/intel_guc_log.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff -puN drivers/gpu/drm/i915/intel_guc_log.c~drivers-gpu-drm-i915-intel_guc_logc-work-around-gcc-444-union-initializer-issue drivers/gpu/drm/i915/intel_guc_log.c > --- a/drivers/gpu/drm/i915/intel_guc_log.c~drivers-gpu-drm-i915-intel_guc_logc-work-around-gcc-444-union-initializer-issue > +++ a/drivers/gpu/drm/i915/intel_guc_log.c > @@ -61,8 +61,10 @@ static int guc_log_flush(struct intel_gu > static int guc_log_control(struct intel_guc *guc, bool enable, u32 verbosity) > { > union guc_log_control control_val = { > - .logging_enabled = enable, > - .verbosity = verbosity, > + { > + .logging_enabled = enable, > + .verbosity = verbosity, > + }, > }; > u32 action[] = { > INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING, > _ > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, 08 Mar 2018 12:06:46 +0200 Jani Nikula <jani.nikula@linux.intel.com> wrote: > On Wed, 07 Mar 2018, akpm@linux-foundation.org wrote: > > From: Andrew Morton <akpm@linux-foundation.org> > > Subject: drivers/gpu/drm/i915/intel_guc_log.c: work around gcc-4.4.4 union initializer issue > > > > gcc-4.4.4 has problems with initalizers of anon unions. > > > > drivers/gpu/drm/i915/intel_guc_log.c: In function 'guc_log_control': > > drivers/gpu/drm/i915/intel_guc_log.c:64: error: unknown field 'logging_enabled' specified in initializer > > > > Work around this. > > Thanks for the patch, pushed to drm-intel-next-queued. > > That said, how long do we have to care about old compilers? I thought we > were converging on at the very least GCC 4.5 being required. Yes, I've seen some talk about that and it is about time for us to do it. I'm not sure what stage things are at though.
diff -puN drivers/gpu/drm/i915/intel_guc_log.c~drivers-gpu-drm-i915-intel_guc_logc-work-around-gcc-444-union-initializer-issue drivers/gpu/drm/i915/intel_guc_log.c --- a/drivers/gpu/drm/i915/intel_guc_log.c~drivers-gpu-drm-i915-intel_guc_logc-work-around-gcc-444-union-initializer-issue +++ a/drivers/gpu/drm/i915/intel_guc_log.c @@ -61,8 +61,10 @@ static int guc_log_flush(struct intel_gu static int guc_log_control(struct intel_guc *guc, bool enable, u32 verbosity) { union guc_log_control control_val = { - .logging_enabled = enable, - .verbosity = verbosity, + { + .logging_enabled = enable, + .verbosity = verbosity, + }, }; u32 action[] = { INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING,