From patchwork Sun Mar 11 22:32:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 10277905 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6F45E6038F for ; Tue, 13 Mar 2018 08:34:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7028C284C9 for ; Tue, 13 Mar 2018 08:34:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6501928674; Tue, 13 Mar 2018 08:34:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 216E7284C9 for ; Tue, 13 Mar 2018 08:34:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0AAB66E403; Tue, 13 Mar 2018 08:33:55 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from smtp.smtpout.orange.fr (smtp02.smtpout.orange.fr [80.12.242.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 660946E0DA for ; Sun, 11 Mar 2018 22:32:13 +0000 (UTC) Received: from linux.numericable.fr ([77.198.79.136]) by mwinf5d55 with ME id LmY51x00Y2wTeBR03mY6sq; Sun, 11 Mar 2018 23:32:11 +0100 X-ME-Helo: linux.numericable.fr X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 11 Mar 2018 23:32:11 +0100 X-ME-IP: 77.198.79.136 From: Christophe JAILLET To: shawnguo@kernel.org, airlied@linux.ie Subject: [PATCH] drm: zte: Fix an error handling path in 'zx_crtc_bind()' Date: Sun, 11 Mar 2018 23:32:03 +0100 Message-Id: <20180311223203.3669-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-Antivirus: Avast (VPS 180311-2, 11/03/2018), Outbound message X-Antivirus-Status: Clean X-Mailman-Approved-At: Tue, 13 Mar 2018 08:33:45 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe JAILLET , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP 'ret' is known to be 0 at this point. It must be updated by the value returned by 'clk_prepare_enable()'. Fixes: 0a886f59528a ("drm: zte: add initial vou drm driver") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/zte/zx_vou.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/zte/zx_vou.c b/drivers/gpu/drm/zte/zx_vou.c index 7491813131f3..3351b258ed7a 100644 --- a/drivers/gpu/drm/zte/zx_vou.c +++ b/drivers/gpu/drm/zte/zx_vou.c @@ -838,7 +838,7 @@ static int zx_crtc_bind(struct device *dev, struct device *master, void *data) return ret; } - clk_prepare_enable(vou->ppu_clk); + ret = clk_prepare_enable(vou->ppu_clk); if (ret) { DRM_DEV_ERROR(dev, "failed to enable ppu_clk: %d\n", ret); goto disable_axi_clk;