From patchwork Wed Mar 14 20:23:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Lengfeld X-Patchwork-Id: 10283549 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 357116063C for ; Wed, 14 Mar 2018 20:41:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2183728514 for ; Wed, 14 Mar 2018 20:41:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14150285A4; Wed, 14 Mar 2018 20:41:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 478BC28514 for ; Wed, 14 Mar 2018 20:41:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE6366E756; Wed, 14 Mar 2018 20:41:56 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 1123 seconds by postgrey-1.36 at gabe; Wed, 14 Mar 2018 20:41:55 UTC Received: from stcim.de (stcim.de [IPv6:2a01:4f8:120:63a3::2]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C1236E756 for ; Wed, 14 Mar 2018 20:41:55 +0000 (UTC) Received: from 2a0a-a542-c308-0-a288-b4ff-fee5-f5cc.ipv6dyn.netcologne.de ([2a0a:a542:c308:0:a288:b4ff:fee5:f5cc] helo=localhost.localdomain) by stcim with esmtpsa (TLS1.2:DHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ewCvW-0006qL-RA; Wed, 14 Mar 2018 21:23:11 +0100 From: Stefan Lengfeld To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/3] drm/hisilicon: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops Date: Wed, 14 Mar 2018 21:23:08 +0100 Message-Id: <20180314202309.2874-3-contact@stefanchrist.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180314202309.2874-1-contact@stefanchrist.eu> References: <20180314202309.2874-1-contact@stefanchrist.eu> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rongrong Zou , Xinliang Liu MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Small refactoring. Use the helper define DRM_FB_HELPER_DEFAULT_OPS that provides the default implementations of the drm_fb_helper functions for struct fb_ops. Now the driver implements three additional members of the struct fb_ops: .fb_debug_enter = drm_fb_helper_debug_enter, .fb_debug_leave = drm_fb_helper_debug_leave, .fb_ioctl = drm_fb_helper_ioctl These changes are not tested. Cc: Rongrong Zou Cc: Xinliang Liu Signed-off-by: Stefan Lengfeld --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c index b92595c477ef..b18b20535cff 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c @@ -43,14 +43,10 @@ static int hibmcfb_create_object( static struct fb_ops hibmc_drm_fb_ops = { .owner = THIS_MODULE, - .fb_check_var = drm_fb_helper_check_var, - .fb_set_par = drm_fb_helper_set_par, + DRM_FB_HELPER_DEFAULT_OPS, .fb_fillrect = drm_fb_helper_sys_fillrect, .fb_copyarea = drm_fb_helper_sys_copyarea, .fb_imageblit = drm_fb_helper_sys_imageblit, - .fb_pan_display = drm_fb_helper_pan_display, - .fb_blank = drm_fb_helper_blank, - .fb_setcmap = drm_fb_helper_setcmap, }; static int hibmc_drm_fb_create(struct drm_fb_helper *helper,