From patchwork Wed Mar 14 20:23:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Lengfeld X-Patchwork-Id: 10283553 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5BEB660621 for ; Wed, 14 Mar 2018 20:42:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 48AF728514 for ; Wed, 14 Mar 2018 20:42:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3CCBF285A4; Wed, 14 Mar 2018 20:42:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EC37828514 for ; Wed, 14 Mar 2018 20:42:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A47E96E760; Wed, 14 Mar 2018 20:42:06 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from stcim.de (stcim.de [IPv6:2a01:4f8:120:63a3::2]) by gabe.freedesktop.org (Postfix) with ESMTPS id C57546E75D for ; Wed, 14 Mar 2018 20:42:00 +0000 (UTC) Received: from 2a0a-a542-c308-0-a288-b4ff-fee5-f5cc.ipv6dyn.netcologne.de ([2a0a:a542:c308:0:a288:b4ff:fee5:f5cc] helo=localhost.localdomain) by stcim with esmtpsa (TLS1.2:DHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ewCvX-0006qL-92; Wed, 14 Mar 2018 21:23:11 +0100 From: Stefan Lengfeld To: dri-devel@lists.freedesktop.org Subject: [PATCH 3/3] drm/mgag200: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops Date: Wed, 14 Mar 2018 21:23:09 +0100 Message-Id: <20180314202309.2874-4-contact@stefanchrist.eu> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180314202309.2874-1-contact@stefanchrist.eu> References: <20180314202309.2874-1-contact@stefanchrist.eu> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Small refactoring. Use the helper define DRM_FB_HELPER_DEFAULT_OPS that provides the default implementations of the drm_fb_helper functions for struct fb_ops. Now the driver implements three additional members of the struct fb_ops: .fb_debug_enter = drm_fb_helper_debug_enter, .fb_debug_leave = drm_fb_helper_debug_leave, .fb_ioctl = drm_fb_helper_ioctl These changes are not tested. Cc: Dave Airlie Signed-off-by: Stefan Lengfeld --- drivers/gpu/drm/mgag200/mgag200_fb.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200/mgag200_fb.c index 30726c9fe28c..e02c11b6d27d 100644 --- a/drivers/gpu/drm/mgag200/mgag200_fb.c +++ b/drivers/gpu/drm/mgag200/mgag200_fb.c @@ -125,14 +125,10 @@ static void mga_imageblit(struct fb_info *info, static struct fb_ops mgag200fb_ops = { .owner = THIS_MODULE, - .fb_check_var = drm_fb_helper_check_var, - .fb_set_par = drm_fb_helper_set_par, + DRM_FB_HELPER_DEFAULT_OPS, .fb_fillrect = mga_fillrect, .fb_copyarea = mga_copyarea, .fb_imageblit = mga_imageblit, - .fb_pan_display = drm_fb_helper_pan_display, - .fb_blank = drm_fb_helper_blank, - .fb_setcmap = drm_fb_helper_setcmap, }; static int mgag200fb_create_object(struct mga_fbdev *afbdev,