From patchwork Sun Mar 18 21:51:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arushi X-Patchwork-Id: 10291411 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8BCD860291 for ; Sun, 18 Mar 2018 21:51:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 60C2B28567 for ; Sun, 18 Mar 2018 21:51:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 52B9828D23; Sun, 18 Mar 2018 21:51:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0350428567 for ; Sun, 18 Mar 2018 21:51:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 07A646E294; Sun, 18 Mar 2018 21:51:53 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35C096E294; Sun, 18 Mar 2018 21:51:52 +0000 (UTC) Received: by mail-pf0-x241.google.com with SMTP id 123so496501pfe.0; Sun, 18 Mar 2018 14:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=JntWGuaqDI0hzwgZPo1rkEoUod1o9UwXPTEOmmqXQCo=; b=nkKt+6p3N8Fidmzx67FAgcqq4S+oNaFP3LNsjKT8bVp+Jb/uwUy+c5PUa9iCTdHGbr Z2Vrx7fv49FWebImNYGVMhoS6pSwF/0Ce2Ach4exYcsQTR3VxE41SSsw4HaXcLqqeJTI sSMEX3Kl0zGQBiBXxm3/HwRKXxspaGr54EAiWv7m/fT+TlqTJM54qTimKIWC4aRIFqeb qlY72kkcnw5YnNQY4n5/P/y/d3Arpn1Eyv5prLlD5LnOpL0lWxb7BtvkysbYaiaC2ovJ 5rBahiXxgmXxhoY0L/ZuPxZpiJ2aZFOl3Wl8IwGtBPJ8lIohv+j8OrULt2Q18fvWrV6z 65Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=JntWGuaqDI0hzwgZPo1rkEoUod1o9UwXPTEOmmqXQCo=; b=mt0VnFLKtCB8087/WI4efSNZAlJl+q29u/4a2WFS1IbmQuRTMXH3yVJTU4/SsmIypM Bw3xUw+jmLRts16P0OVsW4oHVye5eWXzc5Ecy6/DIbwuQ9+VA5mPKZMC3tj2r8442GM6 lCD2Z3B5k5Apysn0qrzGegA9N0J2RWaxKDVmJ7sso4VtkgGix+LnQAfQ8drC2qIpA13U epk4grU+6q/dTlD5p2UddP9IJEoRiiUn5GxSK1/IeSJ3DRxKD+lm4bqWp9IxA4zTbRYR BcsDorrropQKMMClYyqA6vTtdqwf5jSH5PsBcxG378n1zGbhCaL64t9JbS95hU8WXHVK YoxA== X-Gm-Message-State: AElRT7Exf/f27YomJOB7KwLyFcJJa5U6V68+G/0vGcQ3Jowhi7XqGc+T KsKe2g+EWfVuKpgmXXbJGj0= X-Google-Smtp-Source: AG47ELt6VzO7pKaZkaXWEQrjOclgeVW68UZbN6XWD3nd4+EvhuifwjW9Q/6XS74LdSWeI9CMmA587Q== X-Received: by 10.98.7.68 with SMTP id b65mr8204384pfd.39.1521409911473; Sun, 18 Mar 2018 14:51:51 -0700 (PDT) Received: from seema-Inspiron-15-3567 ([14.139.82.6]) by smtp.gmail.com with ESMTPSA id s75sm24318181pfj.43.2018.03.18.14.51.49 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Mar 2018 14:51:50 -0700 (PDT) Date: Mon, 19 Mar 2018 03:21:05 +0530 From: Arushi Singhal To: alexander.deucher@amd.com Subject: [PATCH] gpu: drm: Use list_first_entry instead of list_entry Message-ID: <20180318215105.GA15431@seema-Inspiron-15-3567> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, outreachy-kernel@googlegroups.com, Tomi Valkeinen , amd-gfx@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch replaces list_entry with list_first_entry as it makes the code more clear. Done using coccinelle: @@ expression e; @@ ( - list_entry(e->next, + list_first_entry(e, ...) | - list_entry(e->prev, + list_last_entry(e, ...) ) Signed-off-by: Arushi Singhal --- drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c | 4 ++-- drivers/gpu/drm/omapdrm/dss/display.c | 4 ++-- drivers/gpu/drm/radeon/radeon_sa.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c index 3144400..646f593 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c @@ -158,7 +158,7 @@ static void amdgpu_sa_bo_try_free(struct amdgpu_sa_manager *sa_manager) if (sa_manager->hole->next == &sa_manager->olist) return; - sa_bo = list_entry(sa_manager->hole->next, struct amdgpu_sa_bo, olist); + sa_bo = list_first_entry(sa_manager->hole, struct amdgpu_sa_bo, olist); list_for_each_entry_safe_from(sa_bo, tmp, &sa_manager->olist, olist) { if (sa_bo->fence == NULL || !dma_fence_is_signaled(sa_bo->fence)) { @@ -183,7 +183,7 @@ static inline unsigned amdgpu_sa_bo_hole_eoffset(struct amdgpu_sa_manager *sa_ma struct list_head *hole = sa_manager->hole; if (hole->next != &sa_manager->olist) { - return list_entry(hole->next, struct amdgpu_sa_bo, olist)->soffset; + return list_first_entry(hole, struct amdgpu_sa_bo, olist)->soffset; } return sa_manager->size; } diff --git a/drivers/gpu/drm/omapdrm/dss/display.c b/drivers/gpu/drm/omapdrm/dss/display.c index 0c9480b..fb9ecae 100644 --- a/drivers/gpu/drm/omapdrm/dss/display.c +++ b/drivers/gpu/drm/omapdrm/dss/display.c @@ -158,8 +158,8 @@ struct omap_dss_device *omap_dss_get_next_device(struct omap_dss_device *from) goto out; } - dssdev = list_entry(l->next, struct omap_dss_device, - panel_list); + dssdev = list_first_entry(l, struct omap_dss_device, + panel_list); omap_dss_get_device(dssdev); goto out; } diff --git a/drivers/gpu/drm/radeon/radeon_sa.c b/drivers/gpu/drm/radeon/radeon_sa.c index 197b157..66c0482 100644 --- a/drivers/gpu/drm/radeon/radeon_sa.c +++ b/drivers/gpu/drm/radeon/radeon_sa.c @@ -158,7 +158,7 @@ static void radeon_sa_bo_try_free(struct radeon_sa_manager *sa_manager) if (sa_manager->hole->next == &sa_manager->olist) return; - sa_bo = list_entry(sa_manager->hole->next, struct radeon_sa_bo, olist); + sa_bo = list_first_entry(sa_manager->hole, struct radeon_sa_bo, olist); list_for_each_entry_safe_from(sa_bo, tmp, &sa_manager->olist, olist) { if (sa_bo->fence == NULL || !radeon_fence_signaled(sa_bo->fence)) { return; @@ -182,7 +182,7 @@ static inline unsigned radeon_sa_bo_hole_eoffset(struct radeon_sa_manager *sa_ma struct list_head *hole = sa_manager->hole; if (hole->next != &sa_manager->olist) { - return list_entry(hole->next, struct radeon_sa_bo, olist)->soffset; + return list_first_entry(hole, struct radeon_sa_bo, olist)->soffset; } return sa_manager->size; }