From patchwork Tue Mar 20 13:37:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haneen Mohammed X-Patchwork-Id: 10302451 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5CF4660349 for ; Thu, 22 Mar 2018 22:07:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 43B1E287E9 for ; Thu, 22 Mar 2018 22:07:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 385BA28A0F; Thu, 22 Mar 2018 22:07:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E3DE9287E9 for ; Thu, 22 Mar 2018 22:07:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 069286EC79; Thu, 22 Mar 2018 22:05:30 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qt0-x241.google.com (mail-qt0-x241.google.com [IPv6:2607:f8b0:400d:c0d::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C3E66E757 for ; Tue, 20 Mar 2018 13:37:55 +0000 (UTC) Received: by mail-qt0-x241.google.com with SMTP id h4so1549633qtn.13 for ; Tue, 20 Mar 2018 06:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=CUFWiS4/LC2KfB9CuDf9icYvrby1qUG8dPwuex9gac4=; b=t6AghNPua+RjtLJ5GrpckpKgxy0szbtvQJ+au0Eg4Wra0DN5381z6ZqE4uqET/5+vK ZveQ4bD4s8IFUc17yqBPVThEBqDf1TSS/63O7XmOmTLAL6cQLvxaknyELaiz3o1uNr9l RFu1D1v86hS2E5bopP1b2PZZ+RFtuYXtcnnowhPwlV+EeNV8yYgQJ/1+oXYaimG+JetN zf91Lg/1/DXr2r+jg6Dk0hJuxA04euDxlAhB7GqnwUhLlwQNiPpEwKKKLfsjhJkPr/Nb DKa88FjHYtB6oAJnEButJ4gijmonDsCTlvik1EcbnOPMj9q7GsDhpi83bo6YgdwgztoP Z5EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=CUFWiS4/LC2KfB9CuDf9icYvrby1qUG8dPwuex9gac4=; b=LqUHlHyx60N8AsHfeHqvB2SvLtWzUrpVjZa99ymMAV82IJIGBUKJbvKFGzGORK7Ypd VRieTzTsqeP9fOflXofsA6mNvy622lWLJB2j/ZF8L/zQC6RmKkCU4myiGlvLxhbzD/wA AWDVh+0XECVZZQkMMHN5Jz5dhXPCFyV77O6RRpAdhG2QbgRLrBGZWzsC9o27Y7TC8B9I Isd6vDpKWEawibKQGXiyLNvIHGggiMedqw93HFkNP1SCIFWD6/oBxPV2IutRSwK0mlj0 10p4TVilChgUxwRYztT2H3DrdjBMzt5Ck97Bgxg1KwMc7gDPDXP2EtCTe1IZKrN5WQGy o8hA== X-Gm-Message-State: AElRT7HHmacM6n5phX0h38L4pettepN4zhsiRVebA5qOuzd3WEW6873v hgKo/qNfXbN5YRt3YFqfu/M= X-Google-Smtp-Source: AG47ELt+PK4Gtr+afOTab6WQQr0uHSHDtzipqsywlGb8pFVNq/JaJUK+ehw4PB86FEAliR9Xtl0Utg== X-Received: by 10.200.56.76 with SMTP id r12mr25206455qtb.125.1521553074140; Tue, 20 Mar 2018 06:37:54 -0700 (PDT) Received: from haneen-VirtualBox (nat-128-84-124-0-57.cit.cornell.edu. [128.84.124.57]) by smtp.gmail.com with ESMTPSA id e30sm1261172qtg.1.2018.03.20.06.37.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Mar 2018 06:37:53 -0700 (PDT) Date: Tue, 20 Mar 2018 09:37:49 -0400 From: Haneen Mohammed To: hamohammed.sa@gmail.com Subject: [PATCH DRM] drm: Remove drm_property_{un/reference}_blob aliases Message-ID: <20180320133749.GA11695@haneen-VirtualBox> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Mailman-Approved-At: Thu, 22 Mar 2018 22:05:16 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: outreachy-kernel@googlegroups.com, Michal Marek , Gilles Muller , David Airlie , Nicolas Palix , dri-devel@lists.freedesktop.org, Julia Lawall , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch remove the compatibility aliases drm_property_{reference/unreference}_blob of drm_property_blob_{get/put} since all callers have been converted to the prefered _{get/put}. Remove the helpers from the semantic patch drm-get-put-cocci. Signed-off-by: Haneen Mohammed Acked-by: Julia Lawall --- include/drm/drm_property.h | 26 -------------------------- scripts/coccinelle/api/drm-get-put.cocci | 10 ---------- 2 files changed, 36 deletions(-) diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h index 8a522b4..08d5dbb 100644 --- a/include/drm/drm_property.h +++ b/include/drm/drm_property.h @@ -279,32 +279,6 @@ struct drm_property_blob *drm_property_blob_get(struct drm_property_blob *blob); void drm_property_blob_put(struct drm_property_blob *blob); /** - * drm_property_reference_blob - acquire a blob property reference - * @blob: DRM blob property - * - * This is a compatibility alias for drm_property_blob_get() and should not be - * used by new code. - */ -static inline struct drm_property_blob * -drm_property_reference_blob(struct drm_property_blob *blob) -{ - return drm_property_blob_get(blob); -} - -/** - * drm_property_unreference_blob - release a blob property reference - * @blob: DRM blob property - * - * This is a compatibility alias for drm_property_blob_put() and should not be - * used by new code. - */ -static inline void -drm_property_unreference_blob(struct drm_property_blob *blob) -{ - drm_property_blob_put(blob); -} - -/** * drm_property_find - find property object * @dev: DRM device * @file_priv: drm file to check for lease against. diff --git a/scripts/coccinelle/api/drm-get-put.cocci b/scripts/coccinelle/api/drm-get-put.cocci index ceb71ea..3a09c97 100644 --- a/scripts/coccinelle/api/drm-get-put.cocci +++ b/scripts/coccinelle/api/drm-get-put.cocci @@ -40,12 +40,6 @@ expression object; - drm_gem_object_unreference_unlocked(object) + drm_gem_object_put_unlocked(object) | -- drm_property_reference_blob(object) -+ drm_property_blob_get(object) -| -- drm_property_unreference_blob(object) -+ drm_property_blob_put(object) -| - drm_dev_unref(object) + drm_dev_put(object) ) @@ -72,10 +66,6 @@ __drm_gem_object_unreference(object) | drm_gem_object_unreference_unlocked(object) | -drm_property_unreference_blob@p(object) -| -drm_property_reference_blob@p(object) -| drm_dev_unref@p(object) )