From patchwork Thu Apr 5 15:44:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10324803 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0DA896053F for ; Thu, 5 Apr 2018 15:45:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F03C6292C5 for ; Thu, 5 Apr 2018 15:45:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E1691292C8; Thu, 5 Apr 2018 15:45:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6C9D5292C5 for ; Thu, 5 Apr 2018 15:45:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A52356E6D4; Thu, 5 Apr 2018 15:45:00 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0046C6E495 for ; Thu, 5 Apr 2018 15:44:58 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id u189so6935719wmd.1 for ; Thu, 05 Apr 2018 08:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SiOs2VALYXEE0HYIK/VfbIptpp5kP3vMnB/MY3Yzvbs=; b=EmRyZqvuDq00bst3cLLlkCJ3dUoyqUM2EFaP98NseZCmGN+PKONrBzIVXFaP+Z3NhF ST5shU+n3sgeegJab7KXC59OPYzeFBXju9yq8Q8+pC0wcrFjF2ADfSCusQwRuOcECyN1 CP8YIwYpZNrG+Gx1Y1ZXnW7/0nAn0VnaNobUA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SiOs2VALYXEE0HYIK/VfbIptpp5kP3vMnB/MY3Yzvbs=; b=ZY0AITRYe2FrClcONmrUdVEWNyB9j57Glg1O87AKCkFBZmw9HUceckSUHZiKg4gIAI Zf/KK/fQOccPcjSZf2qm3OdD1O0Vadmq+fuAUhy5sdB3x/Tj6+wag6QAYiIhD9Bu238c XL5WoW3EVHF2xrDe2oCxBXYiMRknUIGrJOL6HLBdl6gsb/iplAvPbwQ/t79PoRXuV5FQ AqxCq6WlkzyuxmnT/SJedU76tRoIqA1wTiMw3QN0poDFH+YxrheLgxmRFy4756pj40s5 nP7LdvDHwZ0U7A+oeguD9kVO8z9IgWDiJp+vYucSXSvtgrwBsJ79Q2qlruhxWQvdmwRM Frig== X-Gm-Message-State: ALQs6tBc98LMiU8tgz2qJm/wVhYsl2YB+kxUBDpuwNJO0fb4OBH1GxqY 6FdD3wiTU2fsaInzZQb1NIPQ16KZ X-Google-Smtp-Source: AIpwx4+7V2uvRxDK+T1Roj9et6PoDReb58d6e5ioDetEgA3FOKwKjhx37+x9C6pSN6K/9h/SM7oZqg== X-Received: by 10.80.145.246 with SMTP id h51mr3510537eda.124.1522943097467; Thu, 05 Apr 2018 08:44:57 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id i48sm4970247ede.39.2018.04.05.08.44.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Apr 2018 08:44:56 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 1/9] drm/vmwgfx: Remove no-op prepare/cleanup_fb callbacks Date: Thu, 5 Apr 2018 17:44:41 +0200 Message-Id: <20180405154449.23038-2-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180405154449.23038-1-daniel.vetter@ffwll.ch> References: <20180405154449.23038-1-daniel.vetter@ffwll.ch> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Thomas Hellstrom , VMware Graphics , Daniel Vetter MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Less hits to go through when I git grep over all drivers. These callbacks are optional. Signed-off-by: Daniel Vetter Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 35 ----------------------------------- 1 file changed, 35 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c index 3824595fece1..4a5907e3f560 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c @@ -281,39 +281,6 @@ drm_connector_helper_funcs vmw_ldu_connector_helper_funcs = { * Legacy Display Plane Functions */ -/** - * vmw_ldu_primary_plane_cleanup_fb - Noop - * - * @plane: display plane - * @old_state: Contains the FB to clean up - * - * Unpins the display surface - * - * Returns 0 on success - */ -static void -vmw_ldu_primary_plane_cleanup_fb(struct drm_plane *plane, - struct drm_plane_state *old_state) -{ -} - - -/** - * vmw_ldu_primary_plane_prepare_fb - Noop - * - * @plane: display plane - * @new_state: info on the new plane state, including the FB - * - * Returns 0 on success - */ -static int -vmw_ldu_primary_plane_prepare_fb(struct drm_plane *plane, - struct drm_plane_state *new_state) -{ - return 0; -} - - static void vmw_ldu_primary_plane_atomic_update(struct drm_plane *plane, struct drm_plane_state *old_state) @@ -373,8 +340,6 @@ static const struct drm_plane_helper_funcs vmw_ldu_primary_plane_helper_funcs = { .atomic_check = vmw_du_primary_plane_atomic_check, .atomic_update = vmw_ldu_primary_plane_atomic_update, - .prepare_fb = vmw_ldu_primary_plane_prepare_fb, - .cleanup_fb = vmw_ldu_primary_plane_cleanup_fb, }; static const struct drm_crtc_helper_funcs vmw_ldu_crtc_helper_funcs = {