From patchwork Thu Apr 5 19:32:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10325353 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BA14A60467 for ; Thu, 5 Apr 2018 20:37:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA7B629383 for ; Thu, 5 Apr 2018 20:37:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9E2A4293A0; Thu, 5 Apr 2018 20:37:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0A41229383 for ; Thu, 5 Apr 2018 20:37:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 501036E87B; Thu, 5 Apr 2018 20:37:06 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from osg.samsung.com (osg.samsung.com [64.30.133.232]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FFE56E359 for ; Thu, 5 Apr 2018 19:32:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id 43F4D3094E; Thu, 5 Apr 2018 12:32:33 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com Received: from osg.samsung.com ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U3yZUf3c18g6; Thu, 5 Apr 2018 12:32:31 -0700 (PDT) Received: from vento.lan (unknown [177.133.19.105]) by osg.samsung.com (Postfix) with ESMTPSA id 0F19430940; Thu, 5 Apr 2018 12:32:29 -0700 (PDT) Date: Thu, 5 Apr 2018 16:32:26 -0300 From: Mauro Carvalho Chehab To: Laurent Pinchart Subject: Re: [PATCH 15/16] media: omapfb_dss.h: add stubs to build with COMPILE_TEST Message-ID: <20180405163226.0700c519@vento.lan> In-Reply-To: <1527912.68v46ENJLK@avalon> References: <1527912.68v46ENJLK@avalon> Organization: Samsung X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 05 Apr 2018 20:37:03 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartlomiej Zolnierkiewicz , Mauro Carvalho Chehab , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Linux Media Mailing List Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Em Thu, 05 Apr 2018 21:41:18 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Thursday, 5 April 2018 20:54:15 EEST Mauro Carvalho Chehab wrote: > > Add stubs for omapfb_dss.h, in the case it is included by > > some driver when CONFIG_FB_OMAP2 is not defined. > > The omapfb driver doesn't include any asm/ header, so it should probably build > fine on non-ARM architectures. Instead of adding stubs here, you can enable > compilation of the driver on all platforms, in which case the omap_vout driver > could keep depending on FB_OMAP2 as it should. True. The patch for that is simple. Patch enclosed. Please notice that, now with W=1, several new warnings will popup. I'll let to the others to touch there, as I don't have any clue about what's there under omapfb. Those are the new warnings: drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function ‘omapfb_setup_overlay’: drivers/video/fbdev/omap2/omapfb/omapfb-main.c:891:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (ofbi->rotation_type == OMAP_DSS_ROT_VRFB) { ^ drivers/video/fbdev/omap2/omapfb/omapfb-main.c:896:2: note: here default: ^~~~~~~ drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c: In function ‘tpd_probe’: drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c:221:26: warning: variable ‘in’ set but not used [-Wunused-but-set-variable] struct omap_dss_device *in, *dssdev; ^~ drivers/video/fbdev/omap2/omapfb/dss/dispc.c: In function ‘calc_vrfb_rotation_offset’: drivers/video/fbdev/omap2/omapfb/dss/dispc.c:1905:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (color_mode == OMAP_DSS_COLOR_YUV2 || ^ drivers/video/fbdev/omap2/omapfb/dss/dispc.c:1908:2: note: here case OMAP_DSS_ROT_90: ^~~~ drivers/video/fbdev/omap2/omapfb/dss/dispc.c:1927:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (color_mode == OMAP_DSS_COLOR_YUV2 || ^ drivers/video/fbdev/omap2/omapfb/dss/dispc.c:1930:2: note: here case OMAP_DSS_ROT_90 + 4: ^~~~ drivers/video/fbdev/omap2/omapfb/dss/venc.c:223:33: warning: ‘venc_config_pal_bdghi’ defined but not used [-Wunused-const-variable=] static const struct venc_config venc_config_pal_bdghi = { ^~~~~~~~~~~~~~~~~~~~~ drivers/video/fbdev/omap2/omapfb/dss/dsi.c: In function ‘_dsi_print_reset_status’: drivers/video/fbdev/omap2/omapfb/dss/dsi.c:1189:6: warning: variable ‘l’ set but not used [-Wunused-but-set-variable] u32 l; ^ drivers/video/fbdev/omap2/omapfb/dss/dsi.c: In function ‘dsi_proto_timings’: drivers/video/fbdev/omap2/omapfb/dss/dsi.c:3638:42: warning: variable ‘tclk_trail’ set but not used [-Wunused-but-set-variable] unsigned tlpx, tclk_zero, tclk_prepare, tclk_trail; ^~~~~~~~~~ drivers/video/fbdev/omap2/omapfb/dss/dsi.c: In function ‘dsi_update’: drivers/video/fbdev/omap2/omapfb/dss/dsi.c:4051:10: warning: variable ‘dh’ set but not used [-Wunused-but-set-variable] u16 dw, dh; ^~ drivers/video/fbdev/omap2/omapfb/dss/dsi.c:4051:6: warning: variable ‘dw’ set but not used [-Wunused-but-set-variable] u16 dw, dh; ^~ drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c: In function ‘hdmi4_audio_config’: drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c:693:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] int err, n, cts, channel_count; ^~~ drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c: In function ‘hdmi5_audio_config’: drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c:804:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] int err, n, cts, channel_count; ^~~ Thanks, Mauro --- [PATCH] omap2: omapfb: allow building it with COMPILE_TEST This driver builds cleanly with COMPILE_TEST, and it is needed in order to allow building drivers/media omap2 driver. So, change the logic there to allow building it. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/video/fbdev/omap2/Kconfig b/drivers/video/fbdev/omap2/Kconfig index 0921c4de8407..82008699d253 100644 --- a/drivers/video/fbdev/omap2/Kconfig +++ b/drivers/video/fbdev/omap2/Kconfig @@ -1,4 +1,4 @@ -if ARCH_OMAP2PLUS +if ARCH_OMAP2PLUS || COMPILE_TEST source "drivers/video/fbdev/omap2/omapfb/Kconfig"