From patchwork Fri Apr 20 11:25:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 10354045 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 73DB060231 for ; Sat, 21 Apr 2018 10:55:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B6992890E for ; Sat, 21 Apr 2018 10:55:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 500B728915; Sat, 21 Apr 2018 10:55:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CE97A2890E for ; Sat, 21 Apr 2018 10:55:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 967A06E2F9; Sat, 21 Apr 2018 10:55:04 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAB686E230 for ; Fri, 20 Apr 2018 11:25:59 +0000 (UTC) Received: by mail-lf0-x243.google.com with SMTP id d79-v6so4683735lfd.0 for ; Fri, 20 Apr 2018 04:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XWBFie2sVJrLaZgwPIc7qPl63da3nJKsukd+0etsuJU=; b=WtccWvoc2tyusyDa5M+TlgsVC5kpF6PM/bF0+3dShCKyORzEgtr9VL820mQRAJxaVL /lFBAnSkSNeuep9xcb75ElXvYKNBMopRSsQh3e+8PCt04TgVj8ZmjyzrvfhVMMpwzxXQ tQKoAgR2K6053iIV+fl1r35ZW8zKrun/Zq+GY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XWBFie2sVJrLaZgwPIc7qPl63da3nJKsukd+0etsuJU=; b=f9SQF7dDwd8c6+eVJ4Tm4HJPZjDVoOZWc3Sc8z9F8FuAZC6r4nyXqLr+d9qbk2huXU XXwW0gewhwiibuDihLSlojtSqBX0BRJ3QVarkU8Zxjpi6scgRXWtyufciwd4wjq173Yf Pvwl9rxGf6Tpi9ifMV0sM46H1r8Go1mY3kRuFYW58AH7D+GXxmh9dHx4OuqSFRUbUwUd vsflgNlP2PL56nRlh+w0XApoyZWtxK/wPIa23RKH7JzkjhLnzrsS/WfS3DXOMHxUjwhz ksRy4aS5uk9dWA1GAFsrYXPgYFywFhCMUQPHB5+WsPPHToCPS/79BDz3/S0TTjYBECYA Pkeg== X-Gm-Message-State: ALQs6tB+/vfX04dmTVM9ZpGJwUHVRLc3nrC9rY8QNpeuDKFKsgkrEMJC lEHQhMPJmZWr1vxuOx5UmORBZw== X-Google-Smtp-Source: AIpwx49Q8FzJNtivl6iIFJpakQW1Y51ojg2hkXMMFUSqiOP8t8luJfXDTsfGD1c7K3LlQtBUQv/uqw== X-Received: by 10.46.69.5 with SMTP id s5mr4818169lja.41.1524223558075; Fri, 20 Apr 2018 04:25:58 -0700 (PDT) Received: from localhost (c-2c3d70d5.07-21-73746f28.cust.bredbandsbolaget.se. [213.112.61.44]) by smtp.gmail.com with ESMTPSA id 76-v6sm1290312lfq.70.2018.04.20.04.25.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Apr 2018 04:25:57 -0700 (PDT) From: Anders Roxell To: tomi.valkeinen@ti.com, b.zolnierkie@samsung.com Subject: [PATCH] drivers: omap2: Kconfig: make FB_OMAP2_DSS_INIT depend on OF Date: Fri, 20 Apr 2018 13:25:51 +0200 Message-Id: <20180420112551.27027-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 X-Mailman-Approved-At: Sat, 21 Apr 2018 10:54:48 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, Anders Roxell , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Commit 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST") broke compilation without CONFIG_OF selected. CC drivers/video/fbdev/core/fbmem.o drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c: In function ‘omapdss_update_prop’: drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c:68:2: error: implicit declaration of function ‘of_update_property’; did you mean ‘of_get_property’? [-Werror=implicit-function-declaration] of_update_property(node, prop); ^~~~~~~~~~~~~~~~~~ of_get_property cc1: some warnings being treated as errors scripts/Makefile.build:312: recipe for target 'drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.o' failed make[7]: *** [drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.o] Error 1 scripts/Makefile.build:559: recipe for target 'drivers/video/fbdev/omap2/omapfb/dss' failed make[6]: *** [drivers/video/fbdev/omap2/omapfb/dss] Error 2 make[6]: *** Waiting for unfinished jobs.... Add OF dependency in order to make all configurations work again. of_update_property() has no inline stub, and that that could be added as an alternative. Signed-off-by: Anders Roxell Acked-by: Randy Dunlap Tested-by: Randy Dunlap Acked-by: Mauro Carvalho Chehab Acked-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/omap2/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/omap2/Kconfig b/drivers/video/fbdev/omap2/Kconfig index 82008699d253..4de381f2452e 100644 --- a/drivers/video/fbdev/omap2/Kconfig +++ b/drivers/video/fbdev/omap2/Kconfig @@ -1,4 +1,4 @@ -if ARCH_OMAP2PLUS || COMPILE_TEST +if OF && (ARCH_OMAP2PLUS || COMPILE_TEST) source "drivers/video/fbdev/omap2/omapfb/Kconfig"