| Message ID | 20180426135853.30895-1-thierry.reding@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Apr 26, 2018 at 03:58:53PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Building the driver in a configuration with !PM currently causes a > warning about these operations being unused. Mark them as such to shut > up the compiler. > > Signed-off-by: Thierry Reding <treding@nvidia.com> I'd so love if we could use LTO (or at least link time garbage collection of functions/heap allocations) instead of tons of #ifdef (even in macros) and __maybe_unused. Patch looks fine itself. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/bridge/cdns-dsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c > index c255fc3e1be5..f2d43f24acfb 100644 > --- a/drivers/gpu/drm/bridge/cdns-dsi.c > +++ b/drivers/gpu/drm/bridge/cdns-dsi.c > @@ -1337,7 +1337,7 @@ static const struct mipi_dsi_host_ops cdns_dsi_ops = { > .transfer = cdns_dsi_transfer, > }; > > -static int cdns_dsi_resume(struct device *dev) > +static int __maybe_unused cdns_dsi_resume(struct device *dev) > { > struct cdns_dsi *dsi = dev_get_drvdata(dev); > > @@ -1350,7 +1350,7 @@ static int cdns_dsi_resume(struct device *dev) > return 0; > } > > -static int cdns_dsi_suspend(struct device *dev) > +static int __maybe_unused cdns_dsi_suspend(struct device *dev) > { > struct cdns_dsi *dsi = dev_get_drvdata(dev); > > -- > 2.17.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, Apr 26, 2018 at 04:21:04PM +0200, Daniel Vetter wrote: > On Thu, Apr 26, 2018 at 03:58:53PM +0200, Thierry Reding wrote: > > From: Thierry Reding <treding@nvidia.com> > > > > Building the driver in a configuration with !PM currently causes a > > warning about these operations being unused. Mark them as such to shut > > up the compiler. > > > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > I'd so love if we could use LTO (or at least link time garbage collection > of functions/heap allocations) instead of tons of #ifdef (even in macros) > and __maybe_unused. I had discussed this with Arnd Bergmann a long time ago and neither of us could figure out a way to make that work in this case, so we agreed that __maybe_unused was the preferred way forward until somebody would figure out a better way. > Patch looks fine itself. > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Thanks, applied to drm-misc-next. Thierry
diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c index c255fc3e1be5..f2d43f24acfb 100644 --- a/drivers/gpu/drm/bridge/cdns-dsi.c +++ b/drivers/gpu/drm/bridge/cdns-dsi.c @@ -1337,7 +1337,7 @@ static const struct mipi_dsi_host_ops cdns_dsi_ops = { .transfer = cdns_dsi_transfer, }; -static int cdns_dsi_resume(struct device *dev) +static int __maybe_unused cdns_dsi_resume(struct device *dev) { struct cdns_dsi *dsi = dev_get_drvdata(dev); @@ -1350,7 +1350,7 @@ static int cdns_dsi_resume(struct device *dev) return 0; } -static int cdns_dsi_suspend(struct device *dev) +static int __maybe_unused cdns_dsi_suspend(struct device *dev) { struct cdns_dsi *dsi = dev_get_drvdata(dev);