From patchwork Fri May 4 13:37:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 10380461 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8BAAB6038F for ; Fri, 4 May 2018 13:37:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 79D1829457 for ; Fri, 4 May 2018 13:37:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E6032944E; Fri, 4 May 2018 13:37:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D51C92945E for ; Fri, 4 May 2018 13:37:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 509C96E88A; Fri, 4 May 2018 13:37:12 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35B8F6E88A for ; Fri, 4 May 2018 13:37:11 +0000 (UTC) Received: by mail-wr0-x244.google.com with SMTP id i14-v6so17965674wre.2 for ; Fri, 04 May 2018 06:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=caZjCrQRBDdM/1nwzAYWO+QpIY6+2SV3E0+b+5EJYLk=; b=VPUu6EVvK730mMy7zDeP32dqwRWwAXXezWlPYG7FhrEGK0t4xnPj+l2mHHgmeoyMbe fNmPlkLbARBav6dk02icO+6MIuk9O5uR3AfioeNHmH7gRTV5q7eByrMjK0cpzXwaykjz AAdEU8wmm6pkNkhRfDK55US5bnAcAqv8PK2NiC0k6I+NlOT8G3dyz/6SSujQfsInU6h7 0k0LivwbALdg/VP7gagfX3kXPeXesuauRr+SoTBrXJv4Oko46L02bKTCYmHACWu9c+Dr uN92rmBp9oSiUgCE/WddwZ7z+3QQRm5WjlqXAJEa07pIaeJn5WW1cph8M3g9AI2KOj6w 8umQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=caZjCrQRBDdM/1nwzAYWO+QpIY6+2SV3E0+b+5EJYLk=; b=fjIkoSP4CVeGsR0scepimW3LTPh/E66oRXPMqTvAmLE9p5FDPra4ARgV7UeeaPZ6wa q/tUjApNvyQENMbvSu1MrtszNulIPc5HR6n5phyruumMHWz522gVGYcgfb/6niKRi2dX WXvYK9kyVHDBKLQdQ6KchCjZcPaDbxo0cm3A5G4Ezhfagku89N/9e2B114hT2ZmnbZwg ANyNFQIwYTz4fIq1FjmqSgDryNnzf0XEq/XV8Du0/fD7rFIs5z5C03dhlaeqGDUQ0a2f YCdb//CMvH18bZB65cUYvsMvZPs/rTwv9DG8tWQX+nYBa2EIm9fk1sD8eIJYDqTTbzcE qD8w== X-Gm-Message-State: ALQs6tA1+O9z72PDqpJ6O15BE0KfD5/s4zcgKFtj+FuMblz31+LETAiH +xi8baU3+zKvNVw1Kj72cak= X-Google-Smtp-Source: AB8JxZrjB7yo7MFw6aDc7yiwCHhFLZYPOq0Erd2ZXJ1xy5m/kOi+dBzce3ffhWV4ITG8xEgNt3WT1Q== X-Received: by 2002:adf:9444:: with SMTP id 62-v6mr20836919wrq.264.1525441029710; Fri, 04 May 2018 06:37:09 -0700 (PDT) Received: from localhost (p200300E41F041C0032947E635CB49D15.dip0.t-ipconnect.de. [2003:e4:1f04:1c00:3294:7e63:5cb4:9d15]) by smtp.gmail.com with ESMTPSA id z18-v6sm21338002wrc.36.2018.05.04.06.37.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 May 2018 06:37:09 -0700 (PDT) From: Thierry Reding To: Thierry Reding Subject: [PATCH 1/4] drm/tegra: dc: Free syncpoint on errors Date: Fri, 4 May 2018 15:37:04 +0200 Message-Id: <20180504133707.22451-1-thierry.reding@gmail.com> X-Mailer: git-send-email 2.17.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Dmitry Osipenko , dri-devel@lists.freedesktop.org MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Thierry Reding If an error happens during display controller initialization, the host1x syncpoint previously requested would be leaked. Properly clean up the syncpoint along with the other resources. Signed-off-by: Thierry Reding Reviewed-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/dc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index f20648f58e49..c843f11043db 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -1925,6 +1925,8 @@ static int tegra_dc_init(struct host1x_client *client) iommu_group_put(dc->group); } + host1x_syncpt_free(dc->syncpt); + return err; }