From patchwork Wed May 23 10:15:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 10420895 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 01CCB6032A for ; Wed, 23 May 2018 10:16:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E58BF28E9A for ; Wed, 23 May 2018 10:16:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D9B8328EC7; Wed, 23 May 2018 10:16:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DF9E628E9A for ; Wed, 23 May 2018 10:16:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F6416E43F; Wed, 23 May 2018 10:16:11 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id DECEC6E43A for ; Wed, 23 May 2018 10:16:09 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180523101607euoutp01e84c5d87509d4439cdfba2a0adeffad8~xPpciaXzS0945309453euoutp01v; Wed, 23 May 2018 10:16:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180523101607euoutp01e84c5d87509d4439cdfba2a0adeffad8~xPpciaXzS0945309453euoutp01v Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180523101606eucas1p2b69b9e67ef26a45a780d624960c9b244~xPpbiCLGz1470714707eucas1p2h; Wed, 23 May 2018 10:16:06 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 0E.E3.05700.66F350B5; Wed, 23 May 2018 11:16:06 +0100 (BST) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180523101605eucas1p1674542a34da0a42bc319299262d5d596~xPpa2ru2i0450804508eucas1p1W; Wed, 23 May 2018 10:16:05 +0000 (GMT) X-AuditID: cbfec7f2-1dbff70000011644-85-5b053f6668cd Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id F9.C8.04178.56F350B5; Wed, 23 May 2018 11:16:05 +0100 (BST) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P96001IPF6OP040@eusync1.samsung.com>; Wed, 23 May 2018 11:16:05 +0100 (BST) From: Marek Szyprowski To: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH] drm/exynos: Fix default value for zpos plane property Date: Wed, 23 May 2018 12:15:50 +0200 Message-id: <20180523101550.1448-1-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.17.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRmVeSWpSXmKPExsWy7djPc7pp9qzRBo0zOCxurTvHarFxxnpW iytf37NZTLo/gcXi/PkN7BYzzu9jslh75C6QNfklmwOHx6ZVnWwe97uPM3n0bVnF6PF5k1wA SxSXTUpqTmZZapG+XQJXxrNFF1kKZvJWLN+5lLWBcSp3FyMnh4SAicTVVfPYuxi5OIQEVjBK bHvbywiSEBL4zCixd6oJTNHaQ9tZIYqWMUos+fqGDcJpYJJ4u/A3K0gVm4ChRNfbLjYQW0TA TaLp8EywDmaQooktC9hBEsJAiQc/vzOD2CwCqhJTVxwDW8crYCPx9OAadoh18hLPpkPcJCHw lFWiYfIEVoiEi8TchgtQRcISr45vgbJlJDo7DjJ1MXIA2eUS/05kQYRbGCXWftOHsK0lDh+/ CDaGWYBPYtK26cwQ5bwSHW1CECUeEjOu9ENtcpR4eeYDCyQkYiWO9c5jm8AouYCRYRWjeGpp cW56arFhXmq5XnFibnFpXrpecn7uJkZg9J3+d/zTDsavl5IOMQpwMCrx8AaIsEQLsSaWFVfm HmKU4GBWEuE99QcoxJuSWFmVWpQfX1Sak1p8iFGag0VJnDdOoy5KSCA9sSQ1OzW1ILUIJsvE wSnVwChWI5OTUCVXffXr2hlee7LP1LLeErWP9fls/3zJs6rw4mLGv/P5z4sYXHG+J+4XcjHo 40XVkKjXG2aJ6SRI/Ldi3TNryTLlPVU3eT7ZXz+wN6qQe83TM4qTWQzuzG1gvT21zXGPUGy7 Q6ZMBTvv37atL1cFrLKUKN5trfW+yHiO+2z9O21sekosxRmJhlrMRcWJAB36XcK6AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAJMWRmVeSWpSXmKPExsVy+t/xy7qp9qzRBmtuaVjcWneO1WLjjPWs Fle+vmezmHR/AovF+fMb2C1mnN/HZLH2yF0ga/JLNgcOj02rOtk87ncfZ/Lo27KK0ePzJrkA ligum5TUnMyy1CJ9uwSujGeLLrIUzOStWL5zKWsD41TuLkZODgkBE4m1h7azdjFycQgJLGGU +LRsBxOE08QksfPTe1aQKjYBQ4mut11sILaIgJtE0+GZYB3MIEVX2naygySEgRIPfn5nBrFZ BFQlpq44xghi8wrYSDw9uIYdYp28xLPp89gnMHItYGRYxSiSWlqcm55bbKhXnJhbXJqXrpec n7uJERgO24793LyD8dLG4EOMAhyMSjy8K8RYooVYE8uKK3MPMUpwMCuJ8J76AxTiTUmsrEot yo8vKs1JLT7EKM3BoiTOe96gMkpIID2xJDU7NbUgtQgmy8TBKdXAWL7I8NpJxgd/lqU9qz24 MNxyqdniTVbcd3T9q3aLrxGJCn+/YM7Tdf78M2t+rDFM+H0+Oc5CyjBRXfd2sb240nzD/ADl m9vqKu4v7D3qdGTuyWLx9wsWKmVfS+z6du175OrCNv/e5W+eSZ47+/rttoPF8brFx14lPb4j mm4steR0w37NIrdJd5RYijMSDbWYi4oTAZg5Ar0DAgAA X-CMS-MailID: 20180523101605eucas1p1674542a34da0a42bc319299262d5d596 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180523101605eucas1p1674542a34da0a42bc319299262d5d596 X-RootMTR: 20180523101605eucas1p1674542a34da0a42bc319299262d5d596 References: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartlomiej Zolnierkiewicz , Seung-Woo Kim , Krzysztof Kozlowski , Marek Szyprowski MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The default zpos property for all planes in Exynos DRM was fixed as zero. Fix this by providing proper value provided by hardware drivers, which typically matches hardware window number. Reported-by: Seung-Woo Kim Fixes: e47726a11e11 ("drm/exynos: use generic code for managing zpos plane property") Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm_plane.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c index d2a90dae5c71..38a2a7f1204b 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c @@ -289,13 +289,12 @@ static const struct drm_plane_helper_funcs plane_helper_funcs = { }; static void exynos_plane_attach_zpos_property(struct drm_plane *plane, - bool immutable) + int zpos, bool immutable) { - /* FIXME */ if (immutable) - drm_plane_create_zpos_immutable_property(plane, 0); + drm_plane_create_zpos_immutable_property(plane, zpos); else - drm_plane_create_zpos_property(plane, 0, 0, MAX_PLANE - 1); + drm_plane_create_zpos_property(plane, zpos, 0, MAX_PLANE - 1); } int exynos_plane_init(struct drm_device *dev, @@ -320,7 +319,7 @@ int exynos_plane_init(struct drm_device *dev, exynos_plane->index = index; exynos_plane->config = config; - exynos_plane_attach_zpos_property(&exynos_plane->base, + exynos_plane_attach_zpos_property(&exynos_plane->base, config->zpos, !(config->capabilities & EXYNOS_DRM_PLANE_CAP_ZPOS)); return 0;