diff mbox

[3/3] ANDROID: goldfish_fb: Set pixclock = 0

Message ID 20180531220252.58679-3-rkir@google.com (mailing list archive)
State New, archived
Headers show

Commit Message

Roman Kiryanov May 31, 2018, 10:02 p.m. UTC 
From: Christoffer Dall <christoffer.dall@linaro.org>

User space Android code identifies pixclock == 0 as a sign for emulation
and will set the frame rate to 60 fps when reading this value, which is
the desired outcome.

Change-Id: I759bf518bf6683446bc786bf1be3cafa02dd8d42
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 drivers/video/fbdev/goldfishfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bartlomiej Zolnierkiewicz June 8, 2018, 4:23 p.m. UTC | #1 
[ + linux-fbdev ML ]

On Thursday, May 31, 2018 03:02:52 PM rkir@google.com wrote:
> From: Christoffer Dall <christoffer.dall@linaro.org>
> 
> User space Android code identifies pixclock == 0 as a sign for emulation
> and will set the frame rate to 60 fps when reading this value, which is
> the desired outcome.
> 
> Change-Id: I759bf518bf6683446bc786bf1be3cafa02dd8d42

please drop your local Change-Id from the upstream kernel submissions

> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

your S-o-b line is also needed

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Roman Kiryanov June 8, 2018, 11:40 p.m. UTC | #2 
Hi,

thank you for reviewing our patches. I sent "v2".

Regards,
Roman.
On Fri, Jun 8, 2018 at 9:24 AM Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
>
> [ + linux-fbdev ML ]
>
> On Thursday, May 31, 2018 03:02:52 PM rkir@google.com wrote:
> > From: Christoffer Dall <christoffer.dall@linaro.org>
> >
> > User space Android code identifies pixclock == 0 as a sign for emulation
> > and will set the frame rate to 60 fps when reading this value, which is
> > the desired outcome.
> >
> > Change-Id: I759bf518bf6683446bc786bf1be3cafa02dd8d42
>
> please drop your local Change-Id from the upstream kernel submissions
>
> > Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> your S-o-b line is also needed
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
diff mbox

Patch

diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
index 01732858b60d..3a9e5f1b758e 100644
--- a/drivers/video/fbdev/goldfishfb.c
+++ b/drivers/video/fbdev/goldfishfb.c
@@ -237,7 +237,7 @@  static int goldfish_fb_probe(struct platform_device *pdev)
 	fb->fb.var.activate	= FB_ACTIVATE_NOW;
 	fb->fb.var.height	= readl(fb->reg_base + FB_GET_PHYS_HEIGHT);
 	fb->fb.var.width	= readl(fb->reg_base + FB_GET_PHYS_WIDTH);
-	fb->fb.var.pixclock	= 10000;
+	fb->fb.var.pixclock	= 0;
 
 	fb->fb.var.red.offset = 11;
 	fb->fb.var.red.length = 5;