From patchwork Fri Jun 15 22:37:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 10467949 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8E11E600F4 for ; Sat, 16 Jun 2018 10:40:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D98B28C7E for ; Sat, 16 Jun 2018 10:40:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7222E28CCD; Sat, 16 Jun 2018 10:40:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 342F728C7E for ; Sat, 16 Jun 2018 10:40:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC58E6E2AB; Sat, 16 Jun 2018 10:40:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg0-x242.google.com (mail-pg0-x242.google.com [IPv6:2607:f8b0:400e:c05::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B5D76EC07 for ; Fri, 15 Jun 2018 22:38:06 +0000 (UTC) Received: by mail-pg0-x242.google.com with SMTP id q4-v6so5015967pgr.1 for ; Fri, 15 Jun 2018 15:38:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=iIVvslsTepVL9ilO9RUuy9zGOTzVYQqOHZHXk5WXYeA=; b=R+6DiWe4NBEsaDreRey+o0DgrGzt7bzNnrrSWSfkczqLzHiSvKtCRkoCl4Dt6MmNmW 71N70fbLW2MOHFri8me4cv3XX5sZEN2tl+LN0Bv2L4I3Tl3jIwb6FsluJxUPTpm4w+2V /5hoN4NGh7QIPuH4MlcXED7VO9kd+ARvy/GuhZqzYObc0XTuhnxWmCkMafMuNvivHYSh X0X1dhqrbdZmSYdou2KTgJxf++RScd7Wg4i/A5awmfZhZrrjGuU4GLCf+qw9+VaUDeVg VxGuokmtCfN9YuFdWhIvhxCyTxfoFfq84bmzjFo7CM7NHK+GDN5p/jYvaAU7OdlE7f8k ohIQ== X-Gm-Message-State: APt69E2ET30hx0Atx/pSrLgCZWcWYnSVuwq0mCji7QLUx0wKTKvtP1JL LWSELoq3dEBNkcgKxshot97Aow== X-Google-Smtp-Source: ADUXVKIuArMnpcJCjL2xNHl07zqmg2ZbU3xHNjqjtDwWeWslOnREtWmVxq+R4/Cio3KKtC9QNyynhg== X-Received: by 2002:a63:ac11:: with SMTP id v17-v6mr3281257pge.274.1529102285386; Fri, 15 Jun 2018 15:38:05 -0700 (PDT) Received: from ndesaulniers0.svl.corp.google.com ([2620:15c:2a3:1:d33:166f:5b79:14b3]) by smtp.gmail.com with ESMTPSA id e192-v6sm14164603pfg.187.2018.06.15.15.38.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jun 2018 15:38:04 -0700 (PDT) From: Nick Desaulniers To: thierry.reding@gmail.com, airlied@linux.ie Subject: [PATCH] drm/panel: simple: fix -Wliteral-conversion warning Date: Fri, 15 Jun 2018 15:37:49 -0700 Message-Id: <20180615223749.149073-1-ndesaulniers@google.com> X-Mailer: git-send-email 2.18.0.rc1.244.gcf134e6275-goog X-Mailman-Approved-At: Sat, 16 Jun 2018 10:40:39 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nick Desaulniers , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , Jagan Teki MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Fixes commit 8cfe83419cdb ("drm/panel: simple: Add support for KEO TX31D200VM0BAA") drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33 [-Wliteral-conversion] .vfront_porch = { 6, 21, 33.5 }, ~ ^~~~ drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33 [-Wliteral-conversion] .vback_porch = { 6, 21, 33.5 }, ~ ^~~~ Signed-off-by: Nick Desaulniers --- Alternatively, should these be rounded up to 34? I'm guessing the current behaviour (truncation) is correct since that's how the patch was operating. drivers/gpu/drm/panel/panel-simple.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index cbf1ab404ee7..12bcbd1dd77b 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1247,8 +1247,8 @@ static const struct display_timing koe_tx31d200vm0baa_timing = { .hback_porch = { 16, 36, 56 }, .hsync_len = { 8, 8, 8 }, .vactive = { 480, 480, 480 }, - .vfront_porch = { 6, 21, 33.5 }, - .vback_porch = { 6, 21, 33.5 }, + .vfront_porch = { 6, 21, 33 }, + .vback_porch = { 6, 21, 33 }, .vsync_len = { 8, 8, 8 }, .flags = DISPLAY_FLAGS_DE_HIGH, };