| Message ID | 20180618132242.8673-9-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Tomi Valkeinen <tomi.valkeinen@ti.com> [180618 13:26]: > Add DSS node to k2g.dtsi. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: devicetree@vger.kernel.org > --- > arch/arm/boot/dts/keystone-k2g.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi > index da78c0034427..d761fe7d46e7 100644 > --- a/arch/arm/boot/dts/keystone-k2g.dtsi > +++ b/arch/arm/boot/dts/keystone-k2g.dtsi > @@ -609,5 +609,26 @@ > reg = <0x21010000 0x200>; > interrupts = <GIC_SPI 123 IRQ_TYPE_EDGE_RISING>; > }; > + > + dss: dss@02540000 { > + compatible = "ti,k2g-dss"; > + > + reg = <0x02540000 0x400>, > + <0x02550000 0x1000>, > + <0x02557000 0x1000>, > + <0x0255a800 0x100>, > + <0x0255ac00 0x100>; > + > + reg-names = "cfg", "common", "vid1", "ovr1", "vp1"; Can you please check to make sure these are not multiple separate devices? If they are, flushing posted write to one device will not flush anything to the other devices. And that can lead to very hard to track down mysterious bugs. Regards, Tony
On 19/06/18 09:19, Tony Lindgren wrote: > * Tomi Valkeinen <tomi.valkeinen@ti.com> [180618 13:26]: >> Add DSS node to k2g.dtsi. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> >> Cc: devicetree@vger.kernel.org >> --- >> arch/arm/boot/dts/keystone-k2g.dtsi | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi >> index da78c0034427..d761fe7d46e7 100644 >> --- a/arch/arm/boot/dts/keystone-k2g.dtsi >> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi >> @@ -609,5 +609,26 @@ >> reg = <0x21010000 0x200>; >> interrupts = <GIC_SPI 123 IRQ_TYPE_EDGE_RISING>; >> }; >> + >> + dss: dss@02540000 { >> + compatible = "ti,k2g-dss"; >> + >> + reg = <0x02540000 0x400>, >> + <0x02550000 0x1000>, >> + <0x02557000 0x1000>, >> + <0x0255a800 0x100>, >> + <0x0255ac00 0x100>; >> + >> + reg-names = "cfg", "common", "vid1", "ovr1", "vp1"; > > Can you please check to make sure these are not multiple > separate devices? > > If they are, flushing posted write to one device will not flush > anything to the other devices. And that can lead to very hard > to track down mysterious bugs. I don't see anything hinting that they would be separate devices, and it wouldn't really make sense to me either. They're integral parts of the DISPC. I can see a single port for register access, and a single port for the pixel data DMA. Tomi
* Tomi Valkeinen <tomi.valkeinen@ti.com> [180619 07:12]: > On 19/06/18 09:19, Tony Lindgren wrote: > > * Tomi Valkeinen <tomi.valkeinen@ti.com> [180618 13:26]: > >> Add DSS node to k2g.dtsi. > >> > >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > >> Cc: devicetree@vger.kernel.org > >> --- > >> arch/arm/boot/dts/keystone-k2g.dtsi | 21 +++++++++++++++++++++ > >> 1 file changed, 21 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi > >> index da78c0034427..d761fe7d46e7 100644 > >> --- a/arch/arm/boot/dts/keystone-k2g.dtsi > >> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi > >> @@ -609,5 +609,26 @@ > >> reg = <0x21010000 0x200>; > >> interrupts = <GIC_SPI 123 IRQ_TYPE_EDGE_RISING>; > >> }; > >> + > >> + dss: dss@02540000 { > >> + compatible = "ti,k2g-dss"; > >> + > >> + reg = <0x02540000 0x400>, > >> + <0x02550000 0x1000>, > >> + <0x02557000 0x1000>, > >> + <0x0255a800 0x100>, > >> + <0x0255ac00 0x100>; > >> + > >> + reg-names = "cfg", "common", "vid1", "ovr1", "vp1"; > > > > Can you please check to make sure these are not multiple > > separate devices? > > > > If they are, flushing posted write to one device will not flush > > anything to the other devices. And that can lead to very hard > > to track down mysterious bugs. > > I don't see anything hinting that they would be separate devices, and it > wouldn't really make sense to me either. They're integral parts of the > DISPC. I can see a single port for register access, and a single port > for the pixel data DMA. OK thanks for checking. Tony
diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi index da78c0034427..d761fe7d46e7 100644 --- a/arch/arm/boot/dts/keystone-k2g.dtsi +++ b/arch/arm/boot/dts/keystone-k2g.dtsi @@ -609,5 +609,26 @@ reg = <0x21010000 0x200>; interrupts = <GIC_SPI 123 IRQ_TYPE_EDGE_RISING>; }; + + dss: dss@02540000 { + compatible = "ti,k2g-dss"; + + reg = <0x02540000 0x400>, + <0x02550000 0x1000>, + <0x02557000 0x1000>, + <0x0255a800 0x100>, + <0x0255ac00 0x100>; + + reg-names = "cfg", "common", "vid1", "ovr1", "vp1"; + + clocks = <&k2g_clks 0x2 0>, <&k2g_clks 0x2 1>; + clock-names = "fck", "vp1"; + + power-domains = <&k2g_pds 0x2>; + + interrupts = <GIC_SPI 247 IRQ_TYPE_EDGE_RISING>; + + status = "disabled"; + }; }; };
Add DSS node to k2g.dtsi. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: devicetree@vger.kernel.org --- arch/arm/boot/dts/keystone-k2g.dtsi | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)