From patchwork Thu Jun 21 18:49:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10480419 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 482BF60230 for ; Thu, 21 Jun 2018 18:51:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 39EF028E37 for ; Thu, 21 Jun 2018 18:51:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2E0862919C; Thu, 21 Jun 2018 18:51:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D216128E37 for ; Thu, 21 Jun 2018 18:51:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 726216E2DC; Thu, 21 Jun 2018 18:51:53 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45E0D6E2DC for ; Thu, 21 Jun 2018 18:51:52 +0000 (UTC) Received: by mail-lf0-x242.google.com with SMTP id e13-v6so5848548lfc.1 for ; Thu, 21 Jun 2018 11:51:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vhjezqH7eDAVlQ5vBwEozobkQhwjERGiWg40cYUpYMs=; b=YOYXzQh0dlskhkqCNhtFAkmTwyEybB7QW6uOQZUPNtd+3lyRdBYqyJQp2op1CbkyEt ILuwIISXNFBc7l4rgfWA7fAL51emRMIakgEH26apFK5f399nPFMCl/ByhSU+nLB0Adf1 eE/ICDcSewqEliKjgiQs2HwtzL94vJptrPAFuwxa3qiSPblLXVR6OY/kgAlxa8D+ws45 KugNO+S87NeIrcpAe3pS6fpHZkWtFwlYynAvOMj8tv9Ndy2K3csQuzRYlkJ+wYNAPV0f lfz58HOnvujx6asm61Ve8OG2s13iruQ+XoZamgS95xkfirmzUFtE8SeIjKdm9qxel2yv D97Q== X-Gm-Message-State: APt69E02KNfXIvxxNMwXIalcAd+lWnfgLen0A2fnQTF61tZaGH3b0YZ1 +JEhE1+Hstaw2VC7MEyu+Ak7rw== X-Google-Smtp-Source: ADUXVKLmuCYiupVOE6x4KBt5sLc7+290e6sw1ReSWSyfQGiWqxM6qjt44b/i6P3TXa/Fv0DtfTtSmg== X-Received: by 2002:a2e:980f:: with SMTP id a15-v6mr17727343ljj.143.1529607110761; Thu, 21 Jun 2018 11:51:50 -0700 (PDT) Received: from localhost.localdomain (c-ae7b71d5.014-348-6c756e10.bbcust.telenor.se. [213.113.123.174]) by smtp.gmail.com with ESMTPSA id s5-v6sm977793ljj.93.2018.06.21.11.51.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Jun 2018 11:51:49 -0700 (PDT) From: Linus Walleij To: Thierry Reding , dri-devel@lists.freedesktop.org Subject: [PATCH 1/2] drm/panel: Augment the TPO TPG110 bindings Date: Thu, 21 Jun 2018 20:49:41 +0200 Message-Id: <20180621184942.26087-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.17.1 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The TPO TPG110 bindings were using the DPI bindings (popular in the fbdev subsystem) but this misses the finer points learned in the DRM subsystem. We need to augment the bindings for proper DRM integration: the timings are expressed by the hardware, not put into the device tree. Old device trees with the DPI info will continue to work, but no known deployments exist. Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij --- .../bindings/display/panel/tpo,tpg110.txt | 34 ++++++++----------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt b/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt index f5e3c6f2095a..0e918076d55e 100644 --- a/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt +++ b/Documentation/devicetree/bindings/display/panel/tpo,tpg110.txt @@ -1,26 +1,32 @@ TPO TPG110 Panel ================ -This binding builds on the DPI bindings, adding a few properties -as a superset of a DPI. See panel-dpi.txt for the required DPI -bindings. +This panel driver can driver a variety of panels. It requires +a few GPIO lines for control of its reset line and custom serial +protocol. Required properties: -- compatible : "tpo,tpg110" +- compatible : one of: + "ste,nomadik-nhk15-display", "tpo,tpg110" + "tpo,tpg110" - grestb-gpios : panel reset GPIO - scen-gpios : serial control enable GPIO - scl-gpios : serial control clock line GPIO - sda-gpios : serial control data line GPIO +- width-mm : see display/panel/panel-common.txt +- height-mm : see display/panel/panel-common.txt -Required nodes: -- Video port for DPI input, see panel-dpi.txt -- Panel timing for DPI setup, see panel-dpi.txt +The device node can contain one 'port' child node with one child +'endpoint' node, according to the bindings defined in +media/video-interfaces.txt. This node should describe panel's video bus. Example ------- panel { - compatible = "tpo,tpg110", "panel-dpi"; + compatible = "tpo,tpg110"; + width-mm = <116>; + height-mm = <87>; grestb-gpios = <&stmpe_gpio44 5 GPIO_ACTIVE_LOW>; scen-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>; scl-gpios = <&gpio0 5 GPIO_ACTIVE_HIGH>; @@ -32,16 +38,4 @@ panel { remote-endpoint = <&nomadik_clcd_pads>; }; }; - - panel-timing { - clock-frequency = <33200000>; - hactive = <800>; - hback-porch = <216>; - hfront-porch = <40>; - hsync-len = <1>; - vactive = <480>; - vback-porch = <35>; - vfront-porch = <10>; - vsync-len = <1>; - }; };