diff mbox

drm/gma500: Fix compile warning

Message ID 20180625123355.GA16757@embeddedor.com (mailing list archive)
State New, archived
Headers show

Commit Message

Gustavo A. R. Silva June 25, 2018, 12:33 p.m. UTC
Fix the following compile warning:

warning: unused variable ‘psbfb’ [-Wunused-variable]
  struct psb_framebuffer *psbfb = to_psb_fb(fb);

Fixes: c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/gpu/drm/gma500/mdfld_intel_display.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Ville Syrjälä June 26, 2018, 1:28 p.m. UTC | #1
On Mon, Jun 25, 2018 at 07:33:55AM -0500, Gustavo A. R. Silva wrote:
> Fix the following compile warning:
> 
> warning: unused variable ‘psbfb’ [-Wunused-variable]
>   struct psb_framebuffer *psbfb = to_psb_fb(fb);
> 
> Fixes: c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

I sent the same patch a few days ago. Instead of hunting for an r-b
I just went ahead and pushed your version. Thanks for the patch.

> ---
>  drivers/gpu/drm/gma500/mdfld_intel_display.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> index 881d613..2b9fa01 100644
> --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c
> +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> @@ -167,7 +167,6 @@ static int mdfld__intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
>  	struct drm_psb_private *dev_priv = dev->dev_private;
>  	struct drm_framebuffer *fb = crtc->primary->fb;
>  	struct gma_crtc *gma_crtc = to_gma_crtc(crtc);
> -	struct psb_framebuffer *psbfb = to_psb_fb(fb);
>  	int pipe = gma_crtc->pipe;
>  	const struct psb_offset *map = &dev_priv->regmap[pipe];
>  	unsigned long start, offset;
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Gustavo A. R. Silva June 26, 2018, 1:37 p.m. UTC | #2
On 06/26/2018 08:28 AM, Ville Syrjälä wrote:
> On Mon, Jun 25, 2018 at 07:33:55AM -0500, Gustavo A. R. Silva wrote:
>> Fix the following compile warning:
>>
>> warning: unused variable ‘psbfb’ [-Wunused-variable]
>>   struct psb_framebuffer *psbfb = to_psb_fb(fb);
>>
>> Fixes: c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> I sent the same patch a few days ago. Instead of hunting for an r-b
> I just went ahead and pushed your version. Thanks for the patch.
> 

Glad to help :)

Thanks
--
Gustavo
diff mbox

Patch

diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c
index 881d613..2b9fa01 100644
--- a/drivers/gpu/drm/gma500/mdfld_intel_display.c
+++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c
@@ -167,7 +167,6 @@  static int mdfld__intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
 	struct drm_psb_private *dev_priv = dev->dev_private;
 	struct drm_framebuffer *fb = crtc->primary->fb;
 	struct gma_crtc *gma_crtc = to_gma_crtc(crtc);
-	struct psb_framebuffer *psbfb = to_psb_fb(fb);
 	int pipe = gma_crtc->pipe;
 	const struct psb_offset *map = &dev_priv->regmap[pipe];
 	unsigned long start, offset;