diff mbox

[next] drm/panel: ILI9881c: fix missing assignment to error return ret

Message ID 20180626160354.1363-1-colin.king@canonical.com (mailing list archive)
State New, archived
Headers show

Commit Message

Colin King June 26, 2018, 4:03 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Currently, ret is being checked for an error condition however it
is not being assigned in the previous statement on the call of
function mipi_dsi_dcs_exit_sleep_mode.  Add in the missing assignment
of ret.

Detected by CoverityScan, CID#1470174, 1470178 ("Unchecked return value")

Fixes: 26aec25593c2 ("drm/panel: Add Ilitek ILI9881c panel driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thierry Reding July 10, 2018, 10:42 a.m. UTC | #1 
On Tue, Jun 26, 2018 at 05:03:54PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently, ret is being checked for an error condition however it
> is not being assigned in the previous statement on the call of
> function mipi_dsi_dcs_exit_sleep_mode.  Add in the missing assignment
> of ret.
> 
> Detected by CoverityScan, CID#1470174, 1470178 ("Unchecked return value")
> 
> Fixes: 26aec25593c2 ("drm/panel: Add Ilitek ILI9881c panel driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thierry
diff mbox

Patch

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index e848af235df5..3ad4a46c4e94 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -334,7 +334,7 @@  static int ili9881c_prepare(struct drm_panel *panel)
 	if (ret)
 		return ret;
 
-	mipi_dsi_dcs_exit_sleep_mode(ctx->dsi);
+	ret = mipi_dsi_dcs_exit_sleep_mode(ctx->dsi);
 	if (ret)
 		return ret;