Message ID | 20180702091023.695-1-daniel.vetter@ffwll.ch (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Mon, 2018-07-02 at 11:10 +0200, Daniel Vetter wrote: > Apparently didn't get carefully checked. > > Fixes: 50525c332b55 ("drm: content-type property for HDMI connector") > Cc: Hans Verkuil <hans.verkuil@cisco.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > Documentation/gpu/drm-kms.rst | 2 +- > drivers/gpu/drm/drm_connector.c | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm- > kms.rst > index 4f6f113a7f5d..514939433004 100644 > --- a/Documentation/gpu/drm-kms.rst > +++ b/Documentation/gpu/drm-kms.rst > @@ -527,7 +527,7 @@ Standard Connector Properties > :doc: standard connector properties > > HDMI Specific Connector Properties > ------------------------------ > +---------------------------------- > > .. kernel-doc:: drivers/gpu/drm/drm_connector.c > :doc: HDMI connector properties > diff --git a/drivers/gpu/drm/drm_connector.c > b/drivers/gpu/drm/drm_connector.c > index 2f9ebddd178e..b09b3a3e4024 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -1033,9 +1033,7 @@ > EXPORT_SYMBOL(drm_mode_create_dvi_i_properties); > * > * Drivers can set up this property by calling > * drm_connector_attach_content_type_property(). Decoding to > - * infoframe values is done through > - * drm_hdmi_get_content_type_from_property() and > - * drm_hdmi_get_itc_bit_from_property(). > + * infoframe values is done through > drm_hdmi_avi_infoframe_content_type(). > */ All right, thank you very much for spotting, there were so much last minute changes that I probably got confused. Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > > /** -- Best Regards, Lisovskiy Stanislav
On Mon, Jul 02, 2018 at 10:03:51AM +0000, Lisovskiy, Stanislav wrote: > On Mon, 2018-07-02 at 11:10 +0200, Daniel Vetter wrote: > > Apparently didn't get carefully checked. > > > > Fixes: 50525c332b55 ("drm: content-type property for HDMI connector") > > Cc: Hans Verkuil <hans.verkuil@cisco.com> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > --- > > Documentation/gpu/drm-kms.rst | 2 +- > > drivers/gpu/drm/drm_connector.c | 4 +--- > > 2 files changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm- > > kms.rst > > index 4f6f113a7f5d..514939433004 100644 > > --- a/Documentation/gpu/drm-kms.rst > > +++ b/Documentation/gpu/drm-kms.rst > > @@ -527,7 +527,7 @@ Standard Connector Properties > > :doc: standard connector properties > > > > HDMI Specific Connector Properties > > ------------------------------ > > +---------------------------------- > > > > .. kernel-doc:: drivers/gpu/drm/drm_connector.c > > :doc: HDMI connector properties > > diff --git a/drivers/gpu/drm/drm_connector.c > > b/drivers/gpu/drm/drm_connector.c > > index 2f9ebddd178e..b09b3a3e4024 100644 > > --- a/drivers/gpu/drm/drm_connector.c > > +++ b/drivers/gpu/drm/drm_connector.c > > @@ -1033,9 +1033,7 @@ > > EXPORT_SYMBOL(drm_mode_create_dvi_i_properties); > > * > > * Drivers can set up this property by calling > > * drm_connector_attach_content_type_property(). Decoding to > > - * infoframe values is done through > > - * drm_hdmi_get_content_type_from_property() and > > - * drm_hdmi_get_itc_bit_from_property(). > > + * infoframe values is done through > > drm_hdmi_avi_infoframe_content_type(). > > */ > > All right, thank you very much for spotting, there were so much > last > minute changes that I probably got confused. Yeah figured as much, nw. > Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> Thanks for your review, applied to drm-misc-next. -Daniel
diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst index 4f6f113a7f5d..514939433004 100644 --- a/Documentation/gpu/drm-kms.rst +++ b/Documentation/gpu/drm-kms.rst @@ -527,7 +527,7 @@ Standard Connector Properties :doc: standard connector properties HDMI Specific Connector Properties ------------------------------ +---------------------------------- .. kernel-doc:: drivers/gpu/drm/drm_connector.c :doc: HDMI connector properties diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 2f9ebddd178e..b09b3a3e4024 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -1033,9 +1033,7 @@ EXPORT_SYMBOL(drm_mode_create_dvi_i_properties); * * Drivers can set up this property by calling * drm_connector_attach_content_type_property(). Decoding to - * infoframe values is done through - * drm_hdmi_get_content_type_from_property() and - * drm_hdmi_get_itc_bit_from_property(). + * infoframe values is done through drm_hdmi_avi_infoframe_content_type(). */ /**
Apparently didn't get carefully checked. Fixes: 50525c332b55 ("drm: content-type property for HDMI connector") Cc: Hans Verkuil <hans.verkuil@cisco.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- Documentation/gpu/drm-kms.rst | 2 +- drivers/gpu/drm/drm_connector.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-)