From patchwork Tue Jul 3 19:14:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Hellstrom X-Patchwork-Id: 10505009 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0BA4A60225 for ; Tue, 3 Jul 2018 19:17:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EC5AE28C60 for ; Tue, 3 Jul 2018 19:17:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DE58528C7F; Tue, 3 Jul 2018 19:17:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8ED0328C60 for ; Tue, 3 Jul 2018 19:17:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D221F6E8DB; Tue, 3 Jul 2018 19:16:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from NAM05-BY2-obe.outbound.protection.outlook.com (mail-eopbgr710084.outbound.protection.outlook.com [40.107.71.84]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E34B6E8D8 for ; Tue, 3 Jul 2018 19:16:48 +0000 (UTC) Received: from fedoratest.localdomain (155.4.205.56) by DM6PR05MB4587.namprd05.prod.outlook.com (2603:10b6:5:9f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.11; Tue, 3 Jul 2018 19:16:45 +0000 From: Thomas Hellstrom To: dri-devel@lists.freedesktop.org Subject: [PATCH -next 09/15] drm/vmwgfx: Remove primary memory validation against mode while creating fb Date: Tue, 3 Jul 2018 21:14:54 +0200 Message-Id: <20180703191500.2374-10-thellstrom@vmware.com> X-Mailer: git-send-email 2.18.0.rc1 In-Reply-To: <20180703191500.2374-1-thellstrom@vmware.com> References: <20180703191500.2374-1-thellstrom@vmware.com> MIME-Version: 1.0 X-Originating-IP: [155.4.205.56] X-ClientProxiedBy: DM5PR21CA0042.namprd21.prod.outlook.com (2603:10b6:3:ed::28) To DM6PR05MB4587.namprd05.prod.outlook.com (2603:10b6:5:9f::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8dd50797-6256-4cfc-a0f1-08d5e11984f4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DM6PR05MB4587; X-Microsoft-Exchange-Diagnostics: 1; DM6PR05MB4587; 3:B97ebbH8lX/hiJwOOLHG0MeQezDttLO8/t3yEn2z38w1GHGC+aDP4KHNAOcnGb/bJiQ9i+7HdICQl2NZaJV8FdcP+5uE1tYCJzyOmMrtljI4xsJrmw0EwUu0LM5aD8dKsJDVxG2k6/AMxD8lmMsqTURJ3KiMndQqaremXoJUfwMAxJt4ut+UyY0o+gdfwKHOoCoQcxWDZPi/SvlChoxmpCpwRsUbJzeS5caucMBUH/ZgvCSI+n6p3i8ojux8+EeH; 25:i+ocD0ccYnga4F28a8IvJitFfPgShJfpA+mv0VeWg7O08iW2V6Kulzj2qorXLQJ9HZgHbfxCqjNR5eFOxKk/sucbapeCQ18e7WaE/hBHL3w1KKwZtnDkuDg83i43mn+97QI9tyEbS8+5H3hY2w/nqQ9IjXAwWSLpZntblSTumvXdNrHy0mOTjj7M66pLIxzj7bp4ZG7CD0FAruNyLX718dwvI5Lx9UCQBSDNSdep6RSxXKJatwY5LW7FGsohY6lz4eVRdVHcmB6gSVQqh6weQrN5QmErOsVdUcQyf1rN/ZT/pwGT0/dcNXY+qYds+9uVw3jqf5kGMtfeP6cRLKb2gA==; 31:1WWz1nWV/KkOTukBkwg83yK2RMrW9NH8tjO/X80OhbGOlWwHeBFtLxwUPhib+JfykqNoGc5xwQTSu3TOWiynCA4FOe6SeAZdidy57otxZzJMn8O+qVStzIi1Q+8Cck6AGoYLVZA2q7+YHGzL08XEErDKI8SpHQ+AsaUAR4qbWWHiw6km2AUlO7htsNwH2Os4yPhMKxCCZalt8yzBDGWElpMN27glH3alsFhS90yIj6w= X-MS-TrafficTypeDiagnostic: DM6PR05MB4587: X-LD-Processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DM6PR05MB4587; 20:ti6DA5vyzzY10oVJTMgdx1GSAXk2xFFI8ggDyDFGJsjKJ0/DCuejYeeqHuNIacoqRvi/2HJ0S8MuzfqCVdLFDOuA73An60wl8I3SBWNw81kRCOKhpj1UsKvHiXtc5OMGRsLp4w+6ZSnpMA91Oi+4W0TKkPlndOZQpzVCaTYd6PTb2QO6z12MjGAkcg0/WVp/KYYvu21NtbykreUWflP0KIJYSBKPhaSyYt8E4r3kPX6877oBKk02tEOneZ3W6Q+FnBQ9yL0tyGm4ZoZ46QisH35lDVSzDkZkOS+nExC+1QWabDHXuJv4NYZtLxlHAJ7T3E5ip/ie7O4++BmAo4rqUCa1t5+HdPNOqQ12dGX0+Eh2S2O99snPtWd2gftuMoo+/2bBCR+GCnpsZi6oZ4B06/bdqyosl/esB3QYUxJTf/mKZXvuFzJoI39wbOQoV/S3A1pH/bkpYUASfp+Hw0vTALnLGGbV5mUg8LfVE8RhAI3ZT0VeWNwnLb49AAEYs0YF; 4:wNp+KmoCB2OAm8pyaDSPdagpmkUiQOejhqHyAq9ts21Y98zW/XFDXfgSYSZps3vVso6s/4m0IxRdPQ0NHsdFqHdzJVzt2tvu2RUnbADaNnoula1Yu3gwFS34nCOq6krDo17IL6gaLRFaNrC1CZLg2agF6A1qqirC+0Qw+e1/+v7RLAezesz6J8GNukBDrhWC4bmDEiv08EacMuA0IllVuwLt1T5D1Nht/SKOU6lsIjiCinCYrKV0l1nPAzX5+4+49BwiWUChaFTlq9plDBjq4t6VJlSSCQpqlMZJnyDSOIZnXbaVC+ff7rNeBiJneKm3 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(61668805478150); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:DM6PR05MB4587; BCL:0; PCL:0; RULEID:; SRVR:DM6PR05MB4587; X-Forefront-PRVS: 0722981D2A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(366004)(39860400002)(396003)(376002)(346002)(199004)(189003)(2361001)(53936002)(76176011)(68736007)(52116002)(51416003)(47776003)(26005)(2351001)(50226002)(16526019)(97736004)(575784001)(86362001)(386003)(2906002)(6506007)(66066001)(186003)(316002)(16586007)(48376002)(446003)(6486002)(50466002)(54906003)(14444005)(11346002)(2616005)(1076002)(956004)(6116002)(6512007)(476003)(81166006)(8676002)(81156014)(36756003)(3846002)(5660300001)(486006)(107886003)(106356001)(305945005)(25786009)(7736002)(4326008)(478600001)(6916009)(105586002)(6666003)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR05MB4587; H:fedoratest.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: vmware.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM6PR05MB4587; 23:Oxgje0GYD3pvqEELeesXOZsOLpAR9GG0v388Ac2ff?= =?us-ascii?Q?wukdDbv2B3oH2sWtRnVfiqFaFH8i6QZm6tZdswiqAkjlzn4XbKCOk/7LR3sh?= =?us-ascii?Q?M5S2YYCJfRaR3SPdPvawl2OdTjuAzJJvzjQtYPEK90ilkwV6FoNXKG+7IKjI?= =?us-ascii?Q?wAOmG5Bb8pO9WIxUBDypOdaA0I5cYyvBQMxVmq+ZVhR5sD337vmw4Q3KLN2w?= =?us-ascii?Q?xbr7Ef5HZfagboTYAV+1hKHtLIeACW33NOARlY6jy4qqtaoMx9MFADWFeUtN?= =?us-ascii?Q?jfuQiimSjeJExZFV7FOYuQw4BO8N2/rAJEBqy/pHL407dESyKaSKd+kckWme?= =?us-ascii?Q?JQHl/mf936BkvaBByFhk7eoAdFxXP1UMCdjj2nITi1OtwuKGQ7czaUluZp0G?= =?us-ascii?Q?ujCuJ+Yn4XSdC9jvb0zmWNPw1KLzhfs5HplIUqxsQMpX83JyfMnRTU2hz+Ix?= =?us-ascii?Q?lqGkiaRhUTGbqZKsgsfUS0zRBwXV4kdH3pAnDr73AMJZrbTcekNFtamZ9cnw?= =?us-ascii?Q?DvtADaDavB0pd1O2BO4OW8ZRCCDYc4NuEcSTr9AatRK1C/u2bTmZDIyzgqM2?= =?us-ascii?Q?72IrPSAp+we0lYccE5rBpXgQu0TYG2Hrydizr2tMnzRdaAKARnp/qVY0sUve?= =?us-ascii?Q?VhteVFzc6v2rS0Dljlvl6DCHHOAMQpCX0dCdzxKiKY8Plklc5jOwdwu4nzYQ?= =?us-ascii?Q?0OWAuAKvG1EuMcaBqy2psovzWuogaHqV6keC+QZN6sW46qLwJinr/K/nPz3f?= =?us-ascii?Q?4b+gya3liE/RFKuTbQLUqX7F8yvoVyLFvrUlr3XG7TVAlYy3W4y3KR0ZIPEH?= =?us-ascii?Q?7dBCcO4RBtxlLlVVCEfZWIFViFnI5HhWxtZo79sZ1CTydSCUSPL9lUnMY8Nt?= =?us-ascii?Q?xg3Bb9JJ58yI2WFxuNu6KPC756fo2Zcmqb9wT4xMPho5Ku2Z9YIB8Tlwbmc5?= =?us-ascii?Q?Ehmip2INP+IFExJDn8RyDJi0JCy0cQIlgFccw73vshSj30SNxrKRDohce2Tv?= =?us-ascii?Q?6xnTEYetDxdRR2+xJrueNsHECpMuXTXothez4TRB+GH0n8ovEoMZ8V8JQevn?= =?us-ascii?Q?XGJ/o4nJ+2Gk8WZ0OznlZuN8033sfpSayxSczWjWhE1EI5URawnI5SczxT8d?= =?us-ascii?Q?Ua4yyXpC0a+W8h7Mwhu9A6ZIo2has0ryPng02hwHtQIDc3jc66N3aKL+zphO?= =?us-ascii?Q?LOlAZAdLPJXN6aYkvO1g/EpCd0HopyKdwOqjXoArnxhCf1Y5weCkSc+s4kyz?= =?us-ascii?Q?X2g7iJ5Uub0o8WzW41QZDZ1qIYA1vJtyxd1Va972FWwn6zrX3FvDUg73aTrr?= =?us-ascii?Q?S40a2KrA7t6XzFtm/GYHvg=3D?= X-Microsoft-Antispam-Message-Info: x4Q6YijVWc9FowR0bre5l6UZdJMPgaWQF+0XMM3xZQy+mpADjXVzA4/hCrqluOhKdTeDWm3SMq9Xt1XNKODPPyBMYYGhZdBSu/VrOVFh0CxBBmVvCt+RASZVoQRZA+X8k/9gRWtM1SyGhB5eQ7H/ANAJ6o3vYkHv/Acc9xSopZQeTLXx+Lnt8Bbl6f2ekbGu6VmN0gkfA+M1lXl55pa09KCSw8aUalM8/Ek88janjTOC4ulbZd5Fu33OR87IeHVJnlfJ+ng6ZbR6s3kthy9vyWagoCtLfLEK4K3wiA0InvkT6Yboco8FYQLZbSjlCX6oX++y0el3btMwiznIbbTErQDFeFn+oQcb2omcTHUrQpc= X-Microsoft-Exchange-Diagnostics: 1; DM6PR05MB4587; 6:8uFuow9f5OBbhKI07sP0Km7MIHyMtAz1156ufFRSGVrEK2pM/fg2wgpPITiFKtbWNBLzWX1nPZLTJkLjLrAhUO3Z1hEe0y2wiTflxEMbpY0FKuYabCwHLigjRMCXpaMu6ghbvVoAXEEsXgKdTnhPe14qCu+6KIFHzat7bGtkNZSG5avsrAKC+PaoMPSRFhzyM0RnedQnb8LNdk6NJ4HN+cJNhSCI1BHHMYr7ADN18oONKvngMosCmKLe/UB44sRHr8Pkk/LW0wLxc4HJd2x2ZNmyh4qZ4y36LUpnkbWtBozMHb6XWXA0lb4oI3seNGHGCNw0WQTuroAIyq4qQuB31u8jeERQ8vBifoRv5k366cohRN87tR9Tqyz65f26lx0oKTg6Ta+5eLl/mG2S+Pd9k3sgrdLRq0WsewcVvZNsK73DTo1U0d7fCItzYurXo8mF4hUkmTf1113bGhRr/EqR8w==; 5:4pLZE0XrXW1048DRpLT0UZlyhk7L3aV9iWGAzAWhtfKeejkkiEzElxW9LzjWp5eSsF3ro93k+JN/LwqcFjto/THlF4Cm0ibbVgfWcfNd0hKNlT3UNGsmHN/Ssf/5CqB5YXz/BGKBvLuGxPRNAE0d/MhCeDVHXzcH6Ockrb/0eBI=; 24:OOuinQK5CHlgNGMVytdvELmpGQQQUt5C88gAhUezrXDtmhYnK2UJ/Tnttrfqa664sqxOI1eTLf+6YHT63TijLx82naxNYm6urP8moZ0eMDM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM6PR05MB4587; 7:j3AtNJJZANjGfIV0631u/JmxL2BtNy1vVDG5tXtiMiNThvce0KK3oE1s37YIMzzM0qbxoTqS89CB8xWnBZbyVEoSiQu+onhS4tvSfmuIqOIGANGzxOGPM7aZ9wG9dSR3BYD+qYOClbz9HTmE2Jq6bqfyLvonC8VVHDnhvLgjU5uO/MVJ859GqSVzcIR+iIkwm/HX5qK3RTiUR1sQ5uAkm4fo96oaQqIV4FsqR3DwE50XcKPNYMkZO8HcK3x+3L14; 20:DdXFaZxGLXlFA8BG8Q+X+WhFHjS0zOw9s5wPMb0InPTH8Sgz56noCOHRiwginLg8u0FcstoPg/T+xndxbSzgGNYlbmZPV/J5DdXiNnHuaP9zEcTj+lnrVuMeyRlkAXscUPNPHxc+EEDKMLXNJZNWDi7pU/bvxCEMWQvPXpp9rAo= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2018 19:16:45.5543 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8dd50797-6256-4cfc-a0f1-08d5e11984f4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR05MB4587 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Hellstrom , Deepak Rawat , linux-graphics-maintainer@vmware.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Deepak Rawat This validation is not required because user-space will send create_fb request once the memory is allocated. This check should be performed during mode-setting. Signed-off-by: Deepak Rawat Reviewed-by: Sinclair Yeh Reviewed-by: Thomas Hellstrom Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 3605ac1702c2..f0ae0b2ee2e6 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -1433,19 +1433,6 @@ static struct drm_framebuffer *vmw_kms_fb_create(struct drm_device *dev, struct ttm_base_object *user_obj; int ret; - /** - * This code should be conditioned on Screen Objects not being used. - * If screen objects are used, we can allocate a GMR to hold the - * requested framebuffer. - */ - - if (!vmw_kms_validate_mode_vram(dev_priv, - mode_cmd->pitches[0], - mode_cmd->height)) { - DRM_ERROR("Requested mode exceed bounding box limit.\n"); - return ERR_PTR(-ENOMEM); - } - /* * Take a reference on the user object of the resource * backing the kms fb. This ensures that user-space handle