From patchwork Wed Jul 4 09:29:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10506303 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9F3C3601D7 for ; Wed, 4 Jul 2018 09:29:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 91F8E28DAF for ; Wed, 4 Jul 2018 09:29:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 864AD28DC3; Wed, 4 Jul 2018 09:29:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4F1EB28DAF for ; Wed, 4 Jul 2018 09:29:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BFA586EB2E; Wed, 4 Jul 2018 09:29:25 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id C963C6EB1A for ; Wed, 4 Jul 2018 09:29:22 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id d3-v6so3584378edi.1 for ; Wed, 04 Jul 2018 02:29:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YWuMqoDADzviwwEOFy/U6OgN/I8wqPqXYHneXwPc76A=; b=krspkpqyWN/L39jUWKDm9xzcj0DE36qx42yMV8Qi+5aVenJ0EAzHduhtgM3Q7gFtYo pEeFEqf0C7E13JfxLAiej1mTj9PIQ1WTKpZfSA4opp6cy75JmeLKlPvpPPifopyki7J7 rYDqvBsTamTNgX9T+99B96jRSa8gncx3LGUMz/Sa/MZCTERkBzooM+vZzVZc0DIpHw8Q VUEPLxbDMPc8TYyAPzPwDzHKRpKmp92SyMkkzmz/oZrBVkz6ueshU9p+VP8Ufr0Iv6Nq ENVkN/P5hoiMEIS7xWJaNX8D6lzzhK1U2sphipctI7eUrVKrU3u4nCB7r1clWiIENP7K abXA== X-Gm-Message-State: APt69E1yRJxrnmaxxUOFHdkWNEBGuO8CPIfzmZ0BCdVFzUc4vkP+PSgx 4Vw37QNAu7Gn+l4G9dTOd7tyDcsl X-Google-Smtp-Source: AAOMgpe4trFNqSCWM6xV48QaLXqwy8szLJJn8kDa5p00XMO/r8d+kv8jgMqc5XzTobPQ2Ote+IFrSQ== X-Received: by 2002:a50:81a4:: with SMTP id 33-v6mr1867667ede.200.1530696561181; Wed, 04 Jul 2018 02:29:21 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5628:0:496f:7dc5:66d7:a057]) by smtp.gmail.com with ESMTPSA id r3-v6sm1773800edh.9.2018.07.04.02.29.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jul 2018 02:29:20 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 4/5] drm/vgem: Remove unecessary dma_fence_ops Date: Wed, 4 Jul 2018 11:29:08 +0200 Message-Id: <20180704092909.6599-5-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180704092909.6599-1-daniel.vetter@ffwll.ch> References: <20180704092909.6599-1-daniel.vetter@ffwll.ch> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Kees Cook , Cihangir Akturk MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Also remove the ->signaled callback, vgem can't peek ahead with a fastpath, returning false is the default implementation. Signed-off-by: Daniel Vetter Cc: Kees Cook Cc: Cihangir Akturk Cc: Sean Paul Cc: Daniel Vetter --- drivers/gpu/drm/vgem/vgem_fence.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/gpu/drm/vgem/vgem_fence.c b/drivers/gpu/drm/vgem/vgem_fence.c index b28876c222b4..75adedeaa384 100644 --- a/drivers/gpu/drm/vgem/vgem_fence.c +++ b/drivers/gpu/drm/vgem/vgem_fence.c @@ -43,16 +43,6 @@ static const char *vgem_fence_get_timeline_name(struct dma_fence *fence) return "unbound"; } -static bool vgem_fence_signaled(struct dma_fence *fence) -{ - return false; -} - -static bool vgem_fence_enable_signaling(struct dma_fence *fence) -{ - return true; -} - static void vgem_fence_release(struct dma_fence *base) { struct vgem_fence *fence = container_of(base, typeof(*fence), base); @@ -76,11 +66,7 @@ static void vgem_fence_timeline_value_str(struct dma_fence *fence, char *str, static const struct dma_fence_ops vgem_fence_ops = { .get_driver_name = vgem_fence_get_driver_name, .get_timeline_name = vgem_fence_get_timeline_name, - .enable_signaling = vgem_fence_enable_signaling, - .signaled = vgem_fence_signaled, - .wait = dma_fence_default_wait, .release = vgem_fence_release, - .fence_value_str = vgem_fence_value_str, .timeline_value_str = vgem_fence_timeline_value_str, };