diff mbox series

drm/dp: add missing ')' to I2C nack debug message

Message ID 20180727203331.27778-1-paulo.r.zanoni@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/dp: add missing ')' to I2C nack debug message | expand

Commit Message

Zanoni, Paulo R July 27, 2018, 8:33 p.m. UTC
"(an unmatched left parenthesis
  creates an unresolved tension
  that will stay with you all day."
               -- Randall Munroe

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/drm_dp_helper.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Alex Deucher July 27, 2018, 8:38 p.m. UTC | #1
On Fri, Jul 27, 2018 at 4:33 PM, Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
>  "(an unmatched left parenthesis
>   creates an unresolved tension
>   that will stay with you all day."
>                -- Randall Munroe
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/drm_dp_helper.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 0cccbcb2d03e..8c6b9fd89f8a 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -850,7 +850,8 @@ static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
>                         return ret;
>
>                 case DP_AUX_I2C_REPLY_NACK:
> -                       DRM_DEBUG_KMS("I2C nack (result=%d, size=%zu\n", ret, msg->size);
> +                       DRM_DEBUG_KMS("I2C nack (result=%d, size=%zu)\n",
> +                                     ret, msg->size);
>                         aux->i2c_nack_count++;
>                         return -EREMOTEIO;
>
> --
> 2.14.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Rodrigo Vivi Aug. 1, 2018, 5:01 p.m. UTC | #2
On Fri, Jul 27, 2018 at 04:38:29PM -0400, Alex Deucher wrote:
> On Fri, Jul 27, 2018 at 4:33 PM, Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> >  "(an unmatched left parenthesis
> >   creates an unresolved tension
> >   that will stay with you all day."
> >                -- Randall Munroe
> >
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

pushed to drm-misc-next, thanks.

> 
> > ---
> >  drivers/gpu/drm/drm_dp_helper.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> > index 0cccbcb2d03e..8c6b9fd89f8a 100644
> > --- a/drivers/gpu/drm/drm_dp_helper.c
> > +++ b/drivers/gpu/drm/drm_dp_helper.c
> > @@ -850,7 +850,8 @@ static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
> >                         return ret;
> >
> >                 case DP_AUX_I2C_REPLY_NACK:
> > -                       DRM_DEBUG_KMS("I2C nack (result=%d, size=%zu\n", ret, msg->size);
> > +                       DRM_DEBUG_KMS("I2C nack (result=%d, size=%zu)\n",
> > +                                     ret, msg->size);
> >                         aux->i2c_nack_count++;
> >                         return -EREMOTEIO;
> >
> > --
> > 2.14.4
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index 0cccbcb2d03e..8c6b9fd89f8a 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -850,7 +850,8 @@  static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
 			return ret;
 
 		case DP_AUX_I2C_REPLY_NACK:
-			DRM_DEBUG_KMS("I2C nack (result=%d, size=%zu\n", ret, msg->size);
+			DRM_DEBUG_KMS("I2C nack (result=%d, size=%zu)\n",
+				      ret, msg->size);
 			aux->i2c_nack_count++;
 			return -EREMOTEIO;