| Message ID | 20180806203702.16961-4-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | omapdrm: Rework the timing-related operations | expand |
On 06/08/18 23:36, Laurent Pinchart wrote: > The two functions implement the .set_timings() and .check_timings() > operations. Rename them to hdmi_disply_set_timings() and > hdmi_display_check_timings() respectively to match the operations names > and make searching the source code easier. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> > --- > drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c | 2 -- > drivers/gpu/drm/omapdrm/dss/hdmi4.c | 12 ++++++------ > drivers/gpu/drm/omapdrm/dss/hdmi5.c | 12 ++++++------ > 3 files changed, 12 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c > index 29bda16afbdc..54f133d7da07 100644 > --- a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c > +++ b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c > @@ -92,8 +92,6 @@ static void tfp410_set_timings(struct omap_dss_device *dssdev, > struct panel_drv_data *ddata = to_panel_data(dssdev); > struct omap_dss_device *src = dssdev->src; > > - tfp410_fix_timings(vm); ?
Hi Tomi, On Monday, 13 August 2018 13:50:18 EEST Tomi Valkeinen wrote: > On 06/08/18 23:36, Laurent Pinchart wrote: > > The two functions implement the .set_timings() and .check_timings() > > operations. Rename them to hdmi_disply_set_timings() and > > hdmi_display_check_timings() respectively to match the operations names > > and make searching the source code easier. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> > > --- > > > > drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c | 2 -- > > drivers/gpu/drm/omapdrm/dss/hdmi4.c | 12 ++++++------ > > drivers/gpu/drm/omapdrm/dss/hdmi5.c | 12 ++++++------ > > 3 files changed, 12 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c > > b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c index > > 29bda16afbdc..54f133d7da07 100644 > > --- a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c > > +++ b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c > > @@ -92,8 +92,6 @@ static void tfp410_set_timings(struct omap_dss_device > > *dssdev,> > > struct panel_drv_data *ddata = to_panel_data(dssdev); > > struct omap_dss_device *src = dssdev->src; > > > > - tfp410_fix_timings(vm); > > ? Oops :-/ I don't know how this ended up here, it should be in 04/22. I'll fix that.
diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c index 29bda16afbdc..54f133d7da07 100644 --- a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c +++ b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c @@ -92,8 +92,6 @@ static void tfp410_set_timings(struct omap_dss_device *dssdev, struct panel_drv_data *ddata = to_panel_data(dssdev); struct omap_dss_device *src = dssdev->src; - tfp410_fix_timings(vm); - ddata->vm = *vm; src->ops->set_timings(src, vm); diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c index c92564300446..73ca79471ce4 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c @@ -251,8 +251,8 @@ static void hdmi_power_off_full(struct omap_hdmi *hdmi) hdmi_power_off_core(hdmi); } -static int hdmi_display_check_timing(struct omap_dss_device *dssdev, - struct videomode *vm) +static int hdmi_display_check_timings(struct omap_dss_device *dssdev, + struct videomode *vm) { struct omap_hdmi *hdmi = dssdev_to_hdmi(dssdev); @@ -262,8 +262,8 @@ static int hdmi_display_check_timing(struct omap_dss_device *dssdev, return 0; } -static void hdmi_display_set_timing(struct omap_dss_device *dssdev, - struct videomode *vm) +static void hdmi_display_set_timings(struct omap_dss_device *dssdev, + struct videomode *vm) { struct omap_hdmi *hdmi = dssdev_to_hdmi(dssdev); @@ -508,8 +508,8 @@ static const struct omap_dss_device_ops hdmi_ops = { .enable = hdmi_display_enable, .disable = hdmi_display_disable, - .check_timings = hdmi_display_check_timing, - .set_timings = hdmi_display_set_timing, + .check_timings = hdmi_display_check_timings, + .set_timings = hdmi_display_set_timings, .read_edid = hdmi_read_edid, diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c index 2aaa8ee61662..259cd39d0c1d 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c @@ -250,8 +250,8 @@ static void hdmi_power_off_full(struct omap_hdmi *hdmi) hdmi_power_off_core(hdmi); } -static int hdmi_display_check_timing(struct omap_dss_device *dssdev, - struct videomode *vm) +static int hdmi_display_check_timings(struct omap_dss_device *dssdev, + struct videomode *vm) { struct omap_hdmi *hdmi = dssdev_to_hdmi(dssdev); @@ -261,8 +261,8 @@ static int hdmi_display_check_timing(struct omap_dss_device *dssdev, return 0; } -static void hdmi_display_set_timing(struct omap_dss_device *dssdev, - struct videomode *vm) +static void hdmi_display_set_timings(struct omap_dss_device *dssdev, + struct videomode *vm) { struct omap_hdmi *hdmi = dssdev_to_hdmi(dssdev); @@ -502,8 +502,8 @@ static const struct omap_dss_device_ops hdmi_ops = { .enable = hdmi_display_enable, .disable = hdmi_display_disable, - .check_timings = hdmi_display_check_timing, - .set_timings = hdmi_display_set_timing, + .check_timings = hdmi_display_check_timings, + .set_timings = hdmi_display_set_timings, .read_edid = hdmi_read_edid,