diff mbox series

[1/3] drm: drm_fourcc: add Samsung 16x16 tile format

Message ID 20180810132915eucas1p270d9df94b0aaaa17b0eddfb8682bd3bd~JiPoK4ppk2592125921eucas1p2z@eucas1p2.samsung.com (mailing list archive)
State New, archived
Headers show
Series [1/3] drm: drm_fourcc: add Samsung 16x16 tile format | expand

Commit Message

Marek Szyprowski Aug. 10, 2018, 1:28 p.m. UTC
From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>

Add modifier for tiled formats used by graphics modules found in Samsung
Exynos5250/542x/5433 SoCs. This is a simple tiled layout using tiles
of 16x16 pixels in a row-major layout.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 include/uapi/drm/drm_fourcc.h | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Inki Dae Aug. 27, 2018, 12:38 a.m. UTC | #1
2018년 08월 10일 22:28에 Marek Szyprowski 이(가) 쓴 글:
> From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> 
> Add modifier for tiled formats used by graphics modules found in Samsung
> Exynos5250/542x/5433 SoCs. This is a simple tiled layout using tiles
> of 16x16 pixels in a row-major layout.

Reviewed-by: Inki Dae <inki.dae@samsung.com>

Thanks,
Inki Dae

> 
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  include/uapi/drm/drm_fourcc.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 721ab7e54d96..5631b196c07a 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -299,6 +299,15 @@ extern "C" {
>   */
>  #define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE	fourcc_mod_code(SAMSUNG, 1)
>  
> +/*
> + * Tiled, 16 (pixels) x 16 (lines) - sized macroblocks
> + *
> + * This is a simple tiled layout using tiles of 16x16 pixels in a row-major
> + * layout. For YCbCr formats Cb/Cr components are taken in such a way that
> + * they correspond to their 16x16 luma block.
> + */
> +#define DRM_FORMAT_MOD_SAMSUNG_16_16_TILE	fourcc_mod_code(SAMSUNG, 2)
> +
>  /*
>   * Qualcomm Compressed Format
>   *
>
Inki Dae Sept. 7, 2018, 12:15 a.m. UTC | #2
Hi,

2018년 08월 27일 09:38에 Inki Dae 이(가) 쓴 글:
> 
> 
> 2018년 08월 10일 22:28에 Marek Szyprowski 이(가) 쓴 글:
>> From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
>>
>> Add modifier for tiled formats used by graphics modules found in Samsung
>> Exynos5250/542x/5433 SoCs. This is a simple tiled layout using tiles
>> of 16x16 pixels in a row-major layout.
> 
> Reviewed-by: Inki Dae <inki.dae@samsung.com>
> 

This patch is required by below two patches which add Samsung 16x16 tile format support to gsc and scaler drivers.
https://patchwork.kernel.org/patch/10562707/
https://patchwork.kernel.org/patch/10562713/

Could you give me ack-by so that I could request GIT-PULL together?

Thanks,
InkI Dae

> Thanks,
> Inki Dae
> 
>>
>> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>>  include/uapi/drm/drm_fourcc.h | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
>> index 721ab7e54d96..5631b196c07a 100644
>> --- a/include/uapi/drm/drm_fourcc.h
>> +++ b/include/uapi/drm/drm_fourcc.h
>> @@ -299,6 +299,15 @@ extern "C" {
>>   */
>>  #define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE	fourcc_mod_code(SAMSUNG, 1)
>>  
>> +/*
>> + * Tiled, 16 (pixels) x 16 (lines) - sized macroblocks
>> + *
>> + * This is a simple tiled layout using tiles of 16x16 pixels in a row-major
>> + * layout. For YCbCr formats Cb/Cr components are taken in such a way that
>> + * they correspond to their 16x16 luma block.
>> + */
>> +#define DRM_FORMAT_MOD_SAMSUNG_16_16_TILE	fourcc_mod_code(SAMSUNG, 2)
>> +
>>  /*
>>   * Qualcomm Compressed Format
>>   *
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
diff mbox series

Patch

diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index 721ab7e54d96..5631b196c07a 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -299,6 +299,15 @@  extern "C" {
  */
 #define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE	fourcc_mod_code(SAMSUNG, 1)
 
+/*
+ * Tiled, 16 (pixels) x 16 (lines) - sized macroblocks
+ *
+ * This is a simple tiled layout using tiles of 16x16 pixels in a row-major
+ * layout. For YCbCr formats Cb/Cr components are taken in such a way that
+ * they correspond to their 16x16 luma block.
+ */
+#define DRM_FORMAT_MOD_SAMSUNG_16_16_TILE	fourcc_mod_code(SAMSUNG, 2)
+
 /*
  * Qualcomm Compressed Format
  *