From patchwork Wed Aug 15 19:49:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10566781 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8519A14E1 for ; Wed, 15 Aug 2018 19:49:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3EE482AE7C for ; Wed, 15 Aug 2018 19:49:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1B87C2AE81; Wed, 15 Aug 2018 19:49:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B89F02AE7C for ; Wed, 15 Aug 2018 19:49:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E5D7D6E405; Wed, 15 Aug 2018 19:49:26 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yw1-xc44.google.com (mail-yw1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) by gabe.freedesktop.org (Postfix) with ESMTPS id DED606E405 for ; Wed, 15 Aug 2018 19:49:25 +0000 (UTC) Received: by mail-yw1-xc44.google.com with SMTP id z143-v6so1717495ywa.7 for ; Wed, 15 Aug 2018 12:49:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LRukt5IvTjpt3TG51fV2T1MSBfPnw67Ki7AAGQZ0yVY=; b=MAxs4YM+Y8VbVWouQjfL10cJsMwJSl5QdiYrGtGHO/qxjfudGmVKRF2S1bsl+QcKaO ozfNhUxGupYiVLSdUrwzMg/i+bpfZiEOjDexQvgw+V0jQnAWDNl3PVRMJT2MFXgG7lQq FS6WSBb+Y8DhIqd4hGoe/+fwlldlM6KUFm9TR/Ia2/26Pz250OUQYpdlEpKfeuJlQjrG vjZS4lBI9bLvJvKsygTVwEbrZPegxenjsDRvrG9iYhhjbj0e+jZ01h/5MyLxGCkBgldL wanXKh3pCVshYmi3n52OOWfNa5Dp19xIqY5IjFOR/1fz+JCfcH1XKxmrtmdj3+t4ySIU 43MA== X-Gm-Message-State: AOUpUlGeu7cVGQL/ZHTh8bW1zKiCB+/dIFbJmQTuLJz1LfukjRK/Degz RaBzD95aXaZDJeTzK1Mdx0atC1EG2uA= X-Google-Smtp-Source: AA+uWPz6Ken4JC7Ty2ePvWq4j8eKJieFipL9jyGVoig8iDON1PAiFSkxxFMHi1sTFLTXfBiNSlQc/A== X-Received: by 2002:a81:ae61:: with SMTP id g33-v6mr15460312ywk.74.1534362565011; Wed, 15 Aug 2018 12:49:25 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id t4-v6sm9692718ywa.51.2018.08.15.12.49.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Aug 2018 12:49:24 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/bridge: ti-sn65dsi86: Fix 0-day build error Date: Wed, 15 Aug 2018 15:49:14 -0400 Message-Id: <20180815194923.3258-1-sean@poorly.run> X-Mailer: git-send-email 2.18.0.865.gffc8e1a3cd6-goog MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , Laurent Pinchart , Guenter Roeck , Dylan Reid Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Guenter Roeck 0day reports: >> drivers/gpu/drm/bridge/ti-sn65dsi86.o: In function `ti_sn_bridge_remove': >> drivers/gpu/drm/bridge/ti-sn65dsi86.c:629: undefined reference to `mipi_dsi_detach' >> drivers/gpu/drm/bridge/ti-sn65dsi86.c:630: undefined reference to `mipi_dsi_device_unregister' drivers/gpu/drm/bridge/ti-sn65dsi86.o: In function `ti_sn_bridge_attach': >> drivers/gpu/drm/bridge/ti-sn65dsi86.c:249: undefined reference to `of_find_mipi_dsi_host_by_node' >> drivers/gpu/drm/bridge/ti-sn65dsi86.c:256: undefined reference to `mipi_dsi_device_register_full' >> drivers/gpu/drm/bridge/ti-sn65dsi86.c:276: undefined reference to `mipi_dsi_attach' drivers/gpu/drm/bridge/ti-sn65dsi86.c:289: undefined reference to `mipi_dsi_device_unregister' Quite obviously the driver depends on DRM_MIPI_DSI. We can not use "depends" since the driver configuration uses "select", so we'll have to select the missing dependency instead. Cc: Sean Paul Cc: Dylan Reid Signed-off-by: Guenter Roeck Reviewed-by: Daniel Vetter Reviewed-by: Andrzej Hajda --- Originally uploaded here: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1176224 drivers/gpu/drm/bridge/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 9a455c5f24f0..9eeb8ef0b174 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -142,6 +142,7 @@ config DRM_TI_SN65DSI86 select DRM_KMS_HELPER select REGMAP_I2C select DRM_PANEL + select DRM_MIPI_DSI help Texas Instruments SN65DSI86 DSI to eDP Bridge driver