diff mbox series

drm/pl111: add in missing sentinel to a of_device_id array

Message ID 20180821105407.2318-1-colin.king@canonical.com (mailing list archive)
State New, archived
Headers show
Series drm/pl111: add in missing sentinel to a of_device_id array | expand

Commit Message

Colin King Aug. 21, 2018, 10:54 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Array vexpress_muxfpga_match is missing an end of array sentinel,
add it.

Detected by Coccinelle: ("vexpress_muxfpga_match is not NULL
terminated at line")

Fixes: ca454bd42dc2 ("drm/pl111: Support the Versatile Express")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/pl111/pl111_vexpress.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Linus Walleij Aug. 23, 2018, 10:55 a.m. UTC | #1 
On Tue, Aug 21, 2018 at 12:54 PM Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Array vexpress_muxfpga_match is missing an end of array sentinel,
> add it.
>
> Detected by Coccinelle: ("vexpress_muxfpga_match is not NULL
> terminated at line")
>
> Fixes: ca454bd42dc2 ("drm/pl111: Support the Versatile Express")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
zhong jiang Aug. 23, 2018, 11:16 a.m. UTC | #2 
Hi,  Colin

I has posted the same patch about a month ago. but it seems to be ignored.:-(

https://lore.kernel.org/patchwork/patch/971652/

Thanks,
zhong jiang

On 2018/8/21 18:54, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Array vexpress_muxfpga_match is missing an end of array sentinel,
> add it.
>
> Detected by Coccinelle: ("vexpress_muxfpga_match is not NULL
> terminated at line")
>
> Fixes: ca454bd42dc2 ("drm/pl111: Support the Versatile Express")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/gpu/drm/pl111/pl111_vexpress.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_vexpress.c b/drivers/gpu/drm/pl111/pl111_vexpress.c
> index a534b225e31b..48e2afcd4798 100644
> --- a/drivers/gpu/drm/pl111/pl111_vexpress.c
> +++ b/drivers/gpu/drm/pl111/pl111_vexpress.c
> @@ -111,7 +111,8 @@ static int vexpress_muxfpga_probe(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id vexpress_muxfpga_match[] = {
> -	{ .compatible = "arm,vexpress-muxfpga", }
> +	{ .compatible = "arm,vexpress-muxfpga", },
> +	{ /* sentinel */ }
>  };
>  
>  static struct platform_driver vexpress_muxfpga_driver = {
Linus Walleij Aug. 28, 2018, 8:46 p.m. UTC | #3 
On Thu, Aug 23, 2018 at 1:16 PM zhong jiang <zhongjiang@huawei.com> wrote:

> I has posted the same patch about a month ago. but it seems to be ignored.:-(
>
> https://lore.kernel.org/patchwork/patch/971652/

I applied your patch and pushed it.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/gpu/drm/pl111/pl111_vexpress.c b/drivers/gpu/drm/pl111/pl111_vexpress.c
index a534b225e31b..48e2afcd4798 100644
--- a/drivers/gpu/drm/pl111/pl111_vexpress.c
+++ b/drivers/gpu/drm/pl111/pl111_vexpress.c
@@ -111,7 +111,8 @@  static int vexpress_muxfpga_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id vexpress_muxfpga_match[] = {
-	{ .compatible = "arm,vexpress-muxfpga", }
+	{ .compatible = "arm,vexpress-muxfpga", },
+	{ /* sentinel */ }
 };
 
 static struct platform_driver vexpress_muxfpga_driver = {