diff mbox series

drm/scheduler: avoid redundant shifting of the entity v2

Message ID 20180821132908.12892-1-nayan26deshmukh@gmail.com (mailing list archive)
State New, archived
Headers show
Series drm/scheduler: avoid redundant shifting of the entity v2 | expand

Commit Message

Nayan Deshmukh Aug. 21, 2018, 1:29 p.m. UTC 
do not remove entity from the rq if the current rq is from
the least loaded scheduler.

Signed-off-by: Nayan Deshmukh <nayan26deshmukh@gmail.com>
---
 drivers/gpu/drm/scheduler/sched_entity.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Christian König Aug. 21, 2018, 1:38 p.m. UTC | #1 
Am 21.08.2018 um 15:29 schrieb Nayan Deshmukh:
> do not remove entity from the rq if the current rq is from
> the least loaded scheduler.
>
> Signed-off-by: Nayan Deshmukh <nayan26deshmukh@gmail.com>

Reviewed and pushed into our internal repo.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/scheduler/sched_entity.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
> index 1416edb2642a..a51c7654cc78 100644
> --- a/drivers/gpu/drm/scheduler/sched_entity.c
> +++ b/drivers/gpu/drm/scheduler/sched_entity.c
> @@ -472,6 +472,9 @@ void drm_sched_entity_select_rq(struct drm_sched_entity *entity)
>   		return;
>   
>   	rq = drm_sched_entity_get_free_sched(entity);
> +	if (rq == entity->rq)
> +		return;
> +
>   	spin_lock(&entity->rq_lock);
>   	drm_sched_rq_remove_entity(entity->rq, entity);
>   	entity->rq = rq;
diff mbox series

Patch

diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
index 1416edb2642a..a51c7654cc78 100644
--- a/drivers/gpu/drm/scheduler/sched_entity.c
+++ b/drivers/gpu/drm/scheduler/sched_entity.c
@@ -472,6 +472,9 @@  void drm_sched_entity_select_rq(struct drm_sched_entity *entity)
 		return;
 
 	rq = drm_sched_entity_get_free_sched(entity);
+	if (rq == entity->rq)
+		return;
+
 	spin_lock(&entity->rq_lock);
 	drm_sched_rq_remove_entity(entity->rq, entity);
 	entity->rq = rq;