| Message ID | 20180823082542.2998-1-david1.zhou@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] drm: fix syncobj null_fence_enable_signaling | expand |
Am 23.08.2018 um 10:25 schrieb Chunming Zhou: > That is certainly totally nonsense. dma_fence_enable_sw_signaling() > is the function who is calling this callback. > > Signed-off-by: Chunming Zhou <david1.zhou@amd.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> For this one: Reviewed-by: Christian König <christian.koenig@amd.com> > --- > drivers/gpu/drm/drm_syncobj.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c > index 3a8837c49639..d17ed75ac7e2 100644 > --- a/drivers/gpu/drm/drm_syncobj.c > +++ b/drivers/gpu/drm/drm_syncobj.c > @@ -184,7 +184,6 @@ static const char *drm_syncobj_null_fence_get_name(struct dma_fence *fence) > > static bool drm_syncobj_null_fence_enable_signaling(struct dma_fence *fence) > { > - dma_fence_enable_sw_signaling(fence); > return !dma_fence_is_signaled(fence); > } >
On Thu, Aug 23, 2018 at 11:02 AM, Christian König <ckoenig.leichtzumerken@gmail.com> wrote: > Am 23.08.2018 um 10:25 schrieb Chunming Zhou: >> >> That is certainly totally nonsense. dma_fence_enable_sw_signaling() >> is the function who is calling this callback. >> >> Signed-off-by: Chunming Zhou <david1.zhou@amd.com> >> Cc: Jason Ekstrand <jason@jlekstrand.net> > > > For this one: Reviewed-by: Christian König <christian.koenig@amd.com> As mentioned in the v1 thread, you can outright nuke this, no longer needed. But this at least makes sense now. Ack either way. -Daniel > >> --- >> drivers/gpu/drm/drm_syncobj.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c >> index 3a8837c49639..d17ed75ac7e2 100644 >> --- a/drivers/gpu/drm/drm_syncobj.c >> +++ b/drivers/gpu/drm/drm_syncobj.c >> @@ -184,7 +184,6 @@ static const char >> *drm_syncobj_null_fence_get_name(struct dma_fence *fence) >> static bool drm_syncobj_null_fence_enable_signaling(struct dma_fence >> *fence) >> { >> - dma_fence_enable_sw_signaling(fence); >> return !dma_fence_is_signaled(fence); >> } >> > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 3a8837c49639..d17ed75ac7e2 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -184,7 +184,6 @@ static const char *drm_syncobj_null_fence_get_name(struct dma_fence *fence) static bool drm_syncobj_null_fence_enable_signaling(struct dma_fence *fence) { - dma_fence_enable_sw_signaling(fence); return !dma_fence_is_signaled(fence); }
That is certainly totally nonsense. dma_fence_enable_sw_signaling() is the function who is calling this callback. Signed-off-by: Chunming Zhou <david1.zhou@amd.com> Cc: Jason Ekstrand <jason@jlekstrand.net> --- drivers/gpu/drm/drm_syncobj.c | 1 - 1 file changed, 1 deletion(-)